Issues in class-aweber.php (master) - Issues in master - ThemeAvenue/BetterOptin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (103)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/providers/aweber/class-aweber.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * BetterOptin Provider Aweber
 *
 * @package   BetterOptin/Provider/Aweber/Settingd
 * @author    ThemeAvenue <[email protected]>
 * @license   GPL-2.0+
 * @link      http://themeavenue.net
 * @copyright 2015 ThemeAvenue
 */

// If this file is called directly, abort.
if ( ! defined( 'WPINC' ) ) {
	die;
}

class WPBO_Aweber {

	/**
	 * Aweber authorization code
	 *
	 * @since 2.0
	 * @var string
	 */
	private $auth_code;

	/**
	 * Aweber API key
	 *
	 * @since 2.0
	 * @var string
	 */
	private $api_key;

	/**
	 * Aweber API secret key
	 *
	 * @since 2.0
	 * @var string
	 */
	private $api_secret;

	/**
	 * Aweber app access token
	 *
	 * @since 2.0
	 * @var string
	 */
	private $access_token = '';

	/**
	 * Aweber app access secret
	 *
	 * @since 2.0
	 * @var string
	 */
	private $access_secret = '';

	/**
	 * Aweber registered app ID
	 *
	 * @since 2.0
	 * @var string
	 */
	public static $app_id = '0cdbc51e';

	/**
	 * Aweber list ID
	 *
	 * @since 2.0
	 * @var string
	 */
	private $list_id;

	/**
	 * Aweber app authorize URL
	 *
	 * @since 2.0
	 * @var string
	 */
	public static $authorize_url = 'https://auth.aweber.com/1.0/oauth/authorize_app/';

	/**
	 * Instance of the Aweber class
	 *
	 * @since 2.0
	 * @var AWeberAPI
	 */
	private $aweber;

	/**
	 * Aweber user account
	 *
	 * @since 2.0
	 * @var
	 */
	private $account;

	/**
	 * Holds possible errors if the Aweber class can't be instantiated
	 *
	 * @since 2.0
	 * @var null|WP_Error
	 */
	public $error;

	public function __construct() {

		if ( ! class_exists( 'AWeberAPI' ) ) {
			require( WPBO_PATH . 'vendor/aweber/aweber/aweber_api/aweber.php' );
		}

		$this->auth_code  = trim( wpbo_get_option( 'aw_auth_code', '' ) );
		$this->api_key    = false !== $this->get_credentials() ? $this->get_credentials()['consumerKey'] : '';
		$this->api_secret = false !== $this->get_credentials() ? $this->get_credentials()['consumerSecret'] : '';
		$this->list_id    = wpbo_get_option( 'aw_list_id', '' );
		$this->get_tokens();

	}

	public static function get_authorization_url() {
		return self::$authorize_url . self::$app_id;
	}

	/**
	 * Get Aweber authorization tokens
	 *
	 * Try and get the tokens from the database. If no token is found, we query Aweber and request
	 * authorization.
	 *
	 * @since 1.0
	 * @return bool|WP_Error True if the auth tokens are set, WP_Error otherwise
	 */
	private function get_tokens() {

		$tokens = maybe_unserialize( get_option( 'wpbo_aweber_tokens' ) );

		if ( empty( $tokens ) || ! is_array( $tokens ) ) {
			$tokens = $this->get_access_tokens();
		}

		if ( is_wp_error( $tokens ) ) {
			return $tokens;
		}

		$this->access_token  = isset( $tokens[0] ) ? trim( $tokens[0] ) : '';
		$this->access_secret = isset( $tokens[1] ) ? trim( $tokens[1] ) : '';

		return true;

	}

	/**
	 * Get access tokens from Aweber.
	 *
	 * @return array Aweber tokens
	 * @since  1.0.0
	 */
	protected function get_access_tokens() {

		if ( is_wp_error( $this->aweber() ) ) {
			return $this->aweber();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		}

		/* Get credentials from Aweber key */
		$credentials = $this->get_credentials();

		if ( false === $credentials ) {
			return $this->error = new WP_Error( 'aweber_missing_auth_code', esc_html__( 'Aweber authorization code is missing', 'betteroptin' ) );
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		}

		/* Set tokens */
		$this->aweber()->adapter->user->requestToken = $credentials['requestToken'];
		$this->aweber()->adapter->user->tokenSecret  = $credentials['tokenSecret'];
		$this->aweber()->adapter->user->verifier     = $credentials['verifier'];

		/* Request access tokens */
		try {

			$access_tokens = $this->aweber()->getAccessToken();
			$this->access_token  = $access_tokens[0];
			$this->access_secret = $access_tokens[1];

			/* Save access tokens */
			update_option( 'wpbo_aweber_tokens', $access_tokens );

			return $access_tokens;

		} catch ( Exception $e ) {
			return $this->error = new WP_Error( '', esc_html__( 'The Aweber authorization code you provided is incorrect or expired. Please authorize the plugin again.', 'betteroptin' ) );
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		}

	}

	/**
	 * Get the instance of the Aweber class
	 *
	 * @since 2.0
	 * @return AWeberAPI|WP_Error
	 */
	public function aweber() {

		if ( is_object( $this->aweber ) && is_a( $this->aweber, 'AWeberAPI' ) ) {
			return $this->aweber;
		}

		/* Make sure we have the tokens */
		if ( empty( $this->api_key ) || empty( $this->api_secret ) ) {
			return $this->error = new WP_Error( 'missing_tokens', __( 'Aweber API keys are missing.', 'betteroptin' ) );
		}

		return $this->aweber = new AWeberAPI( $this->api_key, $this->api_secret );

	}

	/**
	 * Get an account instance.
	 *
	 * @return object User account instance
	 */
	public function account() {

		if ( ! is_null( $this->account ) ) {
			return $this->account;
		}

		/* Get user account */
		try {
			$this->account = $this->aweber()->getAccount( $this->access_token, $this->access_secret );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		} catch ( Exception $e ) {
			return $this->error = new WP_Error( 'aweber_connection_error', __( 'Unable to connect to Aweber', 'betteroptin' ) );
		}

		return $this->account;

	}

	/**
	 * Get account credentials.
	 *
	 * Takes the authorization code and extract account credentials.
	 *
	 * @since  1.0.0
	 * @return array Credentials
	 */
	protected function get_credentials() {

		if ( empty( $this->auth_code ) ) {
			return false;
		}

		$code = explode( '|', $this->auth_code );

		$credentials = array(
			'consumerKey'    => trim( $code[0] ),
			'consumerSecret' => trim( $code[1] ),
			'requestToken'   => trim( $code[2] ),
			'tokenSecret'    => trim( $code[3] ),
			'verifier'       => trim( $code[4] ),
		);

		return $credentials;

	}

	/**
	 * Subscribe the visitor to a list.
	 *
	 * @since  1.0.0
	 *
	 * @param array $data Form post data
	 *
	 * @return array Result
	 */
	public function subscribe( $data ) {

		if ( is_wp_error( $this->account() ) ) {
			return $this->account();
		}

		$account_id  = $this->account()->data['id'];
		$list_custom = get_post_meta( (int) $data['wpbo_id'], 'wpbo_aw_list', true );
		$list_id     = ( '' != $list_custom ) ? $list_custom : $this->list_id;
		$list_url    = "/accounts/$account_id/lists/$list_id";
		$subscriber  = array( 'email' => sanitize_email( $data['email'] ), 'name' => $data['name'] );

		/* Subscribe the new user */
		try {

			$list          = $this->account()->loadFromUrl( $list_url );
			$newSubscriber = $list->subscribers->create( $subscriber );
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

			return true;

		} catch ( Exception $exc ) {
			return false;
		}

	}

	/**
	 * Get user lists.
	 *
	 * @since  1.0.0
	 * @return array Array of available lists for this account
	 */
	public function get_lists() {

		$lists = maybe_unserialize( get_transient( 'wpbo_aw_lists' ) );

		if ( is_array( $lists ) ) {
			return $lists;
		}

		if ( is_wp_error( $this->account() ) ) {
			return array();
		}

		foreach ( $this->account()->lists as $list ) {
			$lists[] = array( 'id' => $list->id, 'name' => $list->name );
		}

		/* Cache the lists to avoid slow loading */
		set_transient( 'wpbo_aw_lists', $lists, 24 * 60 * 60 );

		return $lists;

	}

	public function is_error() {
		return $this->error;
	}

}

1			<?php
2			/**
3			* BetterOptin Provider Aweber
4			*
5			* @package BetterOptin/Provider/Aweber/Settingd
6			* @author ThemeAvenue <[email protected]>
7			* @license GPL-2.0+
8			* @link http://themeavenue.net
9			* @copyright 2015 ThemeAvenue
10			*/
11
12			// If this file is called directly, abort.
13			if ( ! defined( 'WPINC' ) ) {
14			die;
15			}
16
17			class WPBO_Aweber {
18
19			/**
20			* Aweber authorization code
21			*
22			* @since 2.0
23			* @var string
24			*/
25			private $auth_code;
26
27			/**
28			* Aweber API key
29			*
30			* @since 2.0
31			* @var string
32			*/
33			private $api_key;
34
35			/**
36			* Aweber API secret key
37			*
38			* @since 2.0
39			* @var string
40			*/
41			private $api_secret;
42
43			/**
44			* Aweber app access token
45			*
46			* @since 2.0
47			* @var string
48			*/
49			private $access_token = '';
50
51			/**
52			* Aweber app access secret
53			*
54			* @since 2.0
55			* @var string
56			*/
57			private $access_secret = '';
58
59			/**
60			* Aweber registered app ID
61			*
62			* @since 2.0
63			* @var string
64			*/
65			public static $app_id = '0cdbc51e';
66
67			/**
68			* Aweber list ID
69			*
70			* @since 2.0
71			* @var string
72			*/
73			private $list_id;
74
75			/**
76			* Aweber app authorize URL
77			*
78			* @since 2.0
79			* @var string
80			*/
81			public static $authorize_url = 'https://auth.aweber.com/1.0/oauth/authorize_app/';
82
83			/**
84			* Instance of the Aweber class
85			*
86			* @since 2.0
87			* @var AWeberAPI
88			*/
89			private $aweber;
90
91			/**
92			* Aweber user account
93			*
94			* @since 2.0
95			* @var
96			*/
97			private $account;
98
99			/**
100			* Holds possible errors if the Aweber class can't be instantiated
101			*
102			* @since 2.0
103			* @var null\|WP_Error
104			*/
105			public $error;
106
107			public function __construct() {
108
109			if ( ! class_exists( 'AWeberAPI' ) ) {
110			require( WPBO_PATH . 'vendor/aweber/aweber/aweber_api/aweber.php' );
111			}
112
113			$this->auth_code = trim( wpbo_get_option( 'aw_auth_code', '' ) );
114			$this->api_key = false !== $this->get_credentials() ? $this->get_credentials()['consumerKey'] : '';
115			$this->api_secret = false !== $this->get_credentials() ? $this->get_credentials()['consumerSecret'] : '';
116			$this->list_id = wpbo_get_option( 'aw_list_id', '' );
117			$this->get_tokens();
118
119			}
120
121			public static function get_authorization_url() {
122			return self::$authorize_url . self::$app_id;
123			}
124
125			/**
126			* Get Aweber authorization tokens
127			*
128			* Try and get the tokens from the database. If no token is found, we query Aweber and request
129			* authorization.
130			*
131			* @since 1.0
132			* @return bool\|WP_Error True if the auth tokens are set, WP_Error otherwise
133			*/
134			private function get_tokens() {
135
136			$tokens = maybe_unserialize( get_option( 'wpbo_aweber_tokens' ) );
137
138			if ( empty( $tokens ) \|\| ! is_array( $tokens ) ) {
139			$tokens = $this->get_access_tokens();
140			}
141
142			if ( is_wp_error( $tokens ) ) {
143			return $tokens;
144			}
145
146			$this->access_token = isset( $tokens[0] ) ? trim( $tokens[0] ) : '';
147			$this->access_secret = isset( $tokens[1] ) ? trim( $tokens[1] ) : '';
148
149			return true;
150
151			}
152
153			/**
154			* Get access tokens from Aweber.
155			*
156			* @return array Aweber tokens
157			* @since 1.0.0
158			*/
159			protected function get_access_tokens() {
160
161			if ( is_wp_error( $this->aweber() ) ) {
162			return $this->aweber();
			0 ignored issues – show Bug Best Practice introduced 2015-11-30 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->aweber();` (`AWeberAPI\|WP_Error`) is incompatible with the return type documented by `WPBO_Aweber::get_access_tokens` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
163			}
164
165			/* Get credentials from Aweber key */
166			$credentials = $this->get_credentials();
167
168			if ( false === $credentials ) {
169			return $this->error = new WP_Error( 'aweber_missing_auth_code', esc_html__( 'Aweber authorization code is missing', 'betteroptin' ) );
			0 ignored issues – show Bug Best Practice introduced 2015-11-30 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->error = ne...sing', 'betteroptin'));` (`WP_Error`) is incompatible with the return type documented by `WPBO_Aweber::get_access_tokens` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
170			}
171
172			/* Set tokens */
173			$this->aweber()->adapter->user->requestToken = $credentials['requestToken'];
174			$this->aweber()->adapter->user->tokenSecret = $credentials['tokenSecret'];
175			$this->aweber()->adapter->user->verifier = $credentials['verifier'];
176
177			/* Request access tokens */
178			try {
179
180			$access_tokens = $this->aweber()->getAccessToken();
181			$this->access_token = $access_tokens[0];
182			$this->access_secret = $access_tokens[1];
183
184			/* Save access tokens */
185			update_option( 'wpbo_aweber_tokens', $access_tokens );
186
187			return $access_tokens;
188
189			} catch ( Exception $e ) {
190			return $this->error = new WP_Error( '', esc_html__( 'The Aweber authorization code you provided is incorrect or expired. Please authorize the plugin again.', 'betteroptin' ) );
			0 ignored issues – show Bug Best Practice introduced 2015-11-30 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->error = ne...ain.', 'betteroptin'));` (`WP_Error`) is incompatible with the return type documented by `WPBO_Aweber::get_access_tokens` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
191			}
192
193			}
194
195			/**
196			* Get the instance of the Aweber class
197			*
198			* @since 2.0
199			* @return AWeberAPI\|WP_Error
200			*/
201			public function aweber() {
202
203			if ( is_object( $this->aweber ) && is_a( $this->aweber, 'AWeberAPI' ) ) {
204			return $this->aweber;
205			}
206
207			/* Make sure we have the tokens */
208			if ( empty( $this->api_key ) \|\| empty( $this->api_secret ) ) {
209			return $this->error = new WP_Error( 'missing_tokens', __( 'Aweber API keys are missing.', 'betteroptin' ) );
210			}
211
212			return $this->aweber = new AWeberAPI( $this->api_key, $this->api_secret );
213
214			}
215
216			/**
217			* Get an account instance.
218			*
219			* @return object User account instance
220			*/
221			public function account() {
222
223			if ( ! is_null( $this->account ) ) {
224			return $this->account;
225			}
226
227			/* Get user account */
228			try {
229			$this->account = $this->aweber()->getAccount( $this->access_token, $this->access_secret );
			0 ignored issues – show Documentation introduced 2015-11-30 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->access_token` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2015-11-30 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->access_secret` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
230			} catch ( Exception $e ) {
231			return $this->error = new WP_Error( 'aweber_connection_error', __( 'Unable to connect to Aweber', 'betteroptin' ) );
232			}
233
234			return $this->account;
235
236			}
237
238			/**
239			* Get account credentials.
240			*
241			* Takes the authorization code and extract account credentials.
242			*
243			* @since 1.0.0
244			* @return array Credentials
245			*/
246			protected function get_credentials() {
247
248			if ( empty( $this->auth_code ) ) {
249			return false;
250			}
251
252			$code = explode( '\|', $this->auth_code );
253
254			$credentials = array(
255			'consumerKey' => trim( $code[0] ),
256			'consumerSecret' => trim( $code[1] ),
257			'requestToken' => trim( $code[2] ),
258			'tokenSecret' => trim( $code[3] ),
259			'verifier' => trim( $code[4] ),
260			);
261
262			return $credentials;
263
264			}
265
266			/**
267			* Subscribe the visitor to a list.
268			*
269			* @since 1.0.0
270			*
271			* @param array $data Form post data
272			*
273			* @return array Result
274			*/
275			public function subscribe( $data ) {
276
277			if ( is_wp_error( $this->account() ) ) {
278			return $this->account();
279			}
280
281			$account_id = $this->account()->data['id'];
282			$list_custom = get_post_meta( (int) $data['wpbo_id'], 'wpbo_aw_list', true );
283			$list_id = ( '' != $list_custom ) ? $list_custom : $this->list_id;
284			$list_url = "/accounts/$account_id/lists/$list_id";
285			$subscriber = array( 'email' => sanitize_email( $data['email'] ), 'name' => $data['name'] );
286
287			/* Subscribe the new user */
288			try {
289
290			$list = $this->account()->loadFromUrl( $list_url );
291			$newSubscriber = $list->subscribers->create( $subscriber );
			0 ignored issues – show Unused Code introduced 2015-11-30 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$newSubscriber` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
292
293			return true;
294
295			} catch ( Exception $exc ) {
296			return false;
297			}
298
299			}
300
301			/**
302			* Get user lists.
303			*
304			* @since 1.0.0
305			* @return array Array of available lists for this account
306			*/
307			public function get_lists() {
308
309			$lists = maybe_unserialize( get_transient( 'wpbo_aw_lists' ) );
310
311			if ( is_array( $lists ) ) {
312			return $lists;
313			}
314
315			if ( is_wp_error( $this->account() ) ) {
316			return array();
317			}
318
319			foreach ( $this->account()->lists as $list ) {
320			$lists[] = array( 'id' => $list->id, 'name' => $list->name );
321			}
322
323			/* Cache the lists to avoid slow loading */
324			set_transient( 'wpbo_aw_lists', $lists, 24 * 60 * 60 );
325
326			return $lists;
327
328			}
329
330			public function is_error() {
331			return $this->error;
332			}
333
334			}

ThemeAvenue / BetterOptin

Issues (103)

Security Analysis not enabled

includes/providers/aweber/class-aweber.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like