functions-dummy.php ➔ wpbo_input_dummy() - Code Metrics - Inspection of "Remove EDD Updater workaround and be ready for nex..." - ThemeAvenue/BetterOptin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 42ba23...5fbbab )

by Julien

created 2016-05-12 10:32 UTC

functions-dummy.php ➔ wpbo_input_dummy() B

↳ Parent: Project

Complexity

Conditions	8
Paths	14

Size

Total Lines	53
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	8
eloc	25
c	1
b	0
f	0
nc	14
nop	1
dl	0
loc	53
rs	7.1199

How to fix Long Method

<?php
/**
 * Generate random date.
 *
 * @see  http://stackoverflow.com/a/14186825
 * @param  [type] $min_date [description]

 * @param  [type] $max_date [description]

 * @return [type]           [description]

 */
function wpbo_rand_date( $min_date, $max_date ) {
    /* Gets 2 dates as string, earlier and later date.
       Returns date in between them.
    */

    $rand_epoch = rand( $min_date, $max_date );

    return date( 'Y-m-d H:i:s', $rand_epoch );
}

function wpbo_input_dummy( $lines = 5 ) {

	if( isset( $_GET['wpbo_dummy'] ) && is_numeric( $_GET['wpbo_dummy'] ) )
		$lines = $_GET['wpbo_dummy'];

	/* Max conversion rate */
	$ratio = 10;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

	/* Max conversion added based on max ratio */
	$max = ( 20 * $lines ) / 100;

	$args = array(
		'post_type'      => 'wpbo-popup',
		'post_status'    => 'publish',
		'posts_per_page' => -1,
		
	);

	$popups = new WP_Query( $args );

	if( count( $popups->posts ) >= 1 ) {

		foreach( $popups->posts as $popup ) {

			/* Count ratio */
			$limit = 0;

			$types = array(
				'impression',
				'conversion'
			);
			
			for( $count = 0; $count <= $lines; $count++ ) {

				if( $limit >= $max )
					$types[1] = 'impression';

				$dtype = rand( 0, 1 );
				$dtype = $types[$dtype];
				$time  = wpbo_rand_date( strtotime( 'first day of January last year', time() ), strtotime( 'last day of December this year', time() ) );

				if( $dtype === 'conversion' )
					++$limit;

				wpbo_db_insert_data( array( 'time' => $time, 'data_type' => $dtype, 'popup_id' => $popup->ID, ), false );

			}

		}

	}

}

function wpbo_add_dummy() {
	add_action( 'init', 'wpbo_input_dummy' );
}

if ( isset( $_GET['wpbo_dummy'] ) ) {
	wpbo_add_dummy();
}

1			<?php
2			/**
3			* Generate random date.
4			*
5			* @see http://stackoverflow.com/a/14186825
6			* @param [type] $min_date [description]
			0 ignored issues – show Documentation introduced 2015-11-30 08:11 UTC by Report Bug Copy Issue Report The doc-type `[type]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
7			* @param [type] $max_date [description]
			0 ignored issues – show Documentation introduced 2015-11-30 08:11 UTC by Report Bug Copy Issue Report The doc-type `[type]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
8			* @return [type] [description]
			0 ignored issues – show Documentation introduced 2015-11-30 08:11 UTC by Report Bug Copy Issue Report The doc-type `[type]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
9			*/
10			function wpbo_rand_date( $min_date, $max_date ) {
11			/* Gets 2 dates as string, earlier and later date.
12			Returns date in between them.
13			*/
14
15			$rand_epoch = rand( $min_date, $max_date );
16
17			return date( 'Y-m-d H:i:s', $rand_epoch );
18			}
19
20			function wpbo_input_dummy( $lines = 5 ) {
21
22			if( isset( $_GET['wpbo_dummy'] ) && is_numeric( $_GET['wpbo_dummy'] ) )
23			$lines = $_GET['wpbo_dummy'];
24
25			/* Max conversion rate */
26			$ratio = 10;
			0 ignored issues – show Unused Code introduced 2015-11-30 08:11 UTC by Report Bug Copy Issue Report `$ratio` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
27
28			/* Max conversion added based on max ratio */
29			$max = ( 20 * $lines ) / 100;
30
31			$args = array(
32			'post_type' => 'wpbo-popup',
33			'post_status' => 'publish',
34			'posts_per_page' => -1,
35
36			);
37
38			$popups = new WP_Query( $args );
39
40			if( count( $popups->posts ) >= 1 ) {
41
42			foreach( $popups->posts as $popup ) {
43
44			/* Count ratio */
45			$limit = 0;
46
47			$types = array(
48			'impression',
49			'conversion'
50			);
51
52			for( $count = 0; $count <= $lines; $count++ ) {
53
54			if( $limit >= $max )
55			$types[1] = 'impression';
56
57			$dtype = rand( 0, 1 );
58			$dtype = $types[$dtype];
59			$time = wpbo_rand_date( strtotime( 'first day of January last year', time() ), strtotime( 'last day of December this year', time() ) );
60
61			if( $dtype === 'conversion' )
62			++$limit;
63
64			wpbo_db_insert_data( array( 'time' => $time, 'data_type' => $dtype, 'popup_id' => $popup->ID, ), false );
65
66			}
67
68			}
69
70			}
71
72			}
73
74			function wpbo_add_dummy() {
75			add_action( 'init', 'wpbo_input_dummy' );
76			}
77
78			if ( isset( $_GET['wpbo_dummy'] ) ) {
79			wpbo_add_dummy();
80			}

ThemeAvenue / BetterOptin

Push — master ( 42ba23...5fbbab )

functions-dummy.php ➔ wpbo_input_dummy() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like