Inspection of "Merge pull request #4 from TheRakeshPurohit/scruti..." - TheRakeshPurohit/rtCamp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 276db7...0bd148 )

by Rakesh

created 2019-06-12 12:26 UTC

Status

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -83,11 +83,11 @@
 block discarded – undo
     protected function takeAttributeFromDOM($attribute)
     {
         switch ($attribute->localName) {
-        case 'value':
-            $this->_value = $attribute->nodeValue;
-            break;
-        default:
-            parent::takeAttributeFromDOM($attribute);
+            case 'value':
+                $this->_value = $attribute->nodeValue;
+                break;
+            default:
+                parent::takeAttributeFromDOM($attribute);
         }
     }
 

Please login to merge, or discard this patch.

lib/Zend/Gdata/Calendar/Extension/SendEventNotifications.php 2 patches

Switch Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -82,19 +82,19 @@
 block discarded – undo
     protected function takeAttributeFromDOM($attribute)
     {
         switch ($attribute->localName) {
-        case 'value':
-            if ($attribute->nodeValue == "true") {
-                $this->_value = true;
-            }
-            else if ($attribute->nodeValue == "false") {
-                $this->_value = false;
-            }
-            else {
-                throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
-            }
-            break;
-        default:
-            parent::takeAttributeFromDOM($attribute);
+            case 'value':
+                if ($attribute->nodeValue == "true") {
+                    $this->_value = true;
+                }
+                else if ($attribute->nodeValue == "false") {
+                    $this->_value = false;
+                }
+                else {
+                    throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
+                }
+                break;
+            default:
+                parent::takeAttributeFromDOM($attribute);
         }
     }
 

Please login to merge, or discard this patch.

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -85,11 +85,9 @@
 block discarded – undo
         case 'value':
             if ($attribute->nodeValue == "true") {
                 $this->_value = true;
-            }
-            else if ($attribute->nodeValue == "false") {
+            } else if ($attribute->nodeValue == "false") {
                 $this->_value = false;
-            }
-            else {
+            } else {
                 throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
             }
             break;

Please login to merge, or discard this patch.

lib/Zend/Gdata/Calendar/Extension/Hidden.php 2 patches

Switch Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -82,20 +82,20 @@
 block discarded – undo
     protected function takeAttributeFromDOM($attribute)
     {
         switch ($attribute->localName) {
-        case 'value':
-            if ($attribute->nodeValue == "true") {
-                $this->_value = true;
-            }
-            else if ($attribute->nodeValue == "false") {
-                $this->_value = false;
-            }
-            else {
-                require_once 'Zend/Gdata/App/InvalidArgumentException.php';
-                throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
-            }
-            break;
-        default:
-            parent::takeAttributeFromDOM($attribute);
+            case 'value':
+                if ($attribute->nodeValue == "true") {
+                    $this->_value = true;
+                }
+                else if ($attribute->nodeValue == "false") {
+                    $this->_value = false;
+                }
+                else {
+                    require_once 'Zend/Gdata/App/InvalidArgumentException.php';
+                    throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
+                }
+                break;
+            default:
+                parent::takeAttributeFromDOM($attribute);
         }
     }
 

Please login to merge, or discard this patch.

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -85,11 +85,9 @@
 block discarded – undo
         case 'value':
             if ($attribute->nodeValue == "true") {
                 $this->_value = true;
-            }
-            else if ($attribute->nodeValue == "false") {
+            } else if ($attribute->nodeValue == "false") {
                 $this->_value = false;
-            }
-            else {
+            } else {
                 require_once 'Zend/Gdata/App/InvalidArgumentException.php';
                 throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
             }

Please login to merge, or discard this patch.

lib/Zend/Gdata/Calendar/Extension/AccessLevel.php 1 patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -83,11 +83,11 @@
 block discarded – undo
     protected function takeAttributeFromDOM($attribute)
     {
         switch ($attribute->localName) {
-        case 'value':
-            $this->_value = $attribute->nodeValue;
-            break;
-        default:
-            parent::takeAttributeFromDOM($attribute);
+            case 'value':
+                $this->_value = $attribute->nodeValue;
+                break;
+            default:
+                parent::takeAttributeFromDOM($attribute);
         }
     }
 

Please login to merge, or discard this patch.

lib/Zend/Gdata/Extension/Visibility.php 1 patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -83,11 +83,11 @@
 block discarded – undo
     protected function takeAttributeFromDOM($attribute)
     {
         switch ($attribute->localName) {
-        case 'value':
-            $this->_value = $attribute->nodeValue;
-            break;
-        default:
-            parent::takeAttributeFromDOM($attribute);
+            case 'value':
+                $this->_value = $attribute->nodeValue;
+                break;
+            default:
+                parent::takeAttributeFromDOM($attribute);
         }
     }
 

Please login to merge, or discard this patch.

lib/Zend/Gdata/Extension/AttendeeType.php 1 patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -83,11 +83,11 @@
 block discarded – undo
     protected function takeAttributeFromDOM($attribute)
     {
         switch ($attribute->localName) {
-        case 'value':
-            $this->_value = $attribute->nodeValue;
-            break;
-        default:
-            parent::takeAttributeFromDOM($attribute);
+            case 'value':
+                $this->_value = $attribute->nodeValue;
+                break;
+            default:
+                parent::takeAttributeFromDOM($attribute);
         }
     }
 

Please login to merge, or discard this patch.

lib/Zend/Gdata/Extension/AttendeeStatus.php 1 patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -83,11 +83,11 @@
 block discarded – undo
     protected function takeAttributeFromDOM($attribute)
     {
         switch ($attribute->localName) {
-        case 'value':
-            $this->_value = $attribute->nodeValue;
-            break;
-        default:
-            parent::takeAttributeFromDOM($attribute);
+            case 'value':
+                $this->_value = $attribute->nodeValue;
+                break;
+            default:
+                parent::takeAttributeFromDOM($attribute);
         }
     }
 

Please login to merge, or discard this patch.

lib/Zend/Gdata/Extension/Transparency.php 1 patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -83,11 +83,11 @@
 block discarded – undo
     protected function takeAttributeFromDOM($attribute)
     {
         switch ($attribute->localName) {
-        case 'value':
-            $this->_value = $attribute->nodeValue;
-            break;
-        default:
-            parent::takeAttributeFromDOM($attribute);
+            case 'value':
+                $this->_value = $attribute->nodeValue;
+                break;
+            default:
+                parent::takeAttributeFromDOM($attribute);
         }
     }
 

Please login to merge, or discard this patch.

lib/Zend/Gdata/Extension/EventStatus.php 1 patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -83,11 +83,11 @@
 block discarded – undo
     protected function takeAttributeFromDOM($attribute)
     {
         switch ($attribute->localName) {
-        case 'value':
-            $this->_value = $attribute->nodeValue;
-            break;
-        default:
-            parent::takeAttributeFromDOM($attribute);
+            case 'value':
+                $this->_value = $attribute->nodeValue;
+                break;
+            default:
+                parent::takeAttributeFromDOM($attribute);
         }
     }
 

Please login to merge, or discard this patch.

		@@ -85,11 +85,9 @@
		block discarded – undo
85	85	case 'value':
86	86	if ($attribute->nodeValue == "true") {
87	87	$this->_value = true;
88		- }
89		- else if ($attribute->nodeValue == "false") {
	88	+ } else if ($attribute->nodeValue == "false") {
90	89	$this->_value = false;
91		- }
92		- else {
	90	+ } else {
93	91	throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
94	92	}
95	93	break;

		@@ -85,11 +85,9 @@
		block discarded – undo
85	85	case 'value':
86	86	if ($attribute->nodeValue == "true") {
87	87	$this->_value = true;
88		- }
89		- else if ($attribute->nodeValue == "false") {
	88	+ } else if ($attribute->nodeValue == "false") {
90	89	$this->_value = false;
91		- }
92		- else {
	90	+ } else {
93	91	require_once 'Zend/Gdata/App/InvalidArgumentException.php';
94	92	throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
95	93	}

		@@ -83,11 +83,11 @@
		block discarded – undo
83	83	protected function takeAttributeFromDOM($attribute)
84	84	{
85	85	switch ($attribute->localName) {
86		- case 'value':
87		- $this->_value = $attribute->nodeValue;
88		- break;
89		- default:
90		- parent::takeAttributeFromDOM($attribute);
	86	+ case 'value':
	87	+ $this->_value = $attribute->nodeValue;
	88	+ break;
	89	+ default:
	90	+ parent::takeAttributeFromDOM($attribute);
91	91	}
92	92	}
93	93

		@@ -82,19 +82,19 @@
		block discarded – undo
82	82	protected function takeAttributeFromDOM($attribute)
83	83	{
84	84	switch ($attribute->localName) {
85		- case 'value':
86		- if ($attribute->nodeValue == "true") {
87		- $this->_value = true;
88		- }
89		- else if ($attribute->nodeValue == "false") {
90		- $this->_value = false;
91		- }
92		- else {
93		- throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
94		- }
95		- break;
96		- default:
97		- parent::takeAttributeFromDOM($attribute);
	85	+ case 'value':
	86	+ if ($attribute->nodeValue == "true") {
	87	+ $this->_value = true;
	88	+ }
	89	+ else if ($attribute->nodeValue == "false") {
	90	+ $this->_value = false;
	91	+ }
	92	+ else {
	93	+ throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
	94	+ }
	95	+ break;
	96	+ default:
	97	+ parent::takeAttributeFromDOM($attribute);
98	98	}
99	99	}
100	100

		@@ -82,20 +82,20 @@
		block discarded – undo
82	82	protected function takeAttributeFromDOM($attribute)
83	83	{
84	84	switch ($attribute->localName) {
85		- case 'value':
86		- if ($attribute->nodeValue == "true") {
87		- $this->_value = true;
88		- }
89		- else if ($attribute->nodeValue == "false") {
90		- $this->_value = false;
91		- }
92		- else {
93		- require_once 'Zend/Gdata/App/InvalidArgumentException.php';
94		- throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
95		- }
96		- break;
97		- default:
98		- parent::takeAttributeFromDOM($attribute);
	85	+ case 'value':
	86	+ if ($attribute->nodeValue == "true") {
	87	+ $this->_value = true;
	88	+ }
	89	+ else if ($attribute->nodeValue == "false") {
	90	+ $this->_value = false;
	91	+ }
	92	+ else {
	93	+ require_once 'Zend/Gdata/App/InvalidArgumentException.php';
	94	+ throw new Zend_Gdata_App_InvalidArgumentException("Expected 'true' or 'false' for gCal:selected#value.");
	95	+ }
	96	+ break;
	97	+ default:
	98	+ parent::takeAttributeFromDOM($attribute);
99	99	}
100	100	}
101	101

TheRakeshPurohit / rtCamp

Push — master ( 276db7...0bd148 )

Status

Category

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Switch Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Switch Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Switch Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch