zipper::ProcessZip()

Complexity

Conditions	10
Paths	36

Size

Total Lines	66
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
	public function ProcessZip($foldercontent, $folder, $maxsize) {

		$split = array();

		$splits = 1;
		$t = 0;

		// Determine how many zip files to create
		if ( isset( $foldercontent ) ) {
			foreach ($foldercontent as $entry) {
	
				$t = $t + $entry['size'];
	
				if ($entry['type'] == 'dir') {
					$lastdir = $entry;
				}
	
				if ($t >= $maxsize) {
					$splits++;
					$t = 0;
					// create lastdir in next archive, in case files still exist
					// even if the next file is not in this archive it doesn't hurt
					if ($lastdir !== '') {

The variable $lastdir does not seem to be defined for all execution paths leading up to this point.

						$split[$splits][] = $lastdir;
					}
				}
	
				$split[$splits][] = $entry;
			}
	
			// delete the $foldercontent array
			unset($foldercontent);
	
			// Create the folder to put the zip files in
			$date = new DateTime();
			$tS = $date->format('YmdHis');

The assignment to $tS is dead and can be removed.

	
			// Process the splits
			foreach ($split as $idx => $sp) {
				
				// create the zip file
	
				$zip = new ZipArchive();
	
				$destination = $folder . '.zip';
	
				if (!$zip->open($destination, ZIPARCHIVE::CREATE)) {
					return false;
				}
	
				$i = 1;
				$dir = "";
				foreach ($sp as $entry) {
					if ($entry['type'] === 'dir') {
						$dir = explode('\\', $entry['file']);
						$zip->addEmptyDir(end($dir));
					} else {
						$zip->addFromString(end($dir).'/'.$i.'.jpg', file_get_contents($entry['file']));

$dir of type string is incompatible with the type array expected by parameter $array of end().

						$i++;
					}
				}
				$zip->close();
			}
			return array(
				'splits' => count($split),
				'foldername' => ''
			);
}