zipper::LoadZipFiles()

Complexity

Conditions	8
Paths	3

Size

Total Lines	44
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
	public function LoadZipFiles($source) {

		if (!file_exists($source)) {
			return false;
		}

		$source = str_replace('\\', '/', realpath($source));

		$a = array();

		if (is_dir($source) === true) {
			$files = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($source), RecursiveIteratorIterator::SELF_FIRST);

			foreach ($files as $file) {
				$file = str_replace('\\', '/', $file);

				// Ignore "." and ".." folders
				if (in_array(substr($file, strrpos($file, '/') + 1), array('.', '..')))
					continue;

				$file = realpath($file);

				if (is_dir($file) === true) {
					$a[] = array(
						'type' => 'dir',
						'source' => str_replace($source . '/', '', $file . '/'),
						'file' => $file,
						'size' => 0
					);
				} else if (is_file($file) === true) {
					$src = str_replace($source . '/', '', $file);
					$size = filesize($file);

					$a[] = array(
						'type' => 'file',
						'source' => $src,
						'file' => $file,
						'size' => false != $size ? $size : 16000 // this is fallback in case no size

It seems like you are loosely comparing $size of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

					);
				}
			}
		}

		return $a;
	}
}