PipelineTest::testGetResults() - Code Metrics - Inspection of "Adding changes to pipeline class and unit tests fo..." - TheCocoTeam/source-watcher-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3491bf...0603fe )

by Jean Paul

created 2020-05-19 00:36 UTC

PipelineTest::testGetResults() A

↳ Parent: PipelineTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	5
rs	10

<?php declare( strict_types = 1 );

namespace Coco\SourceWatcher\Tests\Core;

use Coco\SourceWatcher\Core\Extractor;
use Coco\SourceWatcher\Core\Extractors\CsvExtractor;
use Coco\SourceWatcher\Core\IO\Inputs\FileInput;
use Coco\SourceWatcher\Core\Loader;
use Coco\SourceWatcher\Core\Loaders\DatabaseLoader;
use Coco\SourceWatcher\Core\Pipeline;
use Coco\SourceWatcher\Core\Transformer;
use Coco\SourceWatcher\Core\Transformers\RenameColumnsTransformer;
use PHPUnit\Framework\TestCase;

class PipelineTest extends TestCase
{
    public function testSetGetExtractor () : void
    {
        $pipeline = new Pipeline();

        $givenExtractor = $this->createMock( Extractor::class );
        $expectedExtractor = $this->createMock( Extractor::class );

        $pipeline->setExtractor( $givenExtractor );

        $this->assertEquals( $expectedExtractor, $pipeline->getExtractor() );
    }

    public function testSetGetSteps () : void
    {
        $pipeline = new Pipeline();

        $givenSteps = [];
        $expectedSteps = [];

        $transformer = $this->createMock( Transformer::class );
        $givenSteps[] = $transformer;
        $expectedSteps[] = $transformer;

        $loader = $this->createMock( Loader::class );
        $givenSteps[] = $loader;
        $expectedSteps[] = $loader;

        $pipeline->setSteps( $givenSteps );

        $this->assertEquals( $expectedSteps, $pipeline->getSteps() );
    }

    public function testPipeStep () : void
    {
        $pipeline = new Pipeline();

        $transformer = $this->createMock( Transformer::class );

        $this->assertNull( $pipeline->pipe( $transformer ) );
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    private Pipeline $pipeline;

    protected function setUp () : void
    {
        $this->pipeline = new Pipeline();

        $csvExtractor = new CsvExtractor();
        $csvExtractor->setInput( new FileInput( __DIR__ . "/../../samples/data/csv/csv1.csv" ) );

        // set the extractor
        $this->pipeline->setExtractor( $csvExtractor );

        $transformer = new RenameColumnsTransformer();
        $transformer->options( [ "columns" => [ "email" => "email_address" ] ] );

        // pipe the transformer
        $this->pipeline->pipe( $transformer );

        // pipe the loader
        $this->pipeline->pipe( $this->createMock( DatabaseLoader::class ) );
    }

    protected function tearDown () : void
    {
        unset( $this->pipeline );
    }

    public function testExecute () : void
    {
        $this->assertNull( $this->pipeline->execute() );
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    public function testGetResults () : void
    {
        $this->pipeline->execute();

        $this->assertNotNull( $this->pipeline->getResults() );
    }

    public function testIterator () : void
    {
        $this->pipeline->execute();

        foreach ( $this->pipeline as $key => $value ) {
            $this->assertNotNull( $key );
            $this->assertNotNull( $value );
        }
    }
}


1			<?php declare( strict_types = 1 );
2
3			namespace Coco\SourceWatcher\Tests\Core;
4
5			use Coco\SourceWatcher\Core\Extractor;
6			use Coco\SourceWatcher\Core\Extractors\CsvExtractor;
7			use Coco\SourceWatcher\Core\IO\Inputs\FileInput;
8			use Coco\SourceWatcher\Core\Loader;
9			use Coco\SourceWatcher\Core\Loaders\DatabaseLoader;
10			use Coco\SourceWatcher\Core\Pipeline;
11			use Coco\SourceWatcher\Core\Transformer;
12			use Coco\SourceWatcher\Core\Transformers\RenameColumnsTransformer;
13			use PHPUnit\Framework\TestCase;
14
15			class PipelineTest extends TestCase
16			{
17			public function testSetGetExtractor () : void
18			{
19			$pipeline = new Pipeline();
20
21			$givenExtractor = $this->createMock( Extractor::class );
22			$expectedExtractor = $this->createMock( Extractor::class );
23
24			$pipeline->setExtractor( $givenExtractor );
25
26			$this->assertEquals( $expectedExtractor, $pipeline->getExtractor() );
27			}
28
29			public function testSetGetSteps () : void
30			{
31			$pipeline = new Pipeline();
32
33			$givenSteps = [];
34			$expectedSteps = [];
35
36			$transformer = $this->createMock( Transformer::class );
37			$givenSteps[] = $transformer;
38			$expectedSteps[] = $transformer;
39
40			$loader = $this->createMock( Loader::class );
41			$givenSteps[] = $loader;
42			$expectedSteps[] = $loader;
43
44			$pipeline->setSteps( $givenSteps );
45
46			$this->assertEquals( $expectedSteps, $pipeline->getSteps() );
47			}
48
49			public function testPipeStep () : void
50			{
51			$pipeline = new Pipeline();
52
53			$transformer = $this->createMock( Transformer::class );
54
55			$this->assertNull( $pipeline->pipe( $transformer ) );
			0 ignored issues – show Bug introduced 2020-05-19 00:37 UTC by Report Bug Copy Issue Report Are you sure the usage of `$pipeline->pipe($transformer)` targeting `Coco\SourceWatcher\Core\Pipeline::pipe()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
56			}
57
58			private Pipeline $pipeline;
59
60			protected function setUp () : void
61			{
62			$this->pipeline = new Pipeline();
63
64			$csvExtractor = new CsvExtractor();
65			$csvExtractor->setInput( new FileInput( __DIR__ . "/../../samples/data/csv/csv1.csv" ) );
66
67			// set the extractor
68			$this->pipeline->setExtractor( $csvExtractor );
69
70			$transformer = new RenameColumnsTransformer();
71			$transformer->options( [ "columns" => [ "email" => "email_address" ] ] );
72
73			// pipe the transformer
74			$this->pipeline->pipe( $transformer );
75
76			// pipe the loader
77			$this->pipeline->pipe( $this->createMock( DatabaseLoader::class ) );
78			}
79
80			protected function tearDown () : void
81			{
82			unset( $this->pipeline );
83			}
84
85			public function testExecute () : void
86			{
87			$this->assertNull( $this->pipeline->execute() );
			0 ignored issues – show Bug introduced 2020-05-19 00:37 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->pipeline->execute()` targeting `Coco\SourceWatcher\Core\Pipeline::execute()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
88			}
89
90			public function testGetResults () : void
91			{
92			$this->pipeline->execute();
93
94			$this->assertNotNull( $this->pipeline->getResults() );
95			}
96
97			public function testIterator () : void
98			{
99			$this->pipeline->execute();
100
101			foreach ( $this->pipeline as $key => $value ) {
102			$this->assertNotNull( $key );
103			$this->assertNotNull( $value );
104			}
105			}
106			}
107

TheCocoTeam / source-watcher-core

Push — master ( 3491bf...0603fe )

PipelineTest::testGetResults() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like