Coco\SourceWatcher\Core\StepLoader

Complexity

Total Complexity

7

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getInstance()	0	7	2
A	step()	0	42	5

<?php

namespace Coco\SourceWatcher\Core;

use Coco\SourceWatcher\Utils\TextUtils;
use ReflectionClass;
use ReflectionException;

/**
 * Class StepLoader
 * @package Coco\SourceWatcher\Core
 */
class StepLoader
{
    /**
     * @var StepLoader
     */
    private static StepLoader $instance;

    /**
     * @return StepLoader
     */
    public static function getInstance () : StepLoader
    {
        if ( is_null( static::$instance ) ) {

Since $instance is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $instance to at least protected.

            static::$instance = new static;
        }

        return static::$instance;
    }

    /**
     * @param string $parentClassName
     * @param string $stepName
     * @return Step
     * @throws SourceWatcherException
     */
    public function step ( string $parentClassName, string $stepName ) : Step
    {
        $parentClassShortName = "";

The assignment to $parentClassShortName is dead and can be removed.

        try {
            $reflection = new ReflectionClass( $parentClassName );

            $parentClassShortName = $reflection->getShortName();
        } catch ( ReflectionException $reflectionException ) {
            $errorMessage = sprintf( "Something went wrong while trying to get the short class name: %s", $reflectionException->getMessage() );
            throw new SourceWatcherException( $errorMessage );
        } catch ( Exception $exception ) {

The type Coco\SourceWatcher\Core\Exception was not found. Did you mean Exception? If so, make sure to prefix the type with \.

            $errorMessage = sprintf( "Something unexpected went wrong while trying to get the short class name: %s", $exception->getMessage() );
            throw new SourceWatcherException( $errorMessage );
        }

        $baseNameSpace = "Coco\\SourceWatcher\\Core";

        $packages = [ "Extractor" => sprintf( "%s\\%s", $baseNameSpace, "Extractors" ), "Transformer" => sprintf( "%s\\%s", $baseNameSpace, "Transformers" ), "Loader" => sprintf( "%s\\%s", $baseNameSpace, "Loaders" ) ];

        $subPackage = $packages[$parentClassShortName];

        $textUtils = new TextUtils();

        $step = null;

        try {
            $temporaryClassName = sprintf( "%s_%s", $stepName, $parentClassShortName );

            $pascalCaseClassName = $textUtils->textToPascalCase( $temporaryClassName );

            $fullyQualifiedClassName = sprintf( "%s\\%s", $subPackage, $pascalCaseClassName );

            if ( class_exists( $fullyQualifiedClassName ) ) {
                $step = new $fullyQualifiedClassName();
            }
        } catch ( Exception $exception ) {
            $errorMessage = sprintf( "Something unexpected went wrong while trying to load the step: %s", $exception->getMessage() );
            throw new SourceWatcherException( $errorMessage );
        }

        return $step;

The expression return $step could return the type null which is incompatible with the type-hinted return Coco\SourceWatcher\Core\Step. Consider adding an additional type-check to rule them out.

    }
}