JsonExtractor::transpose() - Code Metrics - Inspection of "Adding json extractor classes and sample, xml extr..." - TheCocoTeam/source-watcher-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 087fad...ae4363 )

by Jean Paul

created 2020-03-30 06:50 UTC

JsonExtractor::transpose() A

↳ Parent: JsonExtractor

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	5
c	0
b	0
f	0
dl	0
loc	11
rs	10
cc	3
nc	3
nop	1

<?php

namespace Coco\SourceWatcher\Core\Extractors;

use Coco\SourceWatcher\Core\Extractor;
use Coco\SourceWatcher\Core\Row;

use Flow\JSONPath\JSONPath;
use Flow\JSONPath\JSONPathException;

/**
 * Class JsonExtractor
 * @package Coco\SourceWatcher\Core\Extractors
 */
class JsonExtractor extends Extractor
{
    /**
     * @var array
     */
    private array $columns = [];

    /**
     * @var array
     */
    protected array $availableOptions = [ "columns" ];

    /**
     * @return array
     */
    public function getColumns () : array
    {
        return $this->columns;
    }

    /**
     * @param array $columns
     */
    public function setColumns ( array $columns ) : void
    {
        $this->columns = $columns;
    }

    /**
     * @return array|mixed
     * @throws JSONPathException
     */
    public function extract ()
    {
        if ( $this->input == null ) {
            throw new Exception( "An input must be provided." );

        }

        $result = array();

        // @todo: check if file exists
        $data = json_decode( file_get_contents( $this->input ), true );

        if ( $this->columns ) {

            // @todo: control possible JSONPathException exception
            $jsonPath = new JSONPath( $data );

            foreach ( $this->columns as $key => $path ) {
                $this->columns[$key] = $jsonPath->find( $path )->data();
            }

            $data = $this->transpose( $this->columns );
        }

        foreach ( $data as $row ) {
            array_push( $result, new Row( $row ) );
        }

        return $result;
    }

    /**
     * @param $columns
     * @return array
     */
    private function transpose ( $columns )
    {
        $data = [];

        foreach ( $columns as $column => $items ) {
            foreach ( $items as $row => $item ) {
                $data[$row][$column] = $item;
            }
        }

        return $data;
    }
}


1			<?php
2
3			namespace Coco\SourceWatcher\Core\Extractors;
4
5			use Coco\SourceWatcher\Core\Extractor;
6			use Coco\SourceWatcher\Core\Row;
7
8			use Flow\JSONPath\JSONPath;
9			use Flow\JSONPath\JSONPathException;
10
11			/**
12			* Class JsonExtractor
13			* @package Coco\SourceWatcher\Core\Extractors
14			*/
15			class JsonExtractor extends Extractor
16			{
17			/**
18			* @var array
19			*/
20			private array $columns = [];
21
22			/**
23			* @var array
24			*/
25			protected array $availableOptions = [ "columns" ];
26
27			/**
28			* @return array
29			*/
30			public function getColumns () : array
31			{
32			return $this->columns;
33			}
34
35			/**
36			* @param array $columns
37			*/
38			public function setColumns ( array $columns ) : void
39			{
40			$this->columns = $columns;
41			}
42
43			/**
44			* @return array\|mixed
45			* @throws JSONPathException
46			*/
47			public function extract ()
48			{
49			if ( $this->input == null ) {
50			throw new Exception( "An input must be provided." );
			0 ignored issues – show Bug introduced 2020-03-30 06:52 UTC by Report Bug Copy Issue Report The type `Coco\SourceWatcher\Core\Extractors\Exception` was not found. Did you mean `Exception`? If so, make sure to prefix the type with `\`. Loading history...
51			}
52
53			$result = array();
54
55			// @todo: check if file exists
56			$data = json_decode( file_get_contents( $this->input ), true );
57
58			if ( $this->columns ) {
			0 ignored issues – show Bug Best Practice introduced 2020-03-30 06:52 UTC by Report Bug Copy Issue Report The expression `$this->columns` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
59			// @todo: control possible JSONPathException exception
60			$jsonPath = new JSONPath( $data );
61
62			foreach ( $this->columns as $key => $path ) {
63			$this->columns[$key] = $jsonPath->find( $path )->data();
64			}
65
66			$data = $this->transpose( $this->columns );
67			}
68
69			foreach ( $data as $row ) {
70			array_push( $result, new Row( $row ) );
71			}
72
73			return $result;
74			}
75
76			/**
77			* @param $columns
78			* @return array
79			*/
80			private function transpose ( $columns )
81			{
82			$data = [];
83
84			foreach ( $columns as $column => $items ) {
85			foreach ( $items as $row => $item ) {
86			$data[$row][$column] = $item;
87			}
88			}
89
90			return $data;
91			}
92			}
93

TheCocoTeam / source-watcher-core

Push — master ( 087fad...ae4363 )

JsonExtractor::transpose() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like