Issues in TaxModifier.php (master) - Issues in master - TheBnl/event-tickets - Measure and Improve Code Quality continuously with Scrutinizer

Issues (150)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/model/TaxModifier.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * PriceModifier.php
 *
 * @author Bram de Leeuw
 * Date: 31/03/17
 */

namespace Broarm\EventTickets;

/**
 * Class TaxModifier
 *
 * Adds a configurable tax rate on the receipt
 *
 * @package Broarm\EventTickets
 */
class TaxModifier extends PriceModifier
{
    /**
     * Set the tax rate as a percentage
     *
     * @var string
     */
    private static $tax_rate = 21;

    /**
     * Set if the tax rate is inclusive or exclusive
     *
     * @var string
     */
    private static $inclusive = false;

    /**
     * Set the default sort value to a large int so it always shows and calculates as last
     *
     * @var array
     */
    private static $defaults = array(

        'Title' => 'Tax modifier',
        'Sort' => 9999
    );

    /**
     * Update the total, if the tax is not inclusive the total gets altered
     *
     * @param float $total
     * @param Reservation $reservation
     */
    public function updateTotal(&$total, Reservation $reservation) {
        $rate = (float)self::config()->get('tax_rate') / 100;
        $tax = $total * $rate;
        $this->setPriceModification($tax);
        if (!(bool)self::config()->get('inclusive')) {
            $total += $tax;
        }
    }

    /**
     * Show the used tax rate in the table title
     *
     * @return string
     */
    public function getTableTitle()
    {
        $rate = _t(
            'TaxModifier.TABLE_TITLE',
            '{rate}% BTW',
            null,
            array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'rate' => (float)self::config()->get('tax_rate')
            )
        );

        if ((bool)self::config()->get('inclusive')) {
            $inc = _t('TaxModifier.INCLUSIVE', '(Incl.)');
            $rate .= " $inc";
        }

        return $rate;
    }

    /**
     * Show the calculated tax value as a positive value
     *
     * @return float
     */
    public function getTableValue()
    {
        return $this->PriceModification;
    }

    /**
     * Create a tax modifier if it does not already exists
     *
     * @param Reservation $reservation
     *
     * @return TaxModifier|\DataObject|null|static
     */
    public static function findOrMake(Reservation $reservation)
    {
        if (!$modifier = $reservation->PriceModifiers()->find('ClassName', self::class)) {
            $modifier = self::create();
            $modifier->write();
        }

        return $modifier;
    }
}


1			<?php
2			/**
3			* PriceModifier.php
4			*
5			* @author Bram de Leeuw
6			* Date: 31/03/17
7			*/
8
9			namespace Broarm\EventTickets;
10
11			/**
12			* Class TaxModifier
13			*
14			* Adds a configurable tax rate on the receipt
15			*
16			* @package Broarm\EventTickets
17			*/
18			class TaxModifier extends PriceModifier
19			{
20			/**
21			* Set the tax rate as a percentage
22			*
23			* @var string
24			*/
25			private static $tax_rate = 21;
26
27			/**
28			* Set if the tax rate is inclusive or exclusive
29			*
30			* @var string
31			*/
32			private static $inclusive = false;
33
34			/**
35			* Set the default sort value to a large int so it always shows and calculates as last
36			*
37			* @var array
38			*/
39			private static $defaults = array(
			0 ignored issues – show Comprehensibility introduced 2017-05-01 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history...
40			'Title' => 'Tax modifier',
41			'Sort' => 9999
42			);
43
44			/**
45			* Update the total, if the tax is not inclusive the total gets altered
46			*
47			* @param float $total
48			* @param Reservation $reservation
49			*/
50			public function updateTotal(&$total, Reservation $reservation) {
51			$rate = (float)self::config()->get('tax_rate') / 100;
52			$tax = $total * $rate;
53			$this->setPriceModification($tax);
54			if (!(bool)self::config()->get('inclusive')) {
55			$total += $tax;
56			}
57			}
58
59			/**
60			* Show the used tax rate in the table title
61			*
62			* @return string
63			*/
64			public function getTableTitle()
65			{
66			$rate = _t(
67			'TaxModifier.TABLE_TITLE',
68			'{rate}% BTW',
69			null,
70			array(
			0 ignored issues – show Documentation introduced 2017-05-01 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('rate' => (double)...fig()->get('tax_rate'))` is of type `array<string,double,{"rate":"double"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
71			'rate' => (float)self::config()->get('tax_rate')
72			)
73			);
74
75			if ((bool)self::config()->get('inclusive')) {
76			$inc = _t('TaxModifier.INCLUSIVE', '(Incl.)');
77			$rate .= " $inc";
78			}
79
80			return $rate;
81			}
82
83			/**
84			* Show the calculated tax value as a positive value
85			*
86			* @return float
87			*/
88			public function getTableValue()
89			{
90			return $this->PriceModification;
91			}
92
93			/**
94			* Create a tax modifier if it does not already exists
95			*
96			* @param Reservation $reservation
97			*
98			* @return TaxModifier\|\DataObject\|null\|static
99			*/
100			public static function findOrMake(Reservation $reservation)
101			{
102			if (!$modifier = $reservation->PriceModifiers()->find('ClassName', self::class)) {
103			$modifier = self::create();
104			$modifier->write();
105			}
106
107			return $modifier;
108			}
109			}
110

TheBnl / event-tickets

Issues (150)

Security Analysis not enabled

code/model/TaxModifier.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like