UserEmailField::createField() - Code Metrics - Inspection of "add check if email adress is valid on main attende..." - TheBnl/event-tickets - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d88694...1943e9 )

by Bram

created 2020-02-17 16:35 UTC

UserEmailField::createField() A

↳ Parent: UserEmailField

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.6333
c	0
b	0
f	0
cc	2
nc	2
nop	3

<?php

/**
 * Class UserEmailField
 *
 * @author Bram de Leeuw
 * @package UserTextField
 */
class UserEmailField extends Broarm\EventTickets\UserField
{
    /**
     * @var FormField
     */
    protected $fieldType = 'EmailField';

    /**
     * Create a default text field
     *
     * @param string  $fieldName
     * @param null    $defaultValue
     * @param boolean $main check if the field is for the main attendee
     *
     * @return NumericField|FormField
     */
    public function createField($fieldName, $defaultValue = null, $main = false)
    {
        $field = parent::createField($fieldName, $defaultValue, $main);

        // If we have the main booker account, we create a
        if ($main) {
            $field = CompositeField::create([
                EmailField::create("{$fieldName}[_Email]", $this->Title, $defaultValue),
                EmailField::create(
                    "{$fieldName}[_ConfirmedEmail]",
                    _t(__CLASS__ . '.ConfirmedEmail', 'Confirm {title}', null, ['title' => $this->Title]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    $defaultValue
                ),
            ]);
            $field->addExtraClass($this->ExtraClass);
        }

        return $field;
    }
}


1			<?php
2
3			/**
4			* Class UserEmailField
5			*
6			* @author Bram de Leeuw
7			* @package UserTextField
8			*/
9			class UserEmailField extends Broarm\EventTickets\UserField
10			{
11			/**
12			* @var FormField
13			*/
14			protected $fieldType = 'EmailField';
15
16			/**
17			* Create a default text field
18			*
19			* @param string $fieldName
20			* @param null $defaultValue
21			* @param boolean $main check if the field is for the main attendee
22			*
23			* @return NumericField\|FormField
24			*/
25			public function createField($fieldName, $defaultValue = null, $main = false)
26			{
27			$field = parent::createField($fieldName, $defaultValue, $main);
28
29			// If we have the main booker account, we create a
30			if ($main) {
31			$field = CompositeField::create([
32			EmailField::create("{$fieldName}[_Email]", $this->Title, $defaultValue),
33			EmailField::create(
34			"{$fieldName}[_ConfirmedEmail]",
35			_t(__CLASS__ . '.ConfirmedEmail', 'Confirm {title}', null, ['title' => $this->Title]),
			0 ignored issues – show Documentation introduced 2020-02-17 16:37 UTC by Report Bug Copy Issue Report `array('title' => $this->Title)` is of type `array<string,string,{"title":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36			$defaultValue
37			),
38			]);
39			$field->addExtraClass($this->ExtraClass);
40			}
41
42			return $field;
43			}
44			}
45

TheBnl / event-tickets

Push — master ( d88694...1943e9 )

UserEmailField::createField() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like