Broarm\EventTickets\TaxModifier

Complexity

Total Complexity

6

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	updateTotal()	0	8	2
A	getTableTitle()	0	11	1
A	getTableValue()	0	4	1
A	findOrMake()	0	9	2

<?php
/**
 * PriceModifier.php
 *
 * @author Bram de Leeuw
 * Date: 31/03/17
 */

namespace Broarm\EventTickets;

/**
 * Class TaxModifier
 *
 * Adds a configurable tax rate on the receipt
 *
 * @package Broarm\EventTickets
 */
class TaxModifier extends PriceModifier
{
    /**
     * Set the tax rate as a percentage
     *
     * @var string
     */
    private static $tax_rate = '21';

The property $tax_rate is not used and could be removed.

    /**
     * Set if the tax rate is inclusive or exclusive
     *
     * @var string
     */
    private static $inclusive = false;

The property $inclusive is not used and could be removed.

    /**
     * Set the default sort value to a large int so it always shows and calculates as last
     *
     * @var array
     */
    private static $defaults = array(

Consider using a different property name as you override a private property of the parent class.

The property $defaults is not used and could be removed.

        'Title' => 'Tax modifier',
        'Sort' => 9999
    );

    public function updateTotal(&$total) {
        $rate = (float)self::config()->get('tax_rate') / 100;
        $tax = $total * $rate;
        $this->setPriceModification($tax);
        if (!(bool)self::config()->get('inclusive')) {
            $total += $tax;
        }
    }

    /**
     * Show the used tax rate in the table title
     *
     * @return string
     */
    public function getTableTitle()
    {
        return _t(
            'TaxModifier.TABLE_TITLE',
            '{rate}% BTW',
            null,
            array(

array('rate' => (double) self::config()->get('tax_rate')) is of type array<string,double,{"rate":"double"}>, but the function expects a string.

                'rate' => (float)self::config()->get('tax_rate')
            )
        );
    }

    /**
     * Show the calculated tax value as a positive value
     *
     * @return float
     */
    public function getTableValue()
    {
        return $this->PriceModification;
    }

    /**
     * Create a tax modifier if it does not already exists
     *
     * @param Reservation $reservation
     *
     * @return TaxModifier|\DataObject|null|static
     */
    public static function findOrMake(Reservation $reservation)
    {
        if (!$modifier = $reservation->PriceModifiers()->find('ClassName', self::class)) {

The method PriceModifiers does not exist on object<Broarm\EventTickets\Reservation>? Since you implemented __call, maybe consider adding a @method annotation.

            $modifier = self::create();
            $modifier->write();
        }

        return $modifier;
    }
}