AttendeeField::__construct() - Code Metrics - TheBnl/event-tickets - Measure and Improve Code Quality continuously with Scrutinizer

AttendeeField::__construct() B
last analyzed 2020-11-17 17:31 UTC

↳ Parent: AttendeeField

Complexity

Conditions	10
Paths	13

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	51
rs	7.2024
c	0
b	0
f	0
cc	10
nc	13
nop	3

How to fix Long Method Complexity

<?php
/**
 * AttendeesField.php
 *
 * @author Bram de Leeuw
 * Date: 10/03/17
 */

namespace Broarm\EventTickets;

use ArrayList;
use CompositeField;
use DBField;
use FieldGroup;
use FieldList;
use FormField;
use HiddenField;
use LiteralField;
use Member;

/**
 * Class AttendeeField
 *
 * @package Broarm\EventTickets
 */
class AttendeeField extends CompositeField
{
    protected $name = 'Attendee';

    protected $requiredFields = array();

    public function __construct(Attendee $attendee, $main = false, $required = true)
    {
        parent::__construct();
        $this->setTag('fieldset');
        $this->setLegend(_t('AttendeeField.VALUED', '{title} valued {price}', null, array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'title' => $attendee->Ticket()->Title,
            'price' => $attendee->Ticket()->dbObject('Price')->NiceDecimalPoint())
        ));

        $children = FieldList::create();
        $savableFields = $attendee->Event()->Fields();

        /** @var UserField $field */
        foreach ($savableFields as $field) {
            // Generate a unique field name
            $fieldName = "{$this->name}[{$attendee->ID}][$field->ID]";

            // Create the field an fill with attendee data
            $hasField = $attendee->Fields()->find('ID', $field->ID);
            $value = $hasField ? $hasField->getField('Value') : null;
            $formField = $field->createField($fieldName, $value, $main);

            // Check if the field is required
            if ($field->Required && $required) {
                if ($formField instanceof CompositeField) {
                    foreach ($formField->getChildren()->column('Name') as $requiredField) {
                        $this->addRequiredField($requiredField);
                    }
                } else {
                    $this->addRequiredField($fieldName);
                }
            }

            // Pre fill the field if a member is logged in
            if ($main && empty($formField->value) && $member = Member::currentUser()) {
                $formField->setValue($member->getField($field->Name));
            }

            // Add the form
            $children->add($formField);
        }

        // Set the main field
        $children->add(HiddenField::create("{$this->name}[{$attendee->ID}][Main]", 'Main', (int)$main));

        // set the children
        $this->setChildren($children);

        // Add a hook to modify the added fields if needed
        $this->extend('updateAttendeeField', $attendee, $main, $required);
    }

    /**
     * Update the required fields array
     *
     * @param $fieldName
     */
    private function addRequiredField($fieldName) {
        array_push($this->requiredFields, $fieldName);
    }

    /**
     * Get the required fields
     *
     * @return array
     */
    public function getRequiredFields()
    {
        return $this->requiredFields;
    }
}


1			<?php
2			/**
3			* AttendeesField.php
4			*
5			* @author Bram de Leeuw
6			* Date: 10/03/17
7			*/
8
9			namespace Broarm\EventTickets;
10
11			use ArrayList;
12			use CompositeField;
13			use DBField;
14			use FieldGroup;
15			use FieldList;
16			use FormField;
17			use HiddenField;
18			use LiteralField;
19			use Member;
20
21			/**
22			* Class AttendeeField
23			*
24			* @package Broarm\EventTickets
25			*/
26			class AttendeeField extends CompositeField
27			{
28			protected $name = 'Attendee';
29
30			protected $requiredFields = array();
31
32			public function __construct(Attendee $attendee, $main = false, $required = true)
33			{
34			parent::__construct();
35			$this->setTag('fieldset');
36			$this->setLegend(_t('AttendeeField.VALUED', '{title} valued {price}', null, array(
			0 ignored issues – show Documentation introduced 2017-05-24 16:47 UTC by Report Bug Copy Issue Report `array('title' => $attend...')->NiceDecimalPoint())` is of type `array<string,?,{"title":"string","price":"?"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37			'title' => $attendee->Ticket()->Title,
38			'price' => $attendee->Ticket()->dbObject('Price')->NiceDecimalPoint())
39			));
40
41			$children = FieldList::create();
42			$savableFields = $attendee->Event()->Fields();
43
44			/** @var UserField $field */
45			foreach ($savableFields as $field) {
46			// Generate a unique field name
47			$fieldName = "{$this->name}[{$attendee->ID}][$field->ID]";
48
49			// Create the field an fill with attendee data
50			$hasField = $attendee->Fields()->find('ID', $field->ID);
51			$value = $hasField ? $hasField->getField('Value') : null;
52			$formField = $field->createField($fieldName, $value, $main);
53
54			// Check if the field is required
55			if ($field->Required && $required) {
56			if ($formField instanceof CompositeField) {
57			foreach ($formField->getChildren()->column('Name') as $requiredField) {
58			$this->addRequiredField($requiredField);
59			}
60			} else {
61			$this->addRequiredField($fieldName);
62			}
63			}
64
65			// Pre fill the field if a member is logged in
66			if ($main && empty($formField->value) && $member = Member::currentUser()) {
67			$formField->setValue($member->getField($field->Name));
68			}
69
70			// Add the form
71			$children->add($formField);
72			}
73
74			// Set the main field
75			$children->add(HiddenField::create("{$this->name}[{$attendee->ID}][Main]", 'Main', (int)$main));
76
77			// set the children
78			$this->setChildren($children);
79
80			// Add a hook to modify the added fields if needed
81			$this->extend('updateAttendeeField', $attendee, $main, $required);
82			}
83
84			/**
85			* Update the required fields array
86			*
87			* @param $fieldName
88			*/
89			private function addRequiredField($fieldName) {
90			array_push($this->requiredFields, $fieldName);
91			}
92
93			/**
94			* Get the required fields
95			*
96			* @return array
97			*/
98			public function getRequiredFields()
99			{
100			return $this->requiredFields;
101			}
102			}
103

TheBnl / event-tickets

AttendeeField::__construct() B last analyzed 2020-11-17 17:31 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

AttendeeField::__construct() B
last analyzed 2020-11-17 17:31 UTC