EventController::resultAction() - Code Metrics - Inspection of "implementing finish action" - TheAlternativeZurich/feedback - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 55824b...ad17d9 )

by Florian

created 2018-09-21 11:22 UTC

EventController::resultAction() A

↳ Parent: EventController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
c	0
b	0
f	0
rs	10
cc	1
nc	1
nop	2

<?php

/*
 * This file is part of the feedback project.
 *
 * (c) Florian Moser <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace App\Controller\Administration\Semester;

use App\Controller\Administration\Base\BaseController;
use App\Entity\Event;
use App\Entity\Semester;
use App\Model\Breadcrumb;
use App\Security\Voter\Base\BaseVoter;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;

/**
 * @Route("/event")
 */
class EventController extends BaseController
{
    /**
     * @Route("/new", name="administration_semester_event_new")
     *
     * @param Request $request
     * @param Semester $semester
     *
     * @return Response
     */
    public function newAction(Request $request, Semester $semester)
    {
        //create the event
        $event = new Event();
        $event->setSemester($semester);
        $event->setName('');

        //fill out default values as smart as possible
        /** @var Event|null $lastEvent */
        $lastEvent = $semester->getEvents()->first();
        if ($lastEvent) {
            $event->setFeedbackStartTime($lastEvent->getFeedbackStartTime());
            $event->setFeedbackEndTime($lastEvent->getFeedbackEndTime());
            $event->setTemplateName($lastEvent->getTemplateName());
        } else {
            $event->setFeedbackStartTime('19:00:00');
            $event->setFeedbackEndTime('21:00:00');
            $event->setTemplateName('default.json');
        }
        $event->setDate((new \DateTime())->modify('+20 day')->format('Y-m-d'));

        //check if can indeed create the event
        $this->ensureAccessGranted($event);

        //process form
        $myForm = $this->handleCreateForm(
            $request,
            $event,
            function () use ($event) {
                return $this->prePersistActions($event);
            }
        );
        if ($myForm instanceof Response) {
            return $myForm;
        }

        return $this->renderWithSemester('administration/semester/event/new.html.twig', $semester, ['form' => $myForm->createView()]);
    }

    /**
     * @Route("/{event}/edit", name="administration_semester_event_edit")
     *
     * @param Request $request
     * @param Semester $semester
     * @param Event $event
     *
     * @return Response
     */
    public function editAction(Request $request, Semester $semester, Event $event)
    {
        $this->ensureAccessGranted($event);

        //process form
        $myForm = $this->handleUpdateForm(
            $request,
            $event,
            function () use ($event) {
                return $this->prePersistActions($event);
            }
        );
        if ($myForm instanceof Response) {
            return $myForm;
        }

        return $this->renderWithSemester('administration/semester/event/edit.html.twig', $semester, ['form' => $myForm->createView(), 'event' => $event]);
    }

    /**
     * @Route("/{event}/view/", name="administration_semester_event_view")
     *
     * @param Semester $semester
     * @param Event $event
     *
     * @return Response
     */
    public function viewAction(Semester $semester, Event $event)
    {
        return $this->renderWithSemester('administration/semester/event/view.html.twig', $semester, ['event' => $event]);
    }

    /**
     * @Route("/{event}/result", name="administration_semester_event_result")
     *
     * @param Semester $semester
     * @param Event $event
     *
     * @return Response
     */
    public function resultAction(Semester $semester, Event $event)
    {
        return $this->renderWithSemester('administration/semester/event/result.html.twig', $semester, ['event' => $event]);
    }

    /**     *
     * @Route("/{event}/remove", name="administration_semester_event_remove")
     *
     * @param Request $request
     * @param Semester $semester
     * @param Event $event
     *
     * @return Response
     */
    public function removeAction(Request $request, Semester $semester, Event $event)
    {
        $this->ensureAccessGranted($event);

        //process form
        $form = $this->handleDeleteForm($request, $event);
        if ($form === null) {
            return $this->redirectToRoute('administration_semesters');
        }

        return $this->renderWithSemester('administration/semester/event/remove.html.twig', $semester, ['event' => $event, 'form' => $form->createView()]);
    }

    /**
     * get the breadcrumbs leading to this controller.
     *
     * @return Breadcrumb[]
     */
    protected function getIndexBreadcrumbs()
    {
        return array_merge(parent::getIndexBreadcrumbs(), [
            new Breadcrumb(
                $this->generateUrl('administration_semesters'),
                $this->getTranslator()->trans('index.title', [], 'administration_semester')
            ),
        ]);
    }

    /**
     * @param Event $event
     */
    private function ensureAccessGranted(Event $event)
    {
        $this->denyAccessUnlessGranted(BaseVoter::VIEW, $event);
    }

    /**
     * @param Event $event
     *
     * @return bool
     */
    protected function prePersistActions(Event $event)
    {
        $event->loadTemplateIfSafe($this->getParameter('PUBLIC_DIR'));

        return true;
    }

    /**
     * renders the view & prepares views which need the active election.
     *
     * @param string $view
     * @param Semester $semester
     * @param array $parameters
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    protected function renderWithSemester(string $view, Semester $semester, array $parameters = [])
    {
        return $this->render($view, $parameters + ['semester' => $semester]);
    }
}


1			<?php
2
3			/*
4			* This file is part of the feedback project.
5			*
6			* (c) Florian Moser <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace App\Controller\Administration\Semester;
13
14			use App\Controller\Administration\Base\BaseController;
15			use App\Entity\Event;
16			use App\Entity\Semester;
17			use App\Model\Breadcrumb;
18			use App\Security\Voter\Base\BaseVoter;
19			use Symfony\Component\HttpFoundation\Request;
20			use Symfony\Component\HttpFoundation\Response;
21			use Symfony\Component\Routing\Annotation\Route;
22
23			/**
24			* @Route("/event")
25			*/
26			class EventController extends BaseController
27			{
28			/**
29			* @Route("/new", name="administration_semester_event_new")
30			*
31			* @param Request $request
32			* @param Semester $semester
33			*
34			* @return Response
35			*/
36			public function newAction(Request $request, Semester $semester)
37			{
38			//create the event
39			$event = new Event();
40			$event->setSemester($semester);
41			$event->setName('');
42
43			//fill out default values as smart as possible
44			/** @var Event\|null $lastEvent */
45			$lastEvent = $semester->getEvents()->first();
46			if ($lastEvent) {
47			$event->setFeedbackStartTime($lastEvent->getFeedbackStartTime());
48			$event->setFeedbackEndTime($lastEvent->getFeedbackEndTime());
49			$event->setTemplateName($lastEvent->getTemplateName());
50			} else {
51			$event->setFeedbackStartTime('19:00:00');
52			$event->setFeedbackEndTime('21:00:00');
53			$event->setTemplateName('default.json');
54			}
55			$event->setDate((new \DateTime())->modify('+20 day')->format('Y-m-d'));
56
57			//check if can indeed create the event
58			$this->ensureAccessGranted($event);
59
60			//process form
61			$myForm = $this->handleCreateForm(
62			$request,
63			$event,
64			function () use ($event) {
65			return $this->prePersistActions($event);
66			}
67			);
68			if ($myForm instanceof Response) {
69			return $myForm;
70			}
71
72			return $this->renderWithSemester('administration/semester/event/new.html.twig', $semester, ['form' => $myForm->createView()]);
73			}
74
75			/**
76			* @Route("/{event}/edit", name="administration_semester_event_edit")
77			*
78			* @param Request $request
79			* @param Semester $semester
80			* @param Event $event
81			*
82			* @return Response
83			*/
84			public function editAction(Request $request, Semester $semester, Event $event)
85			{
86			$this->ensureAccessGranted($event);
87
88			//process form
89			$myForm = $this->handleUpdateForm(
90			$request,
91			$event,
92			function () use ($event) {
93			return $this->prePersistActions($event);
94			}
95			);
96			if ($myForm instanceof Response) {
97			return $myForm;
98			}
99
100			return $this->renderWithSemester('administration/semester/event/edit.html.twig', $semester, ['form' => $myForm->createView(), 'event' => $event]);
101			}
102
103			/**
104			* @Route("/{event}/view/", name="administration_semester_event_view")
105			*
106			* @param Semester $semester
107			* @param Event $event
108			*
109			* @return Response
110			*/
111			public function viewAction(Semester $semester, Event $event)
112			{
113			return $this->renderWithSemester('administration/semester/event/view.html.twig', $semester, ['event' => $event]);
114			}
115
116			/**
117			* @Route("/{event}/result", name="administration_semester_event_result")
118			*
119			* @param Semester $semester
120			* @param Event $event
121			*
122			* @return Response
123			*/
124			public function resultAction(Semester $semester, Event $event)
125			{
126			return $this->renderWithSemester('administration/semester/event/result.html.twig', $semester, ['event' => $event]);
127			}
128
129			/** *
130			* @Route("/{event}/remove", name="administration_semester_event_remove")
131			*
132			* @param Request $request
133			* @param Semester $semester
134			* @param Event $event
135			*
136			* @return Response
137			*/
138			public function removeAction(Request $request, Semester $semester, Event $event)
139			{
140			$this->ensureAccessGranted($event);
141
142			//process form
143			$form = $this->handleDeleteForm($request, $event);
144			if ($form === null) {
145			return $this->redirectToRoute('administration_semesters');
146			}
147
148			return $this->renderWithSemester('administration/semester/event/remove.html.twig', $semester, ['event' => $event, 'form' => $form->createView()]);
149			}
150
151			/**
152			* get the breadcrumbs leading to this controller.
153			*
154			* @return Breadcrumb[]
155			*/
156			protected function getIndexBreadcrumbs()
157			{
158			return array_merge(parent::getIndexBreadcrumbs(), [
159			new Breadcrumb(
160			$this->generateUrl('administration_semesters'),
161			$this->getTranslator()->trans('index.title', [], 'administration_semester')
162			),
163			]);
164			}
165
166			/**
167			* @param Event $event
168			*/
169			private function ensureAccessGranted(Event $event)
170			{
171			$this->denyAccessUnlessGranted(BaseVoter::VIEW, $event);
172			}
173
174			/**
175			* @param Event $event
176			*
177			* @return bool
178			*/
179			protected function prePersistActions(Event $event)
180			{
181			$event->loadTemplateIfSafe($this->getParameter('PUBLIC_DIR'));
182
183			return true;
184			}
185
186			/**
187			* renders the view & prepares views which need the active election.
188			*
189			* @param string $view
190			* @param Semester $semester
191			* @param array $parameters
192			*
193			* @return \Symfony\Component\HttpFoundation\Response
194			*/
195			protected function renderWithSemester(string $view, Semester $semester, array $parameters = [])
196			{
197			return $this->render($view, $parameters + ['semester' => $semester]);
198			}
199			}
200

TheAlternativeZurich / feedback

Push — master ( 55824b...ad17d9 )

EventController::resultAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like