AbstractDatagrid - Code Metrics - Inspection of "drop zf2" - ThaDafinser/ZfcDatagrid - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#263)

by Oliver

created 2016-11-13 03:09 UTC

AbstractDatagrid A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	4
c	0
b	0
f	0
lcom	0
cbo	3
dl	0
loc	46
rs	10

3 Methods

Rating	Name	Size	Complexity
	initGrid()	1	?
B	__invoke()	24	3
A	render()	6	1

<?php
namespace ZfcDatagrid\Service;

use Interop\Container\ContainerInterface;
use InvalidArgumentException;
use Zend\ServiceManager\Factory\FactoryInterface;
use ZfcDatagrid\Datagrid;

abstract class AbstractDatagrid extends Datagrid implements FactoryInterface
{
    /**
     * @param ContainerInterface $container
     * @param string             $requestedName
     * @param array|null         $options
     *
     * @return $this
     */
    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
    {
        $this->setServiceLocator($container);
        $config = $container->get('config');

        if (!isset($config['ZfcDatagrid'])) {
            throw new InvalidArgumentException('Config key "ZfcDatagrid" is missing');
        }

        /* @var $application \Zend\Mvc\Application */
        $application = $container->get('application');

        parent::setOptions($config['ZfcDatagrid']);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        parent::setMvcEvent($application->getMvcEvent());
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        if ($container->has('translator') === true) {
            parent::setTranslator($container->get('translator'));
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        }

        parent::setRendererService($container->get('zfcDatagrid.renderer.' . parent::getRendererName()));
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        parent::init();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        return $this;
    }

    /**
     * Call initGrid on rendering.
     */
    public function render()
    {
        $this->initGrid();

        parent::render();
    }

    abstract public function initGrid();
}


1			<?php
2			namespace ZfcDatagrid\Service;
3
4			use Interop\Container\ContainerInterface;
5			use InvalidArgumentException;
6			use Zend\ServiceManager\Factory\FactoryInterface;
7			use ZfcDatagrid\Datagrid;
8
9			abstract class AbstractDatagrid extends Datagrid implements FactoryInterface
10			{
11			/**
12			* @param ContainerInterface $container
13			* @param string $requestedName
14			* @param array\|null $options
15			*
16			* @return $this
17			*/
18			public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
19			{
20			$this->setServiceLocator($container);
21			$config = $container->get('config');
22
23			if (!isset($config['ZfcDatagrid'])) {
24			throw new InvalidArgumentException('Config key "ZfcDatagrid" is missing');
25			}
26
27			/* @var $application \Zend\Mvc\Application */
28			$application = $container->get('application');
29
30			parent::setOptions($config['ZfcDatagrid']);
			0 ignored issues – show Comprehensibility Bug introduced 2016-08-04 21:26 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setOptions()` instead of `__invoke()`). Are you sure this is correct? If so, you might want to change this to `$this->setOptions()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
31			parent::setMvcEvent($application->getMvcEvent());
			0 ignored issues – show Comprehensibility Bug introduced 2016-08-04 21:26 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setMvcEvent()` instead of `__invoke()`). Are you sure this is correct? If so, you might want to change this to `$this->setMvcEvent()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
32
33			if ($container->has('translator') === true) {
34			parent::setTranslator($container->get('translator'));
			0 ignored issues – show Comprehensibility Bug introduced 2016-08-04 21:26 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setTranslator()` instead of `__invoke()`). Are you sure this is correct? If so, you might want to change this to `$this->setTranslator()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
35			}
36
37			parent::setRendererService($container->get('zfcDatagrid.renderer.' . parent::getRendererName()));
			0 ignored issues – show Comprehensibility Bug introduced 2016-08-04 21:26 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getRendererName()` instead of `__invoke()`). Are you sure this is correct? If so, you might want to change this to `$this->getRendererName()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history... Comprehensibility Bug introduced 2016-08-04 21:26 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setRendererService()` instead of `__invoke()`). Are you sure this is correct? If so, you might want to change this to `$this->setRendererService()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
38			parent::init();
			0 ignored issues – show Comprehensibility Bug introduced 2016-08-04 21:26 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`init()` instead of `__invoke()`). Are you sure this is correct? If so, you might want to change this to `$this->init()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
39
40			return $this;
41			}
42
43			/**
44			* Call initGrid on rendering.
45			*/
46			public function render()
47			{
48			$this->initGrid();
49
50			parent::render();
51			}
52
53			abstract public function initGrid();
54			}
55

ThaDafinser / ZfcDatagrid

Pull Request — develop (#263)

AbstractDatagrid A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like