It seems like $name can also be of type object<ZfcDatagrid\Column\AbstractColumn>. However, the property $label is declared as type string. Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property.
This check raises an issue when a value that can be of a mixed type is assigned to
a property that is type hinted more strictly.
For example, imagine you have a variable $accountId that can either hold an
Id object or false (if there is no account id yet). Your code now assigns that
value to the id property of an instance of the Account class. This class
holds a proper account, so the id value must no longer be false.
Either this assignment is in error or a type check should be added for that assignment.
classId{public$id;publicfunction__construct($id){$this->id=$id;}}classAccount{/** @var Id $id */public$id;}$account_id=false;if(starsAreRight()){$account_id=newId(42);}$account=newAccount();if($accountinstanceofId){$account->id=$account_id;}
Loading history...
25
}
26
27
/**
28
* @return string|AbstractColumn
29
*/
30
public function getLabel()
31
{
32
return $this->label;
33
}
34
35
/**
36
* @return string
37
*
38
* @throws \Exception
39
*/
40
protected function getHtmlType()
41
{
42
throw new \Exception('not needed...since we have toHtml() here directly!');
43
}
44
45
/**
46
* @param array $row
47
*
48
* @return string
49
*/
50
public function toHtml(array $row)
51
{
52
if ($this->getLabel() == '') {
53
throw new \InvalidArgumentException('A label is required for this action type, please call $action->setLabel()!');
ThaDafinser /
ZfcDatagrid
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountIdthat can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theidproperty of an instance of theAccountclass. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.