AbstractHttpProvider::getResponse() - Code Metrics - Inspection of "adding http providers" - ThaDafinser/UserAgentParser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#43)

by Martin

created 2015-12-11 21:58 UTC

AbstractHttpProvider::getResponse() A

↳ Parent: AbstractHttpProvider

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	15
ccs	7
cts	7
cp	1
rs	9.4286
cc	3
eloc	8
nc	3
nop	1
crap	3

<?php
namespace UserAgentParser\Provider\Http;

use GuzzleHttp\Client;
use GuzzleHttp\Exception\RequestException as GuzzleHttpException;
use GuzzleHttp\Psr7\Response;
use Psr\Http\Message\RequestInterface;
use UserAgentParser\Exception;
use UserAgentParser\Provider\AbstractProvider;

abstract class AbstractHttpProvider extends AbstractProvider
{
    /**
     *
     * @var Client
     */
    private $client;

    /**
     *
     * @param Client $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     *
     * @return Client
     */
    public function getClient()
    {
        return $this->client;
    }

    /**
     *
     * @param  RequestInterface           $request
     * @return Response
     * @throws Exception\RequestException
     */
    protected function getResponse(RequestInterface $request)
    {
        try {
            /* @var $response \GuzzleHttp\Psr7\Response */
            $response = $this->getClient()->send($request);
        } catch (GuzzleHttpException $ex) {
            throw new Exception\RequestException('Could not get valid response from "' . $request->getUri() . '"', null, $ex);
        }

        if ($response->getStatusCode() !== 200) {
            throw new Exception\RequestException('Could not get valid response from "' . $request->getUri() . '". Status code is: "' . $response->getStatusCode() . '"');
        }

        return $response;
    }
}


1		<?php
2		namespace UserAgentParser\Provider\Http;
3
4		use GuzzleHttp\Client;
5		use GuzzleHttp\Exception\RequestException as GuzzleHttpException;
6		use GuzzleHttp\Psr7\Response;
7		use Psr\Http\Message\RequestInterface;
8		use UserAgentParser\Exception;
9		use UserAgentParser\Provider\AbstractProvider;
10
11		abstract class AbstractHttpProvider extends AbstractProvider
12		{
13		/**
14		*
15		* @var Client
16		*/
17		private $client;
18
19		/**
20		*
21		* @param Client $client
22		*/
23	3	public function __construct(Client $client)
24		{
25	3	$this->client = $client;
26	3	}
27
28		/**
29		*
30		* @return Client
31		*/
32	3	public function getClient()
33		{
34	3	return $this->client;
35		}
36
37		/**
38		*
39		* @param RequestInterface $request
40		* @return Response
41		* @throws Exception\RequestException
42		*/
43	3	protected function getResponse(RequestInterface $request)
44		{
45		try {
46		/* @var $response \GuzzleHttp\Psr7\Response */
47	3	$response = $this->getClient()->send($request);
48	3	} catch (GuzzleHttpException $ex) {
49	1	throw new Exception\RequestException('Could not get valid response from "' . $request->getUri() . '"', null, $ex);
50		}
51
52	2	if ($response->getStatusCode() !== 200) {
53	1	throw new Exception\RequestException('Could not get valid response from "' . $request->getUri() . '". Status code is: "' . $response->getStatusCode() . '"');
54		}
55
56	1	return $response;
57		}
58		}
59

ThaDafinser / UserAgentParser

GitHub Access Token became invalid

Pull Request — master (#43)

AbstractHttpProvider::getResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like