Wurfl::isRealBrand() - Code Metrics - Inspection of "Fix more generic values" - ThaDafinser/UserAgentParser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#31)

by Niels

created 2015-11-23 14:09 UTC

Wurfl::isRealBrand() A

↳ Parent: Wurfl

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	4.0741

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	12
ccs	5
cts	6
cp	0.8333
rs	9.2
cc	4
eloc	6
nc	3
nop	1
crap	4.0741

<?php
namespace UserAgentParser\Provider;

use UserAgentParser\Exception;
use UserAgentParser\Model;
use Wurfl\CustomDevice;
use Wurfl\Manager as WurflManager;

class Wurfl extends AbstractProvider
{
    /**
     *
     * @var WurflManager
     */
    private $parser;

    /**
     *
     * @param WurflManager $parser
     */
    public function __construct(WurflManager $parser)
    {
        $this->setParser($parser);
    }

    public function getName()
    {
        return 'Wurfl';
    }

    public function getComposerPackageName()
    {
        return 'mimmi20/wurfl';
    }

    public function getVersion()
    {
        return $this->getParser()->getWurflInfo()->version;
    }

    /**
     *
     * @param WurflManager $parser
     */
    public function setParser(WurflManager $parser)
    {
        $this->parser = $parser;
    }

    /**
     *
     * @return WurflManager
     */
    public function getParser()
    {
        return $this->parser;
    }

    /**
     * @param mixed $value
     *
     * @return bool
     */
    private function isRealBrand($value)
    {
        if ($value === '' || $value === null) {
            return false;
        }

        if ($value == 'Generic') {
            return false;
        }

        return true;
    }

    /**
     * @param mixed $value
     *
     * @return bool
     */
    private function isRealModel($value)
    {
        if ($value === '' || $value === null) {
            return false;
        }

        if (substr((string) $value, 0, 7) == 'Android') {
            return false;
        }

        if (substr((string) $value, 0, 7) == 'Firefox') {
            return false;
        }

        if (substr((string) $value, 0, 7) == 'Generic') {
            return false;
        }

        if (substr((string) $value, 0, 12) == 'unrecognized') {
            return false;
        }

        if (substr((string) $value, 0, 14) == 'Windows Mobile') {
            return false;
        }

        if (substr((string) $value, 0, 13) == 'Windows Phone') {
            return false;
        }

        if (substr((string) $value, 0, 10) == 'Windows RT') {
            return false;
        }

        return true;
    }

    /**
     *
     * @param  CustomDevice $device
     * @return boolean
     */
    private function hasResult(CustomDevice $device)
    {
        if ($device->id !== null && $device->id != '' && $device->id !== 'generic') {
            return true;
        }

        return false;
    }

    public function parse($userAgent, array $headers = [])
    {
        $parser = $this->getParser();

        $deviceRaw = $parser->getDeviceForUserAgent($userAgent);

        /*
         * No result found?
         */
        if ($this->hasResult($deviceRaw) !== true) {
            throw new Exception\NoResultFoundException('No result found for user agent: ' . $userAgent);
        }

        /*
         * Hydrate the model
         */
        $result = new Model\UserAgent();
        $result->setProviderResultRaw([
            'virtual' => $deviceRaw->getAllVirtualCapabilities(),
            'all'     => $deviceRaw->getAllCapabilities(),
        ]);

        /*
         * Bot detection
         */
        if ($deviceRaw->getVirtualCapability('is_robot') === 'true') {
            $bot = $result->getBot();
            $bot->setIsBot(true);

            // brand_name seems to be always google, so dont use it

            return $result;
        }

        /*
         * browser
         */
        $browser = $result->getBrowser();

        $browser->setName($deviceRaw->getVirtualCapability('advertised_browser'));
        $browser->getVersion()->setComplete($deviceRaw->getVirtualCapability('advertised_browser_version'));

        /*
         * operatingSystem
         */
        $operatingSystem = $result->getOperatingSystem();

        $operatingSystem->setName($deviceRaw->getVirtualCapability('advertised_device_os'));
        $operatingSystem->getVersion()->setComplete($deviceRaw->getVirtualCapability('advertised_device_os_version'));

        /*
         * device
         */
        $device = $result->getDevice();

        if ($deviceRaw->getVirtualCapability('is_full_desktop') !== 'true') {
            if ($this->isRealModel($deviceRaw->getCapability('model_name')) === true) {
                $device->setModel($deviceRaw->getCapability('model_name'));
            }

            if ($this->isRealBrand($deviceRaw->getCapability('brand_name')) === true) {
                $device->setBrand($deviceRaw->getCapability('brand_name'));
            }

            if ($deviceRaw->getVirtualCapability('is_mobile') === 'true') {
                $device->setIsMobile(true);
            }

            if ($deviceRaw->getVirtualCapability('is_touchscreen') === 'true') {
                $device->setIsTouch(true);
            }
        }

        // @see the list of all types http://web.wurfl.io/
        $device->setType($deviceRaw->getVirtualCapability('form_factor'));

        return $result;
    }
}


1		<?php
2		namespace UserAgentParser\Provider;
3
4		use UserAgentParser\Exception;
5		use UserAgentParser\Model;
6		use Wurfl\CustomDevice;
7		use Wurfl\Manager as WurflManager;
8
9		class Wurfl extends AbstractProvider
10		{
11		/**
12		*
13		* @var WurflManager
14		*/
15		private $parser;
16
17		/**
18		*
19		* @param WurflManager $parser
20		*/
21	9	public function __construct(WurflManager $parser)
22		{
23	9	$this->setParser($parser);
24	9	}
25
26	1	public function getName()
27		{
28	1	return 'Wurfl';
29		}
30
31	1	public function getComposerPackageName()
32		{
33	1	return 'mimmi20/wurfl';
34		}
35
36	1	public function getVersion()
37		{
38	1	return $this->getParser()->getWurflInfo()->version;
39		}
40
41		/**
42		*
43		* @param WurflManager $parser
44		*/
45	9	public function setParser(WurflManager $parser)
46		{
47	9	$this->parser = $parser;
48	9	}
49
50		/**
51		*
52		* @return WurflManager
53		*/
54	7	public function getParser()
55		{
56	7	return $this->parser;
57		}
58
59		/**
60		* @param mixed $value
61		*
62		* @return bool
63		*/
64	3	private function isRealBrand($value)
65		{
66	3	if ($value === '' \|\| $value === null) {
67	2	return false;
68		}
69
70	1	if ($value == 'Generic') {
71		return false;
72		}
73
74	1	return true;
75		}
76
77		/**
78		* @param mixed $value
79		*
80		* @return bool
81		*/
82	3	private function isRealModel($value)
83		{
84	3	if ($value === '' \|\| $value === null) {
85	2	return false;
86		}
87
88	1	if (substr((string) $value, 0, 7) == 'Android') {
89		return false;
90		}
91
92	1	if (substr((string) $value, 0, 7) == 'Firefox') {
93		return false;
94		}
95
96	1	if (substr((string) $value, 0, 7) == 'Generic') {
97		return false;
98		}
99
100	1	if (substr((string) $value, 0, 12) == 'unrecognized') {
101		return false;
102		}
103
104	1	if (substr((string) $value, 0, 14) == 'Windows Mobile') {
105		return false;
106		}
107
108	1	if (substr((string) $value, 0, 13) == 'Windows Phone') {
109		return false;
110		}
111
112	1	if (substr((string) $value, 0, 10) == 'Windows RT') {
113		return false;
114		}
115
116	1	return true;
117		}
118
119		/**
120		*
121		* @param CustomDevice $device
122		* @return boolean
123		*/
124	5	private function hasResult(CustomDevice $device)
125		{
126	5	if ($device->id !== null && $device->id != '' && $device->id !== 'generic') {
127	4	return true;
128		}
129
130	1	return false;
131		}
132
133	5	public function parse($userAgent, array $headers = [])
134		{
135	5	$parser = $this->getParser();
136
137	5	$deviceRaw = $parser->getDeviceForUserAgent($userAgent);
138
139		/*
140		* No result found?
141		*/
142	5	if ($this->hasResult($deviceRaw) !== true) {
143	1	throw new Exception\NoResultFoundException('No result found for user agent: ' . $userAgent);
144		}
145
146		/*
147		* Hydrate the model
148		*/
149	4	$result = new Model\UserAgent();
150	4	$result->setProviderResultRaw([
151	4	'virtual' => $deviceRaw->getAllVirtualCapabilities(),
152	4	'all' => $deviceRaw->getAllCapabilities(),
153	4	]);
154
155		/*
156		* Bot detection
157		*/
158	4	if ($deviceRaw->getVirtualCapability('is_robot') === 'true') {
159	1	$bot = $result->getBot();
160	1	$bot->setIsBot(true);
161
162		// brand_name seems to be always google, so dont use it
163
164	1	return $result;
165		}
166
167		/*
168		* browser
169		*/
170	3	$browser = $result->getBrowser();
171
172	3	$browser->setName($deviceRaw->getVirtualCapability('advertised_browser'));
173	3	$browser->getVersion()->setComplete($deviceRaw->getVirtualCapability('advertised_browser_version'));
174
175		/*
176		* operatingSystem
177		*/
178	3	$operatingSystem = $result->getOperatingSystem();
179
180	3	$operatingSystem->setName($deviceRaw->getVirtualCapability('advertised_device_os'));
181	3	$operatingSystem->getVersion()->setComplete($deviceRaw->getVirtualCapability('advertised_device_os_version'));
182
183		/*
184		* device
185		*/
186	3	$device = $result->getDevice();
187
188	3	if ($deviceRaw->getVirtualCapability('is_full_desktop') !== 'true') {
189	3	if ($this->isRealModel($deviceRaw->getCapability('model_name')) === true) {
190	1	$device->setModel($deviceRaw->getCapability('model_name'));
191		}
192
193	3	if ($this->isRealBrand($deviceRaw->getCapability('brand_name')) === true) {
194	1	$device->setBrand($deviceRaw->getCapability('brand_name'));
195		}
196
197	3	if ($deviceRaw->getVirtualCapability('is_mobile') === 'true') {
198	1	$device->setIsMobile(true);
199		}
200
201	3	if ($deviceRaw->getVirtualCapability('is_touchscreen') === 'true') {
202	1	$device->setIsTouch(true);
203		}
204		}
205
206		// @see the list of all types http://web.wurfl.io/
207	3	$device->setType($deviceRaw->getVirtualCapability('form_factor'));
208
209	3	return $result;
210		}
211		}
212

ThaDafinser / UserAgentParser

GitHub Access Token became invalid

Pull Request — master (#31)

Wurfl::isRealBrand() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like