Th3Mouk / YahooWeatherAPI

src/YahooWeatherAPI.php

<?php

/*
 * (c) Jérémy Marodon         <marodon.jeremy@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Th3Mouk\YahooWeatherAPI;

use GuzzleHttp\Client;
use Th3Mouk\YahooWeatherAPI\Query\Query;

class YahooWeatherAPI implements YahooWeatherAPIInterface
{
    /**
     * @var Client Goutte client
     */
    protected $client;

    /**
     * @var array last response from API
     */
    protected $lastResponse;

    /**
     * @var string last woeid explicitly called
     */
    protected $woeid;

    /**
     * @var string last city name explicitly called
     */
    protected $city;

    /**
     * @var string the last url called
     */
    protected $yql;

    public function __construct()
    {
        $this->client = new Client();
    }

    /**
     * {@inheritdoc}
     */
    public function callApiWoeid($woeid = null, $unit = 'c')

This method seems to be duplicated in your project.

    {
        if ($woeid === null && $this->woeid === null) {
            throw new \Exception('Please provide a woeid code', 400);
        }

        if ($woeid !== null) {
            $this->woeid = $woeid;
        }

        $this->yql = Query::URL_BASE.urlencode(sprintf(Query::WOEID_QUERY, $this->woeid, $unit));

        return $this->callApi();
    }

    /**
     * {@inheritdoc}
     */
    public function callApiCityName($city = null, $unit = 'c')

This method seems to be duplicated in your project.

    {
        if ($city === null && $this->city === null) {
            throw new \Exception('Please provide a city\'s name', 400);
        }

        if ($city !== null) {
            $this->city = $city;
        }

        $this->yql = Query::URL_BASE.urlencode(sprintf(Query::CITY_NAME_QUERY, $this->city, $unit));

        return $this->callApi();
    }

    /**
     * {@inheritdoc}
     */
    public function callApi($yql = null)
    {
        if ($yql === null && empty($this->yql)) {
            throw new \Exception('Please provide a YQL request', 400);
        }

        if ($yql !== null) {
            $this->yql = $yql;
        }

        try {
            $headers = array(
                'verify' => false,
            );
            $response = $this->client->request('GET', $this->yql, $headers);
            $response = json_decode($response->getBody(), true);
            if (!isset($response['query']['results']['channel']['item']['condition'])) {
                $this->lastResponse = false;

It seems like false of type false is incompatible with the declared type array of property $lastResponse.

            } else {
                $this->lastResponse = $response['query']['results']['channel'];
            }
        } catch (\Exception $e) {
            throw new \Exception("Something error happen, please check your request url whether it's correct.", 400);
        }

        return $this->lastResponse;
    }

    /**
     * Get lastResponse.
     *
     * @param bool $toJson choose format for the return value (array or json)
     *
     * @return array|string
     */
    public function getLastResponse($toJson = false)
    {
        return ($toJson) ? json_encode($this->lastResponse) : $this->lastResponse;
    }

    /**
     * Set lastResponse.
     *
     * @param array $data data from json_encode
     */
    public function setLastResponse($data)
    {
        $this->lastResponse = $data;
    }

    /**
     * Get current temperature.
     *
     * @param bool $withUnit return or not the unit
     *
     * @return string
     */
    public function getTemperature($withUnit = false)
    {
        if (!$this->lastResponse || !isset($this->lastResponse['item']['condition']['temp'])) {

The expression $this->lastResponse of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return '';
        }
        $return = $this->lastResponse['item']['condition']['temp'];
        if ($withUnit) {
            $return .= ' '.$this->lastResponse['units']['temperature'];
        }

        return $return;
    }

    /**
     * Get Location.
     *
     * @return string
     */
    public function getLocation()

This method seems to be duplicated in your project.

    {
        if (!$this->lastResponse || !isset($this->lastResponse['location']['city'])) {

The expression $this->lastResponse of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return '';
        }

        return $this->lastResponse['location']['city'];
    }

    /**
     * get Forecast.
     *
     * @return array
     */
    public function getForecast()

This method seems to be duplicated in your project.

    {
        if (!$this->lastResponse || !isset($this->lastResponse['item']['forecast'])) {

The expression $this->lastResponse of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return array();
        }

        return $this->lastResponse['item']['forecast'];
    }

    /**
     * get Wind.
     *
     * @param bool $withUnit return or not the unit
     *
     * @return array
     */
    public function getWind($withUnit = false)
    {
        if (!$this->lastResponse || !isset($this->lastResponse['wind']['speed'])) {

The expression $this->lastResponse of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return array();
        }

        $response = array(
            'chill' => $this->lastResponse['wind']['chill'],
            'direction' => $this->lastResponse['wind']['direction'],
            'speed' => $this->lastResponse['wind']['speed'],
        );

        if ($withUnit) {
            $response['speed'] .= ' '.$this->lastResponse['units']['speed'];
        }

        return $response;
    }

    /**
     * @param GoutteClient $client
     */
    public function setClient(Client $client)
    {
        $this->client = $client;
    }

    /**
     * @return string
     */
    public function getWoeid()
    {
        return $this->woeid;
    }

    /**
     * @return string
     */
    public function getCity()
    {
        return $this->city;
    }

    /**
     * @return string
     */
    public function getYql()
    {
        return $this->yql;
    }
}