YahooWeatherClientTests - Code Metrics - Inspection of "add unit testing and replace goutte with guzzle" - Th3Mouk/YahooWeatherAPI - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by lee

created 2016-09-27 15:28 UTC

YahooWeatherClientTests A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	303
Duplicated Lines	17.82 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	23
c	1
b	0
f	0
lcom	2
cbo	3
dl	54
loc	303
rs	10

19 Methods

Rating	Name	Duplication	Size	Complexity
A	setClientTest()	0	6	1
A	setLastResTest()	0	7	1
A	getWoeidTest()	0	4	1
A	getCityTest()	0	4	1
A	getYqlTest()	0	4	1
A	getResponseData()	0	7	1
A	testCallApiWoeidException()	12	12	2
A	testCallApiCityNameException()	12	12	2
A	testCallApiTestException()	12	12	2
A	testCallApiLastRes()	14	14	2
A	callApiWoeidTest()	0	18	1
A	callApiCityNameTest()	0	15	1
A	callApiTest()	0	23	1
A	getLastResTest()	0	12	1
B	getTemperatureTest()	0	24	1
A	getLocationTest()	0	22	1
A	getForecastTest()	0	20	1
B	getWindTest()	0	36	1
A	encodeURI()	0	16	1

How to fix Duplicated Code

<?php

/*
 * (c) Jean-Baptiste Audebert <[email protected]>
 * (c) Jérémy Marodon         <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Th3Mouk\YahooWeatherAPI\Tests;

use GuzzleHttp\Client;
use PHPUnit\Framework\TestCase;
use Th3Mouk\YahooWeatherAPI\YahooWeatherAPI;

class YahooWeatherClientTests extends TestCase
{
    /** @test */
    public function testCallApiWoeidException()

    {
        $service = new YahooWeatherAPI();

        $this->expectException(\Exception::class);

        try {
            $response = $service->callApiWoeid(null);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
            throw $e;
        }
    }

    /** @test */
    public function testCallApiCityNameException()

    {
        $service = new YahooWeatherAPI();

        $this->expectException(\Exception::class);

        try {
            $response = $service->callApiCityName(null);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
            throw $e;
        }
    }

    /** @test */
    public function testCallApiTestException()

    {
        $service = new YahooWeatherAPI();

        $this->expectException(\Exception::class);

        try {
            $response = $service->callApi(null);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
            throw $e;
        }
    }

    /** @test */
    public function testCallApiLastRes()

    {
        $errYql = 'https://query.yahooapis.com/v1/public/yql?q=from%20weather.forecast%20where%20woeid%20in%20(select%20woeid%20from%20geo.places(1)%20where%20text=%22Taipei%22)&format=json&env=store://datatables.org/alltableswithkeys';

        $service = new YahooWeatherAPI();

        $this->expectException(\Exception::class);

        try {
            $response = $service->callApi($errYql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
            throw $e;
        }
    }

    /** @test */
    public function setClientTest()
    {
        $service = new YahooWeatherAPI();
        $response = $service->setClient(new Client());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertSame($response, null);
    }

    /** @test */
    public function setLastResTest()
    {
        $service = new YahooWeatherAPI();

        $response = $service->setLastResponse(null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertSame($response, null);
    }

    /** @test */
    public function callApiWoeidTest()
    {
        $service = new YahooWeatherAPI();
        $response = $service->callApiWoeid(1232345678);
        $this->assertSame($response, false);

        $response = $service->callApiWoeid(2306179);
        $city = str_replace(' ', '', $response['location']['city']);
        $country = str_replace(' ', '', $response['location']['country']);
        $region = str_replace(' ', '', $response['location']['region']);
        $this->assertSame($city, 'TaipeiCity');
        $this->assertSame($country, 'Taiwan');
        $this->assertSame($region, 'TaipeiCity');

        $woeid = 2306179;
        $response = $this->getWoeidTest($service);
        $this->assertSame($response, $woeid);
    }

    /** @test */
    public function callApiCityNameTest()
    {
        $service = new YahooWeatherAPI();
        $response = $service->callApiCityName('Taipei');
        $city = str_replace(' ', '', $response['location']['city']);
        $country = str_replace(' ', '', $response['location']['country']);
        $region = str_replace(' ', '', $response['location']['region']);
        $this->assertSame($city, 'TaipeiCity');
        $this->assertSame($country, 'Taiwan');
        $this->assertSame($region, 'TaipeiCity');

        $city = 'Taipei';
        $response = $this->getCityTest($service);
        $this->assertSame($response, $city);
    }

    /** @test */
    public function callApiTest()
    {
        $service = new YahooWeatherAPI();
        $yql = 'select * from weather.forecast where woeid in (select woeid from geo.places(1) where text="123456789")';
        $url = 'https://query.yahooapis.com/v1/public/yql?q='.$yql.'&format=json&env=store://datatables.org/alltableswithkeys';
        $url = $this->encodeURI($url);
        $response = $service->callApi($url);
        $this->assertSame($response, false);

        $yql = 'select * from weather.forecast where woeid in (select woeid from geo.places(1) where text="Taipei")';
        $url = 'https://query.yahooapis.com/v1/public/yql?q='.$yql.'&format=json&env=store://datatables.org/alltableswithkeys';
        $url = $this->encodeURI($url);
        $response = $service->callApi($url);
        $city = str_replace(' ', '', $response['location']['city']);
        $country = str_replace(' ', '', $response['location']['country']);
        $region = str_replace(' ', '', $response['location']['region']);
        $this->assertSame($city, 'TaipeiCity');
        $this->assertSame($country, 'Taiwan');
        $this->assertSame($region, 'TaipeiCity');

        $response = $this->getYqlTest($service);
        $this->assertSame($response, $url);
    }

    /** @test */
    public function getLastResTest()
    {
        $service = new YahooWeatherAPI();

        $service->setLastResponse($this->getResponseData());

        $response = $service->getLastResponse(false);
        $this->assertSame(is_array($response), true);

        $response = $service->getLastResponse(true);
        $this->assertSame(is_array($response), false);
    }

    /** @test */
    public function getTemperatureTest()
    {
        $service = new YahooWeatherAPI();
        $response = $this->getResponseData();
        $storeRes = $response;

        $service->setLastResponse(null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $service->getLastResponse(true);
        $response = $service->getTemperature(true);
        $this->assertSame($response, '');

        $noTemp = $storeRes;
        $noTemp['item']['condition']['temp'] = null;
        $service->setLastResponse($noTemp);
        $response = $service->getTemperature(false);
        $this->assertSame($response, '');

        $service->setLastResponse($storeRes);
        $response = $service->getTemperature(true);
        $this->assertSame(is_string($response), true);

        $response = $service->getTemperature(false);
        $this->assertSame(is_string((int) $response), false);
    }

    /** @test */
    public function getLocationTest()
    {
        $service = new YahooWeatherAPI();
        $response = $this->getResponseData();
        $storeRes = $response;

        $service->setLastResponse(null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $response = $service->getLocation();
        $this->assertSame($response, '');

        $noCity = $storeRes;
        $noCity['location']['city'] = null;
        $service->setLastResponse($noCity);
        $response = $service->getLocation();
        $this->assertSame($response, '');


        $service->setLastResponse($storeRes);
        $response = $service->getLocation();
        $city = str_replace(' ', '', $response);
        $this->assertSame($city, 'TaipeiCity');
    }

    /** @test */
    public function getForecastTest()
    {
        $service = new YahooWeatherAPI();
        $response = $this->getResponseData();
        $storeRes = $response;

        $service->setLastResponse(null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $response = $service->getForecast();
        $this->assertSame(count($response), 0);

        $noForecast = $storeRes;
        $noForecast['item']['forecast'] = null;
        $service->setLastResponse($noForecast);
        $response = $service->getForecast();
        $this->assertSame(count($response), 0);

        $service->setLastResponse($storeRes);
        $response = $service->getForecast();
        $this->assertSame(count($response), 10);
    }

    /** @test */
    public function getWindTest()
    {
        $service = new YahooWeatherAPI();
        $response = $this->getResponseData();
        $storeRes = $response;

        $service->setLastResponse(null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $response = $service->getWind(true);
        $this->assertSame(count($response), 0);

        $noSpeed = $storeRes;
        $noSpeed['wind']['speed'] = null;
        $service->setLastResponse($noSpeed);
        $response = $service->getWind(true);
        $this->assertSame(count($response), 0);

        $service->setLastResponse($storeRes);
        $expectRes = array(
            'chill' => $storeRes['wind']['chill'],
            'direction' => $storeRes['wind']['direction'],
            'speed' => $storeRes['wind']['speed'],
        );

        $response = $service->getWind(true);
        $expectRes['speed'] .= ' '.$storeRes['units']['speed'];
        $this->assertSame($response['speed'], $expectRes['speed']);

        $expectRes = array(
            'chill' => $storeRes['wind']['chill'],
            'direction' => $storeRes['wind']['direction'],
            'speed' => $storeRes['wind']['speed'],
        );

        $response = $service->getWind(false);
        $this->assertSame($response['speed'], $expectRes['speed']);
    }

    public function getWoeidTest(YahooWeatherAPI $service)
    {
        return $service->getWoeid();
    }

    public function getCityTest(YahooWeatherAPI $service)
    {
        return $service->getCity();
    }

    public function getYqlTest(YahooWeatherAPI $service)
    {
        return $service->getYql();
    }

    public function encodeURI($url)
    {
        $unescaped = array(
            '%2D' => '-', '%5F' => '_', '%2E' => '.', '%21' => '!', '%7E' => '~',
            '%2A' => '*', '%27' => "'", '%28' => '(', '%29' => ')',
        );
        $reserved = array(
            '%3B' => ';', '%2C' => ',', '%2F' => '/', '%3F' => '?', '%3A' => ':',
            '%40' => '@', '%26' => '&', '%3D' => '=', '%2B' => '+', '%24' => '$',
        );
        $score = array(
            '%23' => '#',
        );

        return strtr(rawurlencode($url), array_merge($reserved, $unescaped, $score));
    }

    public function getResponseData()
    {
        $response = file_get_contents('tests/response.json');
        $response = json_decode($response, true);

        return $response;
    }
}


1		<?php
2
3		/*
4		* (c) Jean-Baptiste Audebert <[email protected]>
5		* (c) Jérémy Marodon <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace Th3Mouk\YahooWeatherAPI\Tests;
12
13		use GuzzleHttp\Client;
14		use PHPUnit\Framework\TestCase;
15		use Th3Mouk\YahooWeatherAPI\YahooWeatherAPI;
16
17		class YahooWeatherClientTests extends TestCase
18		{
19		/** @test */
20	View Code Duplication	public function testCallApiWoeidException()
		0 ignored issues – show Duplication introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		{
22		$service = new YahooWeatherAPI();
23
24		$this->expectException(\Exception::class);
25
26		try {
27		$response = $service->callApiWoeid(null);
		0 ignored issues – show Unused Code introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
28		} catch (\Exception $e) {
29		throw $e;
30		}
31		}
32
33		/** @test */
34	View Code Duplication	public function testCallApiCityNameException()
		0 ignored issues – show Duplication introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		{
36		$service = new YahooWeatherAPI();
37
38		$this->expectException(\Exception::class);
39
40		try {
41		$response = $service->callApiCityName(null);
		0 ignored issues – show Unused Code introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
42		} catch (\Exception $e) {
43		throw $e;
44		}
45		}
46
47		/** @test */
48	View Code Duplication	public function testCallApiTestException()
		0 ignored issues – show Duplication introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		{
50		$service = new YahooWeatherAPI();
51
52		$this->expectException(\Exception::class);
53
54		try {
55		$response = $service->callApi(null);
		0 ignored issues – show Unused Code introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
56		} catch (\Exception $e) {
57		throw $e;
58		}
59		}
60
61		/** @test */
62	View Code Duplication	public function testCallApiLastRes()
		0 ignored issues – show Duplication introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		{
64		$errYql = 'https://query.yahooapis.com/v1/public/yql?q=from%20weather.forecast%20where%20woeid%20in%20(select%20woeid%20from%20geo.places(1)%20where%20text=%22Taipei%22)&format=json&env=store://datatables.org/alltableswithkeys';
65
66		$service = new YahooWeatherAPI();
67
68		$this->expectException(\Exception::class);
69
70		try {
71		$response = $service->callApi($errYql);
		0 ignored issues – show Unused Code introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
72		} catch (\Exception $e) {
73		throw $e;
74		}
75		}
76
77		/** @test */
78		public function setClientTest()
79		{
80		$service = new YahooWeatherAPI();
81		$response = $service->setClient(new Client());
		0 ignored issues – show Bug introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$response` is correct as `$service->setClient(new \GuzzleHttp\Client())` (which targets `Th3Mouk\YahooWeatherAPI\...WeatherAPI::setClient()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
82		$this->assertSame($response, null);
83		}
84
85		/** @test */
86		public function setLastResTest()
87		{
88		$service = new YahooWeatherAPI();
89
90		$response = $service->setLastResponse(null);
		0 ignored issues – show Documentation introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$response` is correct as `$service->setLastResponse(null)` (which targets `Th3Mouk\YahooWeatherAPI\...rAPI::setLastResponse()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
91		$this->assertSame($response, null);
92		}
93
94		/** @test */
95		public function callApiWoeidTest()
96		{
97		$service = new YahooWeatherAPI();
98		$response = $service->callApiWoeid(1232345678);
99		$this->assertSame($response, false);
100
101		$response = $service->callApiWoeid(2306179);
102		$city = str_replace(' ', '', $response['location']['city']);
103		$country = str_replace(' ', '', $response['location']['country']);
104		$region = str_replace(' ', '', $response['location']['region']);
105		$this->assertSame($city, 'TaipeiCity');
106		$this->assertSame($country, 'Taiwan');
107		$this->assertSame($region, 'TaipeiCity');
108
109		$woeid = 2306179;
110		$response = $this->getWoeidTest($service);
111		$this->assertSame($response, $woeid);
112		}
113
114		/** @test */
115		public function callApiCityNameTest()
116		{
117		$service = new YahooWeatherAPI();
118		$response = $service->callApiCityName('Taipei');
119		$city = str_replace(' ', '', $response['location']['city']);
120		$country = str_replace(' ', '', $response['location']['country']);
121		$region = str_replace(' ', '', $response['location']['region']);
122		$this->assertSame($city, 'TaipeiCity');
123		$this->assertSame($country, 'Taiwan');
124		$this->assertSame($region, 'TaipeiCity');
125
126		$city = 'Taipei';
127		$response = $this->getCityTest($service);
128		$this->assertSame($response, $city);
129		}
130
131		/** @test */
132		public function callApiTest()
133		{
134		$service = new YahooWeatherAPI();
135		$yql = 'select * from weather.forecast where woeid in (select woeid from geo.places(1) where text="123456789")';
136		$url = 'https://query.yahooapis.com/v1/public/yql?q='.$yql.'&format=json&env=store://datatables.org/alltableswithkeys';
137		$url = $this->encodeURI($url);
138		$response = $service->callApi($url);
139		$this->assertSame($response, false);
140
141		$yql = 'select * from weather.forecast where woeid in (select woeid from geo.places(1) where text="Taipei")';
142		$url = 'https://query.yahooapis.com/v1/public/yql?q='.$yql.'&format=json&env=store://datatables.org/alltableswithkeys';
143		$url = $this->encodeURI($url);
144		$response = $service->callApi($url);
145		$city = str_replace(' ', '', $response['location']['city']);
146		$country = str_replace(' ', '', $response['location']['country']);
147		$region = str_replace(' ', '', $response['location']['region']);
148		$this->assertSame($city, 'TaipeiCity');
149		$this->assertSame($country, 'Taiwan');
150		$this->assertSame($region, 'TaipeiCity');
151
152		$response = $this->getYqlTest($service);
153		$this->assertSame($response, $url);
154		}
155
156		/** @test */
157		public function getLastResTest()
158		{
159		$service = new YahooWeatherAPI();
160
161		$service->setLastResponse($this->getResponseData());
162
163		$response = $service->getLastResponse(false);
164		$this->assertSame(is_array($response), true);
165
166		$response = $service->getLastResponse(true);
167		$this->assertSame(is_array($response), false);
168		}
169
170		/** @test */
171		public function getTemperatureTest()
172		{
173		$service = new YahooWeatherAPI();
174		$response = $this->getResponseData();
175		$storeRes = $response;
176
177		$service->setLastResponse(null);
		0 ignored issues – show Documentation introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
178		$service->getLastResponse(true);
179		$response = $service->getTemperature(true);
180		$this->assertSame($response, '');
181
182		$noTemp = $storeRes;
183		$noTemp['item']['condition']['temp'] = null;
184		$service->setLastResponse($noTemp);
185		$response = $service->getTemperature(false);
186		$this->assertSame($response, '');
187
188		$service->setLastResponse($storeRes);
189		$response = $service->getTemperature(true);
190		$this->assertSame(is_string($response), true);
191
192		$response = $service->getTemperature(false);
193		$this->assertSame(is_string((int) $response), false);
194		}
195
196		/** @test */
197		public function getLocationTest()
198		{
199		$service = new YahooWeatherAPI();
200		$response = $this->getResponseData();
201		$storeRes = $response;
202
203		$service->setLastResponse(null);
		0 ignored issues – show Documentation introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
204		$response = $service->getLocation();
205		$this->assertSame($response, '');
206
207		$noCity = $storeRes;
208		$noCity['location']['city'] = null;
209		$service->setLastResponse($noCity);
210		$response = $service->getLocation();
211		$this->assertSame($response, '');
212
213
214		$service->setLastResponse($storeRes);
215		$response = $service->getLocation();
216		$city = str_replace(' ', '', $response);
217		$this->assertSame($city, 'TaipeiCity');
218		}
219
220		/** @test */
221		public function getForecastTest()
222		{
223		$service = new YahooWeatherAPI();
224		$response = $this->getResponseData();
225		$storeRes = $response;
226
227		$service->setLastResponse(null);
		0 ignored issues – show Documentation introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
228		$response = $service->getForecast();
229		$this->assertSame(count($response), 0);
230
231		$noForecast = $storeRes;
232		$noForecast['item']['forecast'] = null;
233		$service->setLastResponse($noForecast);
234		$response = $service->getForecast();
235		$this->assertSame(count($response), 0);
236
237		$service->setLastResponse($storeRes);
238		$response = $service->getForecast();
239		$this->assertSame(count($response), 10);
240		}
241
242		/** @test */
243		public function getWindTest()
244		{
245		$service = new YahooWeatherAPI();
246		$response = $this->getResponseData();
247		$storeRes = $response;
248
249		$service->setLastResponse(null);
		0 ignored issues – show Documentation introduced 2016-09-23 16:57 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
250		$response = $service->getWind(true);
251		$this->assertSame(count($response), 0);
252
253		$noSpeed = $storeRes;
254		$noSpeed['wind']['speed'] = null;
255		$service->setLastResponse($noSpeed);
256		$response = $service->getWind(true);
257		$this->assertSame(count($response), 0);
258
259		$service->setLastResponse($storeRes);
260		$expectRes = array(
261		'chill' => $storeRes['wind']['chill'],
262		'direction' => $storeRes['wind']['direction'],
263		'speed' => $storeRes['wind']['speed'],
264		);
265
266		$response = $service->getWind(true);
267		$expectRes['speed'] .= ' '.$storeRes['units']['speed'];
268		$this->assertSame($response['speed'], $expectRes['speed']);
269
270		$expectRes = array(
271		'chill' => $storeRes['wind']['chill'],
272		'direction' => $storeRes['wind']['direction'],
273		'speed' => $storeRes['wind']['speed'],
274		);
275
276		$response = $service->getWind(false);
277		$this->assertSame($response['speed'], $expectRes['speed']);
278		}
279
280		public function getWoeidTest(YahooWeatherAPI $service)
281		{
282		return $service->getWoeid();
283		}
284
285		public function getCityTest(YahooWeatherAPI $service)
286		{
287		return $service->getCity();
288		}
289
290		public function getYqlTest(YahooWeatherAPI $service)
291		{
292		return $service->getYql();
293		}
294
295		public function encodeURI($url)
296		{
297		$unescaped = array(
298		'%2D' => '-', '%5F' => '_', '%2E' => '.', '%21' => '!', '%7E' => '~',
299		'%2A' => '*', '%27' => "'", '%28' => '(', '%29' => ')',
300		);
301		$reserved = array(
302		'%3B' => ';', '%2C' => ',', '%2F' => '/', '%3F' => '?', '%3A' => ':',
303		'%40' => '@', '%26' => '&', '%3D' => '=', '%2B' => '+', '%24' => '$',
304		);
305		$score = array(
306		'%23' => '#',
307		);
308
309		return strtr(rawurlencode($url), array_merge($reserved, $unescaped, $score));
310		}
311
312		public function getResponseData()
313		{
314		$response = file_get_contents('tests/response.json');
315		$response = json_decode($response, true);
316
317		return $response;
318		}
319		}
320

Th3Mouk / YahooWeatherAPI

Pull Request — master (#3)

YahooWeatherClientTests A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

19 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like