Completed
Pull Request — master (#2)
by lee
02:15
created
src/YahooWeatherAPI.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -211,7 +211,7 @@
 block discarded – undo
211 211
     }
212 212
 
213 213
     /**
214
-     * @param GoutteClient $client
214
+     * @param Client $client
215 215
      */
216 216
     public function setClient(Client $client)
217 217
     {
Please login to merge, or discard this patch.
tests/YahooWeatherClientTests.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -302,6 +302,9 @@
 block discarded – undo
302 302
         return $service->getYql();
303 303
     }
304 304
 
305
+    /**
306
+     * @param string $url
307
+     */
305 308
     public function encodeURI($url)
306 309
     {
307 310
         $unescaped = array(
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -139,13 +139,13 @@  discard block
 block discarded – undo
139 139
     {
140 140
         $service = new YahooWeatherAPI();
141 141
         $yql = 'select * from weather.forecast where woeid in (select woeid from geo.places(1) where text="123456789")';
142
-        $url = 'https://query.yahooapis.com/v1/public/yql?q=' . $yql . '&format=json&env=store://datatables.org/alltableswithkeys';
142
+        $url = 'https://query.yahooapis.com/v1/public/yql?q='.$yql.'&format=json&env=store://datatables.org/alltableswithkeys';
143 143
         $url = $this->encodeURI($url);
144 144
         $response = $service->callApi($url);
145 145
         $this->assertSame($response, false);
146 146
 
147 147
         $yql = 'select * from weather.forecast where woeid in (select woeid from geo.places(1) where text="Taipei")';
148
-        $url = 'https://query.yahooapis.com/v1/public/yql?q=' . $yql . '&format=json&env=store://datatables.org/alltableswithkeys';
148
+        $url = 'https://query.yahooapis.com/v1/public/yql?q='.$yql.'&format=json&env=store://datatables.org/alltableswithkeys';
149 149
         $url = $this->encodeURI($url);
150 150
         $response = $service->callApi($url);
151 151
         $city = str_replace(' ', '', $response['location']['city']);
@@ -305,8 +305,8 @@  discard block
 block discarded – undo
305 305
             '%2A' => '*', '%27' => "'", '%28' => '(', '%29' => ')',
306 306
         );
307 307
         $reserved = array(
308
-            '%3B' => ';','%2C' => ',','%2F' => '/','%3F' => '?','%3A' => ':',
309
-            '%40' => '@','%26' => '&','%3D' => '=','%2B' => '+','%24' => '$',
308
+            '%3B' => ';', '%2C' => ',', '%2F' => '/', '%3F' => '?', '%3A' => ':',
309
+            '%40' => '@', '%26' => '&', '%3D' => '=', '%2B' => '+', '%24' => '$',
310 310
         );
311 311
         $score = array(
312 312
             '%23' => '#',
Please login to merge, or discard this patch.