Mpeg4Gif::getMpeg4Height() - Code Metrics - Inspection of "Refactoring article inline type" - TelegramBot/Api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e9eebf...b866da )

by Gusev

created 2016-04-15 00:00 UTC

Mpeg4Gif::getMpeg4Height() A

↳ Parent: Mpeg4Gif

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	4
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace TelegramBot\Api\Types\Inline\QueryResult;

/**
 * Class InlineQueryResultMpeg4Gif
 * Represents a link to a video animation (H.264/MPEG-4 AVC video without sound).
 * By default, this animated MPEG-4 file will be sent by the user with optional caption.
 * Alternatively, you can provide message_text to send it instead of the animation.
 *
 * @package TelegramBot\Api\Types\Inline
 */
class Mpeg4Gif extends AbstractInlineQueryResult

{
    /**
     * {@inheritdoc}
     *
     * @var array
     */
    static protected $requiredParams = ['type', 'id', 'mpeg4_url', 'thumb_url'];

    /**
     * {@inheritdoc}
     *
     * @var array
     */
    static protected $map = [
        'type' => true,
        'id' => true,
        'mpeg4_url' => true,
        'mpeg4_width' => true,
        'mpeg4_height' => true,
        'thumb_url' => true,
        'title' => true,
        'caption' => true,
        'message_text' => true,
        'parse_mode' => true,
        'disable_web_page_preview' => true,
    ];

    /**
     * {@inheritdoc}
     *
     * @var string
     */
    protected $type = 'mpeg4_gif';

    /**
     * A valid URL for the MP4 file. File size must not exceed 1MB
     *
     * @var string
     */
    protected $mpeg4Url;

    /**
     * Optional. Video width
     *
     * @var int
     */
    protected $mpeg4Width;

    /**
     * Optional. Video height
     *
     * @var int
     */
    protected $mpeg4Height;

    /**
     * URL of the static thumbnail (jpeg or gif) for the result
     *
     * @var string
     */
    protected $thumbUrl;

    /**
     * Optional. Caption of the MPEG-4 file to be sent, 0-200 characters
     *
     * @var string
     */
    protected $caption;

    /**
     * InlineQueryResultMpeg4Gif constructor.
     *
     * @param string $id
     * @param string $mpeg4Url
     * @param string $thumbUrl
     * @param int|null $mpeg4Width
     * @param int|null $mpeg4Height
     * @param string|null $caption
     * @param string|null $title
     * @param string|null $messageText
     * @param string|null $parseMode
     * @param bool|null $disableWebPagePreview
     */
    public function __construct(
        $id,
        $mpeg4Url,
        $thumbUrl,
        $mpeg4Width = null,
        $mpeg4Height = null,
        $caption = null,
        $title = null,
        $messageText = null,
        $parseMode = null,
        $disableWebPagePreview = null
    ) {
        parent::__construct($id, $title, $messageText, $parseMode, $disableWebPagePreview);


        $this->mpeg4Url = $mpeg4Url;
        $this->thumbUrl = $thumbUrl;
        $this->mpeg4Width = $mpeg4Width;
        $this->mpeg4Height = $mpeg4Height;
        $this->caption = $caption;
    }


    /**
     * @return string
     */
    public function getMpeg4Url()
    {
        return $this->mpeg4Url;
    }

    /**
     * @param string $mpeg4Url
     */
    public function setMpeg4Url($mpeg4Url)
    {
        $this->mpeg4Url = $mpeg4Url;
    }

    /**
     * @return int
     */
    public function getMpeg4Width()
    {
        return $this->mpeg4Width;
    }

    /**
     * @param int $mpeg4Width
     */
    public function setMpeg4Width($mpeg4Width)
    {
        $this->mpeg4Width = $mpeg4Width;
    }

    /**
     * @return int
     */
    public function getMpeg4Height()
    {
        return $this->mpeg4Height;
    }

    /**
     * @param int $mpeg4Height
     */
    public function setMpeg4Height($mpeg4Height)
    {
        $this->mpeg4Height = $mpeg4Height;
    }

    /**
     * @return string
     */
    public function getThumbUrl()
    {
        return $this->thumbUrl;
    }

    /**
     * @param string $thumbUrl
     */
    public function setThumbUrl($thumbUrl)
    {
        $this->thumbUrl = $thumbUrl;
    }

    /**
     * @return string
     */
    public function getCaption()
    {
        return $this->caption;
    }

    /**
     * @param string $caption
     */
    public function setCaption($caption)
    {
        $this->caption = $caption;
    }
}


1		<?php
2
3		namespace TelegramBot\Api\Types\Inline\QueryResult;
4
5		/**
6		* Class InlineQueryResultMpeg4Gif
7		* Represents a link to a video animation (H.264/MPEG-4 AVC video without sound).
8		* By default, this animated MPEG-4 file will be sent by the user with optional caption.
9		* Alternatively, you can provide message_text to send it instead of the animation.
10		*
11		* @package TelegramBot\Api\Types\Inline
12		*/
13	View Code Duplication	class Mpeg4Gif extends AbstractInlineQueryResult
		0 ignored issues – show Duplication introduced 2016-01-04 23:47 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		{
15		/**
16		* {@inheritdoc}
17		*
18		* @var array
19		*/
20		static protected $requiredParams = ['type', 'id', 'mpeg4_url', 'thumb_url'];
21
22		/**
23		* {@inheritdoc}
24		*
25		* @var array
26		*/
27		static protected $map = [
28		'type' => true,
29		'id' => true,
30		'mpeg4_url' => true,
31		'mpeg4_width' => true,
32		'mpeg4_height' => true,
33		'thumb_url' => true,
34		'title' => true,
35		'caption' => true,
36		'message_text' => true,
37		'parse_mode' => true,
38		'disable_web_page_preview' => true,
39		];
40
41		/**
42		* {@inheritdoc}
43		*
44		* @var string
45		*/
46		protected $type = 'mpeg4_gif';
47
48		/**
49		* A valid URL for the MP4 file. File size must not exceed 1MB
50		*
51		* @var string
52		*/
53		protected $mpeg4Url;
54
55		/**
56		* Optional. Video width
57		*
58		* @var int
59		*/
60		protected $mpeg4Width;
61
62		/**
63		* Optional. Video height
64		*
65		* @var int
66		*/
67		protected $mpeg4Height;
68
69		/**
70		* URL of the static thumbnail (jpeg or gif) for the result
71		*
72		* @var string
73		*/
74		protected $thumbUrl;
75
76		/**
77		* Optional. Caption of the MPEG-4 file to be sent, 0-200 characters
78		*
79		* @var string
80		*/
81		protected $caption;
82
83		/**
84		* InlineQueryResultMpeg4Gif constructor.
85		*
86		* @param string $id
87		* @param string $mpeg4Url
88		* @param string $thumbUrl
89		* @param int\|null $mpeg4Width
90		* @param int\|null $mpeg4Height
91		* @param string\|null $caption
92		* @param string\|null $title
93		* @param string\|null $messageText
94		* @param string\|null $parseMode
95		* @param bool\|null $disableWebPagePreview
96		*/
97		public function __construct(
98		$id,
99		$mpeg4Url,
100		$thumbUrl,
101		$mpeg4Width = null,
102		$mpeg4Height = null,
103		$caption = null,
104		$title = null,
105		$messageText = null,
106		$parseMode = null,
107		$disableWebPagePreview = null
108		) {
109		parent::__construct($id, $title, $messageText, $parseMode, $disableWebPagePreview);
		0 ignored issues – show Bug introduced 2016-04-15 00:03 UTC by Report Bug Copy Issue Report It seems like `$messageText` defined by parameter `$messageText` on line 105 can also be of type `string`; however, `TelegramBot\Api\Types\In...ryResult::__construct()` does only seem to accept `object<TelegramBot\Api\T...putMessageContent>\|null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Bug introduced 2016-04-15 00:03 UTC by Report Bug Copy Issue Report It seems like `$parseMode` defined by parameter `$parseMode` on line 106 can also be of type `string`; however, `TelegramBot\Api\Types\In...ryResult::__construct()` does only seem to accept `object<TelegramBot\Api\T...ineKeyboardMarkup>\|null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Unused Code introduced 2016-04-15 00:03 UTC by Report Bug Copy Issue Report The call to `AbstractInlineQueryResult::__construct()` has too many arguments starting with `$disableWebPagePreview`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
110
111		$this->mpeg4Url = $mpeg4Url;
112		$this->thumbUrl = $thumbUrl;
113		$this->mpeg4Width = $mpeg4Width;
114		$this->mpeg4Height = $mpeg4Height;
115		$this->caption = $caption;
116		}
117
118
119		/**
120		* @return string
121		*/
122		public function getMpeg4Url()
123		{
124		return $this->mpeg4Url;
125		}
126
127		/**
128		* @param string $mpeg4Url
129		*/
130		public function setMpeg4Url($mpeg4Url)
131		{
132		$this->mpeg4Url = $mpeg4Url;
133		}
134
135		/**
136		* @return int
137		*/
138		public function getMpeg4Width()
139		{
140		return $this->mpeg4Width;
141		}
142
143		/**
144		* @param int $mpeg4Width
145		*/
146		public function setMpeg4Width($mpeg4Width)
147		{
148		$this->mpeg4Width = $mpeg4Width;
149		}
150
151		/**
152		* @return int
153		*/
154		public function getMpeg4Height()
155		{
156		return $this->mpeg4Height;
157		}
158
159		/**
160		* @param int $mpeg4Height
161		*/
162		public function setMpeg4Height($mpeg4Height)
163		{
164		$this->mpeg4Height = $mpeg4Height;
165		}
166
167		/**
168		* @return string
169		*/
170		public function getThumbUrl()
171		{
172		return $this->thumbUrl;
173		}
174
175		/**
176		* @param string $thumbUrl
177		*/
178		public function setThumbUrl($thumbUrl)
179		{
180		$this->thumbUrl = $thumbUrl;
181		}
182
183		/**
184		* @return string
185		*/
186		public function getCaption()
187		{
188		return $this->caption;
189		}
190
191		/**
192		* @param string $caption
193		*/
194		public function setCaption($caption)
195		{
196		$this->caption = $caption;
197		}
198		}
199

TelegramBot / Api

Push — master ( e9eebf...b866da )

Mpeg4Gif::getMpeg4Height() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like