Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | View Code Duplication | class VideoNote extends BaseType implements TypeInterface |
|
16 | { |
||
17 | /** |
||
18 | * {@inheritdoc} |
||
19 | * |
||
20 | * @var array |
||
21 | */ |
||
22 | static protected $requiredParams = ['file_id', 'length', 'duration']; |
||
23 | |||
24 | /** |
||
25 | * {@inheritdoc} |
||
26 | * |
||
27 | * @var array |
||
28 | */ |
||
29 | static protected $map = [ |
||
30 | 'file_id' => true, |
||
31 | 'length' => true, |
||
32 | 'duration' => true, |
||
33 | 'thumb' => PhotoSize::class, |
||
34 | 'file_size' => true |
||
35 | ]; |
||
36 | |||
37 | /** |
||
38 | * Unique identifier for this file |
||
39 | * |
||
40 | * @var string |
||
41 | */ |
||
42 | protected $fileId; |
||
43 | |||
44 | /** |
||
45 | * Duration of the video note in seconds as defined by sender |
||
46 | * |
||
47 | * @var int |
||
48 | */ |
||
49 | protected $duration; |
||
50 | |||
51 | /** |
||
52 | * Value of video width and height (diameter of the video message) as defined by sender |
||
53 | * |
||
54 | * @var int |
||
55 | */ |
||
56 | protected $length; |
||
57 | |||
58 | /** |
||
59 | * Video Note thumbnail |
||
60 | * |
||
61 | * @var PhotoSize |
||
62 | */ |
||
63 | protected $thumb; |
||
64 | |||
65 | |||
66 | /** |
||
67 | * Optional. File size |
||
68 | * |
||
69 | * @var int |
||
70 | */ |
||
71 | protected $fileSize; |
||
72 | |||
73 | /** |
||
74 | * @return int |
||
75 | */ |
||
76 | public function getDuration() |
||
80 | |||
81 | /** |
||
82 | * @param int $duration |
||
83 | * |
||
84 | * @throws InvalidArgumentException |
||
85 | */ |
||
86 | public function setDuration($duration) |
||
94 | |||
95 | /** |
||
96 | * @return string |
||
97 | */ |
||
98 | public function getFileId() |
||
102 | |||
103 | /** |
||
104 | * @param string $fileId |
||
105 | */ |
||
106 | public function setFileId($fileId) |
||
110 | |||
111 | /** |
||
112 | * @return int |
||
113 | */ |
||
114 | public function getFileSize() |
||
118 | |||
119 | /** |
||
120 | * @param int $fileSize |
||
121 | * |
||
122 | * @throws InvalidArgumentException |
||
123 | */ |
||
124 | public function setFileSize($fileSize) |
||
132 | |||
133 | /** |
||
134 | * @return int |
||
135 | */ |
||
136 | public function getLength() |
||
140 | |||
141 | /** |
||
142 | * @param int $length |
||
143 | * |
||
144 | * @throws InvalidArgumentException |
||
145 | */ |
||
146 | public function setLength($length) |
||
154 | |||
155 | /** |
||
156 | * @return PhotoSize |
||
157 | */ |
||
158 | public function getThumb() |
||
162 | |||
163 | /** |
||
164 | * @param PhotoSize $thumb |
||
165 | */ |
||
166 | public function setThumb(PhotoSize $thumb) |
||
170 | |||
171 | } |
||
172 |