Completed
Push — master ( 47fcc2...df93ac )
by Christopher
16s
created
src/classes/Controller/NotificationController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 {
12 12
     public function getNotificationClick(ServerRequestInterface $request, ResponseInterface $response, $args)
13 13
     {
14
-        $this->logger->info("Fetch settings GET '/notification/".$args['id']."'");
14
+        $this->logger->info("Fetch settings GET '/notification/" . $args['id'] . "'");
15 15
 
16 16
         $n = NotificationQuery::create()->findPk($args['id']);
17 17
         $click = new NotificationClick();
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 
32 32
                 return $response->withStatus(302)->withHeader('Location', $this->router->pathFor($link['route'], $link['attributes']));
33 33
             } else {
34
-                return $response->withStatus(302)->withHeader('Location', $this->router->pathFor('home').$n->getLink());
34
+                return $response->withStatus(302)->withHeader('Location', $this->router->pathFor('home') . $n->getLink());
35 35
             }
36 36
         }
37 37
 
Please login to merge, or discard this patch.
src/classes/Controller/AvailabilityController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 {
15 15
     public function getAvailabilityForm(ServerRequestInterface $request, ResponseInterface $response, $args)
16 16
     {
17
-        $this->logger->info("Fetch user availability GET '/user/".$args['id']."/availability'");
17
+        $this->logger->info("Fetch user availability GET '/user/" . $args['id'] . "/availability'");
18 18
 
19 19
         $u = UserQuery::create()->findPk($args['id']);
20 20
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 
34 34
     public function postAvailability(ServerRequestInterface $request, ResponseInterface $response, $args)
35 35
     {
36
-        $this->logger->info("Update user availability POST '/user/".$args['id']."/availability'");
36
+        $this->logger->info("Update user availability POST '/user/" . $args['id'] . "/availability'");
37 37
 
38 38
         $u = UserQuery::create()
39 39
             ->findPk($args['id']);
@@ -62,8 +62,8 @@  discard block
 block discarded – undo
62 62
                 $a->setAvailable(false);
63 63
             }
64 64
 
65
-            if (strlen($data['event'.$eventId.'comment']) > 0) {
66
-                $a->setComment($data['event'.$eventId.'comment']);
65
+            if (strlen($data['event' . $eventId . 'comment']) > 0) {
66
+                $a->setComment($data['event' . $eventId . 'comment']);
67 67
             } else {
68 68
                 $a->setComment(null);
69 69
             }
Please login to merge, or discard this patch.
src/classes/Controller/RoleController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 {
14 14
     public function getAssignRolesForm(ServerRequestInterface $request, ResponseInterface $response, $args)
15 15
     {
16
-        $this->logger->info("Fetch user GET '/user/".$args['id']."/roles'");
16
+        $this->logger->info("Fetch user GET '/user/" . $args['id'] . "/roles'");
17 17
         $r = RoleQuery::create()->find();
18 18
         $u = UserQuery::create()->findPK($args['id']);
19 19
 
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 
27 27
     public function postUserAssignRoles(ServerRequestInterface $request, ResponseInterface $response, $args)
28 28
     {
29
-        $this->logger->info("Create user people POST '/user/".$args['id']."/roles'");
29
+        $this->logger->info("Create user people POST '/user/" . $args['id'] . "/roles'");
30 30
 
31 31
         $userId = filter_var($args['id'], FILTER_SANITIZE_NUMBER_INT);
32 32
         $existingRoles = RoleQuery::create()->useUserRoleQuery()->filterByUserId($userId)->endUse()->find();
Please login to merge, or discard this patch.
src/classes/Controller/CalendarController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 
77 77
     public function getRevokeCalendar(ServerRequestInterface $request, ResponseInterface $response, $args)
78 78
     {
79
-        $this->logger->info("Fetch settings GET '/user/me/calendar/".$args['id']."/revoke'");
79
+        $this->logger->info("Fetch settings GET '/user/me/calendar/" . $args['id'] . "/revoke'");
80 80
 
81 81
         $auth = $this->auth;
82 82
         $u = $auth->currentUser();
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 
102 102
     public function getRenderedCalendar(ServerRequestInterface $request, ResponseInterface $response, $args)
103 103
     {
104
-        $this->logger->info("Fetch calendar GET '/calendar/".$args['token'].'.'.$args['format']."'");
104
+        $this->logger->info("Fetch calendar GET '/calendar/" . $args['token'] . '.' . $args['format'] . "'");
105 105
 
106 106
         $c = CalendarTokenQuery::create()
107 107
             ->filterByToken($args['token'])
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
     {
119 119
         $getParameters = $request->getQueryParams();
120 120
 
121
-        $this->logger->info("Fetch -LEGACY- calendar GET '/calendar.php?user=".$getParameters['user'].'&token='.$getParameters['token'].'&format='.$getParameters['format']."'");
121
+        $this->logger->info("Fetch -LEGACY- calendar GET '/calendar.php?user=" . $getParameters['user'] . '&token=' . $getParameters['token'] . '&format=' . $getParameters['format'] . "'");
122 122
 
123 123
         $userId = filter_var($getParameters['user'], FILTER_VALIDATE_INT);
124 124
         $token = $getParameters['token'];
Please login to merge, or discard this patch.
src/classes/EmailAddress.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
         if (filter_var(trim($email), FILTER_VALIDATE_EMAIL)) {
14 14
             $this->email = filter_var(trim($email), FILTER_SANITIZE_EMAIL);
15 15
         } else {
16
-            throw new InvalidArgumentException('Invalid email address: '.$email);
16
+            throw new InvalidArgumentException('Invalid email address: ' . $email);
17 17
         }
18 18
     }
19 19
 
Please login to merge, or discard this patch.
src/middleware.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 // e.g: $app->add(new \Slim\Csrf\Guard);
11 11
 
12 12
 // 3) add route information to twig
13
-$app->add(function (Request $request, Response $response, callable $next) {
13
+$app->add(function(Request $request, Response $response, callable $next) {
14 14
     $route = $request->getAttribute('route');
15 15
 
16 16
     // return NotFound for non existent route
Please login to merge, or discard this patch.
public/old/swap.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 if (!empty($eventId)) {
111 111
     // ensure user is logged in before allowing creation of swap
112 112
     if (!(isset($_SESSION['is_logged_in']) || $_SESSION['db_is_logged_in'] == true)) {
113
-        $_SESSION['redirectUrl'] = siteSettings()->getSiteUrl().'/swap.php?event='.$eventId;
113
+        $_SESSION['redirectUrl'] = siteSettings()->getSiteUrl() . '/swap.php?event=' . $eventId;
114 114
         header('Location: login.php');
115 115
     }
116 116
     $createSwap = true;
@@ -186,11 +186,11 @@  discard block
 block discarded – undo
186 186
             <p>
187 187
               <strong>
188 188
                 <s class="text-red">
189
-                  <?php echo $swap->getOldUserRole()->getUser()->getFirstName().' '.$swap->getOldUserRole()->getUser()->getLastName() ?> (<?php echo $swap->getOldUserRole()->getRole()->getName() ?>)
189
+                  <?php echo $swap->getOldUserRole()->getUser()->getFirstName() . ' ' . $swap->getOldUserRole()->getUser()->getLastName() ?> (<?php echo $swap->getOldUserRole()->getRole()->getName() ?>)
190 190
                 </s>
191 191
                 &#8594;
192 192
                 <span class="text-green">
193
-                  <?php echo $swap->getNewUserRole()->getUser()->getFirstName().' '.$swap->getNewUserRole()->getUser()->getLastName() ?> (<?php echo $swap->getNewUserRole()->getRole()->getName() ?>)
193
+                  <?php echo $swap->getNewUserRole()->getUser()->getFirstName() . ' ' . $swap->getNewUserRole()->getUser()->getLastName() ?> (<?php echo $swap->getNewUserRole()->getRole()->getName() ?>)
194 194
                 </span>
195 195
               </strong>
196 196
             </p>
@@ -225,16 +225,16 @@  discard block
 block discarded – undo
225 225
                 <select name="newUserRole" class="form-control">
226 226
                   <?php
227 227
                   if (roleCanSwapToOtherRoleInGroup($role->roleId)) {
228
-                      $whereAnd = 'r.groupId = '.groupIdWithRole($role->roleId).' AND r.allowRoleSwaps IS NOT FALSE';
228
+                      $whereAnd = 'r.groupId = ' . groupIdWithRole($role->roleId) . ' AND r.allowRoleSwaps IS NOT FALSE';
229 229
                   } else {
230
-                      $whereAnd = 'r.id = '.$role->roleId;
230
+                      $whereAnd = 'r.id = ' . $role->roleId;
231 231
                   }
232
-                  $sql = 'SELECT ur.id, u.firstName, u.lastName, r.name FROM cr_users u INNER JOIN cr_userRoles ur ON ur.userId = u.id INNER JOIN cr_roles r ON r.id = ur.roleId WHERE u.id <> '.$role->userId.' AND '.$whereAnd.' ORDER BY lastName, firstName, r.name';
232
+                  $sql = 'SELECT ur.id, u.firstName, u.lastName, r.name FROM cr_users u INNER JOIN cr_userRoles ur ON ur.userId = u.id INNER JOIN cr_roles r ON r.id = ur.roleId WHERE u.id <> ' . $role->userId . ' AND ' . $whereAnd . ' ORDER BY lastName, firstName, r.name';
233 233
                   $result = mysqli_query(db(), $sql) or die(mysqli_error(db()));
234 234
 
235 235
                   while ($row = mysqli_fetch_array($result, MYSQLI_ASSOC)) {
236 236
                       ?>
237
-                    <option value='<?php echo $row['id']; ?>'><?php echo $row['firstName'].' '.$row['lastName'].' ('.$row['name'].')'; ?></option>
237
+                    <option value='<?php echo $row['id']; ?>'><?php echo $row['firstName'] . ' ' . $row['lastName'] . ' (' . $row['name'] . ')'; ?></option>
238 238
                   <?php
239 239
                   } ?>
240 240
                 </select>
Please login to merge, or discard this patch.
public/old/update.settings.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
     exit;
34 34
 }
35 35
 if (!isAdmin()) {
36
-    header('Location: error.php?no=100&page='.basename($_SERVER['SCRIPT_FILENAME']));
36
+    header('Location: error.php?no=100&page=' . basename($_SERVER['SCRIPT_FILENAME']));
37 37
     exit;
38 38
 }
39 39
 
@@ -57,20 +57,20 @@  discard block
 block discarded – undo
57 57
 if ($action == 'update') {
58 58
     //if ($language='de-de')
59 59
     if ($rowSettings['lang_locale'] == 'en_GB') {
60
-        executeDbSql("update cr_settings set lang_locale = 'de_DE'");                     // de_DE
60
+        executeDbSql("update cr_settings set lang_locale = 'de_DE'"); // de_DE
61 61
             executeDbSql("update cr_settings set time_format_long = '%A, %e. %B %Y, %R Uhr, KW%V'"); // de_DE: %A, %e. %B %Y, %R Uhr, KW%V
62 62
             executeDbSql("update cr_settings set time_format_normal = '%d.%m.%Y %H:%M '"); // de_DE: %d.%m.%Y %H:%M
63
-            executeDbSql("update cr_settings set time_format_short = '%a, <strong>%e. %b</strong>, %R'");              // de_DE: %a, <strong>%e. %b</strong>, KW%V
63
+            executeDbSql("update cr_settings set time_format_short = '%a, <strong>%e. %b</strong>, %R'"); // de_DE: %a, <strong>%e. %b</strong>, KW%V
64 64
             executeDbSql("update cr_settings set time_zone = 'Europe/Berlin'"); //de_DE: Europe/Berlin
65 65
             executeDbSql("update cr_settings set google_group_calendar = ''");
66 66
         executeDbSql("update cr_settings set overviewemail = '{{Gottesdienst-Planung [MONTH] [YEAR]}}\r\nHallo zusammen,\r\n\r\nanbei die Gottesdienst-Planung fuer [MONTH] [YEAR]\r\n\r\n[OVERVIEW]\r\n\r\nBitte fruehzeitig Bescheid geben, wenn etwas NICHT passt, ansonsten gehe ich davon aus, dass ihr wie geplant koennt.\r\n\r\nAlles Gute und Gottes Segen f�r Euch und Euren Dienst.\r\nEuer Gottesdienst Orga-Team'");
67 67
     }
68 68
     //else
69 69
     if ($rowSettings['lang_locale'] == 'de_DE') {
70
-        executeDbSql("update cr_settings set lang_locale = 'en_GB'");                     // de_DE
70
+        executeDbSql("update cr_settings set lang_locale = 'en_GB'"); // de_DE
71 71
             executeDbSql("update cr_settings set time_format_long = '%A, %B %e @ %I:%M %p'"); // de_DE: %A, %e. %B %Y, %R Uhr, KW%V
72 72
             executeDbSql("update cr_settings set time_format_normal = '%m/%d/%y %I:%M %p'"); // de_DE: %d.%m.%Y %H:%M
73
-            executeDbSql("update cr_settings set time_format_short = '%a, <strong>%b %e</strong>, %I:%M %p'");              // de_DE: %a, <strong>%e. %b</strong>, KW%V
73
+            executeDbSql("update cr_settings set time_format_short = '%a, <strong>%b %e</strong>, %I:%M %p'"); // de_DE: %a, <strong>%e. %b</strong>, KW%V
74 74
             executeDbSql("update cr_settings set time_zone = 'Europe/London'"); //de_DE: Europe/Berlin
75 75
             executeDbSql("update cr_settings set google_group_calendar = ''");
76 76
         executeDbSql("update cr_settings set overviewemail = 'Hello,\r\n\r\nIn this email you find the Rota for [MONTH] [YEAR].\r\n\r\n[OVERVIEW]\r\n\r\nPlease inform us as soon as possible, if you are not able to serve as scheduled.\r\n\r\nBe blessed.\r\nChurch Support Stuff'");
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     $resultSettings = mysqli_query(db(), $sqlSettings) or die(mysqli_error(db()));
83 83
     $rowSettings = mysqli_fetch_array($resultSettings, MYSQLI_ASSOC);
84 84
 
85
-    $updateNotification = 'Settings updated successfully to: '.$rowSettings['lang_locale'].' <br>&nbsp;<br>';
85
+    $updateNotification = 'Settings updated successfully to: ' . $rowSettings['lang_locale'] . ' <br>&nbsp;<br>';
86 86
 }
87 87
 
88 88
 $formatting = 'true';
@@ -94,8 +94,8 @@  discard block
 block discarded – undo
94 94
 	<hr>
95 95
 	This page has only beta status. <br>Please do only use it in testing environments!
96 96
 	<hr>
97
-	<?php echo 'Your web browser identifies your language as: '.$language; ?><br>
98
-	<?php echo 'Church Rota is set to use: '.$rowSettings['lang_locale']; ?><br>&nbsp;<br>
97
+	<?php echo 'Your web browser identifies your language as: ' . $language; ?><br>
98
+	<?php echo 'Church Rota is set to use: ' . $rowSettings['lang_locale']; ?><br>&nbsp;<br>
99 99
 	
100 100
 <?php
101 101
 if ($updateNotification == '') {
Please login to merge, or discard this patch.
public/old/createEvent.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 if (($userisBandAdmin) || ($userisEventEditor) || (isAdmin())) {
46 46
     // Just continue the code
47 47
 } else {
48
-    header('Location: error.php?no=100&page='.basename($_SERVER['SCRIPT_FILENAME']));
48
+    header('Location: error.php?no=100&page=' . basename($_SERVER['SCRIPT_FILENAME']));
49 49
 }
50 50
 
51 51
 if ($userisBandAdmin) {
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         $location = $row['location'];
83 83
         $locationname = $row['locationname'];
84 84
         if ($action == 'edit') {
85
-            $formaction = '?action=edit&id='.$id;
85
+            $formaction = '?action=edit&id=' . $id;
86 86
         } else {
87 87
             $formaction = '';
88 88
         }
@@ -139,8 +139,8 @@  discard block
 block discarded – undo
139 139
 
140 140
     // convert format of date
141 141
     $date = str_replace('/', '-', $date); // ensure it isn't read as mm/dd/yyyy
142
-    $date = strftime('%Y-%m-%d', strtotime($date.' 00:00:00'));
143
-    $date = $date.' '.$time.':00';
142
+    $date = strftime('%Y-%m-%d', strtotime($date . ' 00:00:00'));
143
+    $date = $date . ' ' . $time . ':00';
144 144
     $date = mysqli_real_escape_string(db(), $date);
145 145
 
146 146
     if ($action == 'edit') {
@@ -210,10 +210,10 @@  discard block
 block discarded – undo
210 210
         //if ($userisBandAdmin) $delete_all_sql = $delete_all_sql . " and skillID in (select skillID from cr_skills where groupid=2)";
211 211
         //if ($userisEventEditor) $delete_all_sql = $delete_all_sql . " and skillID in (select skillID from cr_skills where groupid!=2)";
212 212
         if ($userisBandAdmin) {
213
-            $delete_all_sql = $delete_all_sql.' and skillID in (select skillID from cr_skills where groupid in (2,3,4))';
213
+            $delete_all_sql = $delete_all_sql . ' and skillID in (select skillID from cr_skills where groupid in (2,3,4))';
214 214
         }
215 215
         if ($userisEventEditor) {
216
-            $delete_all_sql = $delete_all_sql.' and skillID in (select skillID from cr_skills where not (groupid in (2,3,4)))';
216
+            $delete_all_sql = $delete_all_sql . ' and skillID in (select skillID from cr_skills where not (groupid in (2,3,4)))';
217 217
         }
218 218
         mysqli_query(db(), $delete_all_sql) or die(mysqli_error(db()));
219 219
     }
@@ -221,9 +221,9 @@  discard block
 block discarded – undo
221 221
     // redirect
222 222
     if (isset($_SESSION['lastEventsFilter'])) {
223 223
         $type = $_SESSION['lastEventsFilter'];
224
-        header('Location: events.php?view=all&filter='.$type.'#event'.$eventID);
224
+        header('Location: events.php?view=all&filter=' . $type . '#event' . $eventID);
225 225
     } else {
226
-        header('Location: events.php?view=all#event'.$eventID);
226
+        header('Location: events.php?view=all#event' . $eventID);
227 227
     }
228 228
     exit;
229 229
 }
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
                                         while ($ob = mysqli_fetch_object($result)) {
301 301
                                             if (!(isset($type) && $ob->id == $type)) {
302 302
                                                 $defaultTime = strftime('%H:%M', strtotime($ob->defaultTime));
303
-                                                echo "<option value='".$ob->id."' title='".$ob->description."' data-time='".($defaultTime == '00:00' ? '' : $defaultTime)."' data-location='".(is_null($ob->defaultLocationId) ? '' : $ob->defaultLocationId)."'>".$ob->name.'</option>';
303
+                                                echo "<option value='" . $ob->id . "' title='" . $ob->description . "' data-time='" . ($defaultTime == '00:00' ? '' : $defaultTime) . "' data-location='" . (is_null($ob->defaultLocationId) ? '' : $ob->defaultLocationId) . "'>" . $ob->name . '</option>';
304 304
                                             }
305 305
                                         } ?>
306 306
 									</select>
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
                                         while ($row = mysqli_fetch_array($result, MYSQLI_ASSOC)) {
327 327
                                             if (isset($subtype) && $row['id'] == $subtype) {
328 328
                                             } else {
329
-                                                echo "<option value='".$row['id']."' title='".$row['description']."'>".$row['name'].'</option>';
329
+                                                echo "<option value='" . $row['id'] . "' title='" . $row['description'] . "'>" . $row['name'] . '</option>';
330 330
                                             }
331 331
                                         } ?>
332 332
 									</select>
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
                                         while ($row = mysqli_fetch_array($result, MYSQLI_ASSOC)) {
355 355
                                             if (isset($location) && $row['id'] == $location) {
356 356
                                             } else {
357
-                                                echo "<option value='".$row['id']."'>".$row['name'].'</option>';
357
+                                                echo "<option value='" . $row['id'] . "'>" . $row['name'] . '</option>';
358 358
                                             }
359 359
                                         } ?>
360 360
 									</select>
@@ -497,7 +497,7 @@  discard block
 block discarded – undo
497 497
                                     while ($row = mysqli_fetch_array($result, MYSQLI_ASSOC)) {
498 498
                                         if (isset($type) && $row['id'] == $type) {
499 499
                                         } else {
500
-                                            echo "<option value='".$row['id']."' title='".$row['description']."'>".$row['name'].'</option>';
500
+                                            echo "<option value='" . $row['id'] . "' title='" . $row['description'] . "'>" . $row['name'] . '</option>';
501 501
                                         }
502 502
                                     } ?>
503 503
 								</select>
@@ -567,8 +567,8 @@  discard block
 block discarded – undo
567 567
 										<?php foreach ($role->getUserRoles() as $userRole): ?>
568 568
 											<?php if (!$userRole->getReserve()): ?>
569 569
 											<?php $isInEvent = in_array($userRole->getId(), $usersInEvent) ?>
570
-											<option value="<?php echo $userRole->getId() ?>" <?php echo $isInEvent ? 'selected="selected"' : '' ?>><?php echo $userRole->getUser()->getFirstName().' '.$userRole->getUser()->getLastName() ?></option>
571
-											<?php else: ?>
570
+											<option value="<?php echo $userRole->getId() ?>" <?php echo $isInEvent ? 'selected="selected"' : '' ?>><?php echo $userRole->getUser()->getFirstName() . ' ' . $userRole->getUser()->getLastName() ?></option>
571
+											<?php else : ?>
572 572
 											<?php $countReserve += 1 ?>
573 573
 											<?php endif //!userRole->getReserve?>
574 574
 										<?php endforeach //users?>
@@ -578,7 +578,7 @@  discard block
 block discarded – undo
578 578
 										<?php foreach ($role->getUserRoles() as $userRole): ?>
579 579
 											<?php if ($userRole->getReserve()): ?>
580 580
 											<?php $isInEvent = in_array($userRole->getId(), $usersInEvent) ?>
581
-											<option value="<?php echo $userRole->getId() ?>" <?php echo $isInEvent ? 'selected="selected"' : '' ?>><?php echo $userRole->getUser()->getFirstName().' '.$userRole->getUser()->getLastName() ?></option>
581
+											<option value="<?php echo $userRole->getId() ?>" <?php echo $isInEvent ? 'selected="selected"' : '' ?>><?php echo $userRole->getUser()->getFirstName() . ' ' . $userRole->getUser()->getLastName() ?></option>
582 582
 											<?php endif ?>
583 583
 										<?php endforeach //users?>
584 584
 										</optgroup>
Please login to merge, or discard this patch.