Site::getMenu() - Code Metrics - Inspection of "Improved comments, better printable formats & UI t..." - TechWilk/rota - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4cb1ea...24446f )

by Christopher

created 2017-10-07 20:36 UTC

Site::getMenu() A

↳ Parent: Site

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	13
nc	2
nop	0
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0

<?php

namespace TechWilk\Rota;

use DateTime;

class Site
{
    private $settings;
    private $menu;

    public function getSettings()
    {
        if (!isset($this->settings)) {
            $this->settings = SettingsQuery::create()->findOne();
        }

        return $this->settings;
    }

    public function getConfig()
    {
        return getConfig();
    }

    public function getMenu()
    {
        if (!isset($this->menu)) {
            $this->menu['events']['type'] = EventTypeQuery::create()
                ->useEventQuery()
                    ->filterByRemoved(false)
                    ->filterByDate(['min' => new DateTime()])
                ->endUse()
                ->distinct()
                ->find();

            $this->menu['groups'] = GroupQuery::create()
                                        ->distinct()
                                        ->find();
        }

        return $this->menu;
    }

    public function getUrl()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $http = isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) !== 'off' ? 'https' : 'http';
        $hostname = $_SERVER['HTTP_HOST'];

        return [
            'base'     => $http.'://'.$hostname,
            'protocol' => $http,
            'host'     => $hostname,
        ];
    }
}


1			<?php
2
3			namespace TechWilk\Rota;
4
5			use DateTime;
6
7			class Site
8			{
9			private $settings;
10			private $menu;
11
12			public function getSettings()
13			{
14			if (!isset($this->settings)) {
15			$this->settings = SettingsQuery::create()->findOne();
16			}
17
18			return $this->settings;
19			}
20
21			public function getConfig()
22			{
23			return getConfig();
24			}
25
26			public function getMenu()
27			{
28			if (!isset($this->menu)) {
29			$this->menu['events']['type'] = EventTypeQuery::create()
30			->useEventQuery()
31			->filterByRemoved(false)
32			->filterByDate(['min' => new DateTime()])
33			->endUse()
34			->distinct()
35			->find();
36
37			$this->menu['groups'] = GroupQuery::create()
38			->distinct()
39			->find();
40			}
41
42			return $this->menu;
43			}
44
45			public function getUrl()
			0 ignored issues – show Coding Style introduced 2017-08-14 19:15 UTC by Report Bug Copy Issue Report `getUrl` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
46			{
47			$http = isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) !== 'off' ? 'https' : 'http';
48			$hostname = $_SERVER['HTTP_HOST'];
49
50			return [
51			'base' => $http.'://'.$hostname,
52			'protocol' => $http,
53			'host' => $hostname,
54			];
55			}
56			}
57

TechWilk / rota

Push — master ( 4cb1ea...24446f )

Site::getMenu() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like