GroupController::postGroup() - Code Metrics - Inspection of "Basic Group adding/editing" - TechWilk/rota - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#35)

by Christopher

created 2017-10-01 19:09 UTC

GroupController::postGroup() A

↳ Parent: GroupController

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	10
nc	2
nop	3
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0

<?php

namespace TechWilk\Rota\Controller;

use DateTime;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use TechWilk\Rota\EventQuery;
use TechWilk\Rota\Group;
use TechWilk\Rota\GroupQuery;

class GroupController extends BaseController
{
    public function getGroup(ServerRequestInterface $request, ResponseInterface $response, $args)

    {
        $this->logger->info("Fetch group GET '/group/".$args['id']."'");
        $events = EventQuery::create()
            ->useEventPersonQuery()
                ->useUserRoleQuery()
                    ->useRoleQuery()
                        ->filterByGroupId($args['id'])
                    ->endUse()
                ->endUse()
            ->endUse()
            ->filterByDate(['min' => new DateTime()])
            ->filterByRemoved(false)
            ->orderByDate('asc')
            ->distinct()
            ->find();

        $group = GroupQuery::create()
                ->findPk($args['id']);

        return $this->view->render($response, 'group.twig', ['events' => $events, 'group' => $group]);
    }

    public function getGroupRoles(ServerRequestInterface $request, ResponseInterface $response, $args)

    {
        $this->logger->info("Fetch group roles GET '/group/".$args['id']."/roles'");
        $events = EventQuery::create()
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            ->useEventPersonQuery()
                ->useUserRoleQuery()
                    ->useRoleQuery()
                        ->filterByGroupId($args['id'])
                    ->endUse()
                ->endUse()
            ->endUse()
            ->filterByDate(['min' => new DateTime()])
            ->filterByRemoved(false)
            ->orderByDate('asc')
            ->distinct()
            ->find();

        $group = GroupQuery::create()
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                ->useRoleQuery()
                ->endUse()
                ->distinct()
                ->findPk($args['id']);

        // temporary redirect
        return $response->withStatus(302)->withHeader('Location', $this->router->pathFor('home').'old/roles.php');

        return $this->view->render($response, 'group-roles.twig', ['events' => $events, 'group' => $group]);
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    public function postGroup(ServerRequestInterface $request, ResponseInterface $response, $args)
    {
        $this->logger->info("Create/edit group POST '/group/".$args['id']."'");

        $group = new Group();

        if (!empty($args['id'])) {
            $group = GroupQuery::create()->findPk($args['id']);
        }

        $data = $request->getParsedBody();

        $group->setName($data['name']);
        $group->setDescription($data['description']);
        $group->save();

        return $response->withStatus(302)->withHeader('Location', $this->router->pathFor('group', ['id' => $group->getId()]));
    }
}


1			<?php
2
3			namespace TechWilk\Rota\Controller;
4
5			use DateTime;
6			use Psr\Http\Message\ResponseInterface;
7			use Psr\Http\Message\ServerRequestInterface;
8			use TechWilk\Rota\EventQuery;
9			use TechWilk\Rota\Group;
10			use TechWilk\Rota\GroupQuery;
11
12			class GroupController extends BaseController
13			{
14			public function getGroup(ServerRequestInterface $request, ResponseInterface $response, $args)
			0 ignored issues – show Unused Code introduced 2017-10-01 14:50 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
15			{
16			$this->logger->info("Fetch group GET '/group/".$args['id']."'");
17			$events = EventQuery::create()
18			->useEventPersonQuery()
19			->useUserRoleQuery()
20			->useRoleQuery()
21			->filterByGroupId($args['id'])
22			->endUse()
23			->endUse()
24			->endUse()
25			->filterByDate(['min' => new DateTime()])
26			->filterByRemoved(false)
27			->orderByDate('asc')
28			->distinct()
29			->find();
30
31			$group = GroupQuery::create()
32			->findPk($args['id']);
33
34			return $this->view->render($response, 'group.twig', ['events' => $events, 'group' => $group]);
35			}
36
37			public function getGroupRoles(ServerRequestInterface $request, ResponseInterface $response, $args)
			0 ignored issues – show Unused Code introduced 2017-10-01 14:50 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
38			{
39			$this->logger->info("Fetch group roles GET '/group/".$args['id']."/roles'");
40			$events = EventQuery::create()
			0 ignored issues – show Unused Code introduced 2017-10-01 14:50 UTC by Report Bug Copy Issue Report `$events` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
41			->useEventPersonQuery()
42			->useUserRoleQuery()
43			->useRoleQuery()
44			->filterByGroupId($args['id'])
45			->endUse()
46			->endUse()
47			->endUse()
48			->filterByDate(['min' => new DateTime()])
49			->filterByRemoved(false)
50			->orderByDate('asc')
51			->distinct()
52			->find();
53
54			$group = GroupQuery::create()
			0 ignored issues – show Unused Code introduced 2017-10-01 14:50 UTC by Report Bug Copy Issue Report `$group` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55			->useRoleQuery()
56			->endUse()
57			->distinct()
58			->findPk($args['id']);
59
60			// temporary redirect
61			return $response->withStatus(302)->withHeader('Location', $this->router->pathFor('home').'old/roles.php');
62
63			return $this->view->render($response, 'group-roles.twig', ['events' => $events, 'group' => $group]);
			0 ignored issues – show Unused Code introduced 2017-10-01 14:50 UTC by Report Bug Copy Issue Report `return $this->view->rend...s, 'group' => $group));` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
64			}
65
66			public function postGroup(ServerRequestInterface $request, ResponseInterface $response, $args)
67			{
68			$this->logger->info("Create/edit group POST '/group/".$args['id']."'");
69
70			$group = new Group();
71
72			if (!empty($args['id'])) {
73			$group = GroupQuery::create()->findPk($args['id']);
74			}
75
76			$data = $request->getParsedBody();
77
78			$group->setName($data['name']);
79			$group->setDescription($data['description']);
80			$group->save();
81
82			return $response->withStatus(302)->withHeader('Location', $this->router->pathFor('group', ['id' => $group->getId()]));
83			}
84			}
85

TechWilk / rota

Pull Request — master (#35)

GroupController::postGroup() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like