Completed
Pull Request — master (#140)
by Christopher
06:22
created
public/old/includes/functions.database.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace TechWilk\Rota;
4 4
 
5
-use DateTime;
6
-
7 5
 /*
8 6
     This file is part of Church Rota.
9 7
 
Please login to merge, or discard this patch.
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -26,14 +26,14 @@  discard block
 block discarded – undo
26 26
 function executeDbSql($sql)
27 27
 {
28 28
     if (!mysqli_query(db(), $sql)) {
29
-        die('Error: '.mysqli_error(db()).', SQL: '.$sql);
29
+        die('Error: ' . mysqli_error(db()) . ', SQL: ' . $sql);
30 30
     }
31 31
 }
32 32
 
33 33
 function updateDatabase()
34 34
 {
35 35
     $sql = 'SELECT VERSION( ) AS mysqli_version';
36
-    $result = mysqli_query(db(), $sql) or die('MySQL-Error: '.mysqli_error(db()));
36
+    $result = mysqli_query(db(), $sql) or die('MySQL-Error: ' . mysqli_error(db()));
37 37
     $dbv = mysqli_fetch_array($result, MYSQLI_ASSOC);
38 38
     $mysqli_version = $dbv['mysqli_version'];
39 39
     //echo $mysqli_version."<br>";
@@ -87,41 +87,41 @@  discard block
 block discarded – undo
87 87
             executeDbSql("alter table users add(isOverviewRecipient char(2) NOT NULL DEFAULT '0')");
88 88
             executeDbSql('alter table groups add(short_name char(2))');
89 89
 
90
-            executeDbSql("update settings set lang_locale = 'en_GB'");                     // de_DE
90
+            executeDbSql("update settings set lang_locale = 'en_GB'"); // de_DE
91 91
             executeDbSql('update settings set event_sorting_latest = 0');
92 92
             executeDbSql('update settings set snapshot_show_two_month = 0');
93 93
             executeDbSql('update settings set snapshot_reduce_skills_by_group = 0');
94 94
             executeDbSql('update settings set logged_in_show_snapshot_button = 0');
95 95
             executeDbSql("update settings set time_format_long = '%A, %B %e @ %I:%M %p'"); // de_DE: %A, %e. %B %Y, %R Uhr, KW%V
96 96
             executeDbSql("update settings set time_format_normal = '%m/%d/%y %I:%M %p'"); // de_DE: %d.%m.%Y %H:%M
97
-            executeDbSql("update settings set time_format_short = '%a, <strong>%b %e</strong>, %I:%M %p'");              // de_DE: %a, <strong>%e. %b</strong>, KW%V
97
+            executeDbSql("update settings set time_format_short = '%a, <strong>%b %e</strong>, %I:%M %p'"); // de_DE: %a, <strong>%e. %b</strong>, KW%V
98 98
             executeDbSql("update settings set version = '2.1.0'");
99 99
             executeDbSql('update settings set users_start_with_myevents = 0');
100 100
             executeDbSql("update settings set time_zone = 'Europe/London'"); //de_DE: Europe/Berlin
101 101
             executeDbSql("update settings set google_group_calendar = ''");
102 102
             executeDbSql("update settings set overviewemail = 'Hello,\r\n\r\nIn this email you find the Rota for [MONTH] [YEAR].\r\n\r\n[OVERVIEW]\r\n\r\nPlease inform us as soon as possible, if you are not able to serve as scheduled.\r\n\r\nBe blessed.\r\nChurch Support Stuff'");
103 103
 
104
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.1.0', $_SESSION['userid']);
104
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.1.0', $_SESSION['userid']);
105 105
         case '2.1.0':
106 106
             executeDbSql('create table settings_bkp2_1_0 as select * from settings');
107 107
             executeDbSql('alter table settings add(group_sorting_name int(1))');
108 108
             executeDbSql("update settings set version = '2.1.1'");
109
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.1.1', $_SESSION['userid']);
109
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.1.1', $_SESSION['userid']);
110 110
         case '2.1.1':
111 111
             executeDbSql("update settings set version = '2.1.2'");
112
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.1.2', $_SESSION['userid']);
112
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.1.2', $_SESSION['userid']);
113 113
         case '2.1.2':
114 114
             executeDbSql("alter table settings add(debug_mode int(1) DEFAULT '0')");
115
-            executeDbSql('update settings set group_sorting_name = 0');  //was a workaround, fixed in V2.2.1
115
+            executeDbSql('update settings set group_sorting_name = 0'); //was a workaround, fixed in V2.2.1
116 116
 
117 117
             executeDbSql("update settings set version = '2.2.0'");
118
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.2.0', $_SESSION['userid']);
118
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.2.0', $_SESSION['userid']);
119 119
         case '2.2.0':
120 120
             executeDbSql("alter table users add(isBandAdmin char(2) NOT NULL DEFAULT '0')");
121 121
             executeDbSql('update settings set group_sorting_name = 0'); //due to an error reset it again
122 122
 
123 123
             executeDbSql("update settings set version = '2.2.1'");
124
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.2.1', $_SESSION['userid']);
124
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.2.1', $_SESSION['userid']);
125 125
         case '2.2.1':
126 126
                 $sql = "CREATE TABLE IF NOT EXISTS `statistics` (
127 127
 				  `id` int(11) NOT NULL AUTO_INCREMENT,
@@ -137,21 +137,21 @@  discard block
 block discarded – undo
137 137
             executeDbSql($sql);
138 138
 
139 139
             executeDbSql("update settings set version = '2.3.0'");
140
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.3.0', $_SESSION['userid']);
140
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.3.0', $_SESSION['userid']);
141 141
             insertStatistics('system', __FILE__, 'db-update', '2.3.0', $version);
142 142
         case '2.3.0':
143 143
             executeDbSql("alter table users add(isEventEditor char(2) NOT NULL DEFAULT '0')");
144 144
 
145 145
             executeDbSql("update settings set version = '2.3.1'");
146
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.3.1', $_SESSION['userid']);
146
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.3.1', $_SESSION['userid']);
147 147
             insertStatistics('system', __FILE__, 'db-update', '2.3.1', $version);
148 148
         case '2.3.1':
149 149
             executeDbSql("update settings set version = '2.3.2'");
150
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.3.2', $_SESSION['userid']);
150
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.3.2', $_SESSION['userid']);
151 151
             insertStatistics('system', __FILE__, 'db-update', '2.3.2', $version);
152 152
         case '2.3.2':
153 153
             executeDbSql("update settings set version = '2.3.3'");
154
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.3.3', $_SESSION['userid']);
154
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.3.3', $_SESSION['userid']);
155 155
             insertStatistics('system', __FILE__, 'db-update', '2.3.3', $version);
156 156
         case '2.3.3':
157 157
             if (substr($mysqli_version, 0, 1) == 5) {
@@ -199,33 +199,33 @@  discard block
 block discarded – undo
199 199
                     );
200 200
             }
201 201
             executeDbSql("update settings set version = '2.3.4'");
202
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.3.4', $_SESSION['userid']);
202
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.3.4', $_SESSION['userid']);
203 203
             insertStatistics('system', __FILE__, 'db-update', '2.3.4', $version);
204 204
         case '2.3.4':
205 205
             executeDbSql("update settings set version = '2.3.5'");
206
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.3.5', $_SESSION['userid']);
206
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.3.5', $_SESSION['userid']);
207 207
             insertStatistics('system', __FILE__, 'db-update', '2.3.5', $version);
208 208
         case '2.3.5':
209 209
             executeDbSql("update settings set version = '2.4.0'");
210
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.4.0', $_SESSION['userid']);
210
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.4.0', $_SESSION['userid']);
211 211
             insertStatistics('system', __FILE__, 'db-update', '2.4.0', $version);
212 212
         case '2.4.0':
213 213
             executeDbSql("update settings set version = '2.4.1'");
214
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.4.1', $_SESSION['userid']);
214
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.4.1', $_SESSION['userid']);
215 215
             insertStatistics('system', __FILE__, 'db-update', '2.4.1', $version);
216 216
         case '2.4.1':
217 217
             executeDbSql('alter table settings add(days_to_alert int(2) DEFAULT 5) ');
218 218
             executeDbSql("alter table settings add(token varchar(100) DEFAULT '') ");
219 219
             executeDbSql("update settings set version = '2.4.2'");
220
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.4.2', $_SESSION['userid']);
220
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.4.2', $_SESSION['userid']);
221 221
             insertStatistics('system', __FILE__, 'db-update', '2.4.2', $version);
222 222
         case '2.4.2':
223 223
             executeDbSql("update settings set version = '2.4.3'");
224
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.4.3', $_SESSION['userid']);
224
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.4.3', $_SESSION['userid']);
225 225
             insertStatistics('system', __FILE__, 'db-update', '2.4.3', $version);
226 226
         case '2.4.3':
227 227
             executeDbSql("update settings set version = '2.4.4'");
228
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.4.4', $_SESSION['userid']);
228
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.4.4', $_SESSION['userid']);
229 229
             insertStatistics('system', __FILE__, 'db-update', '2.4.4', $version);
230 230
         case '2.4.4':
231 231
             if (substr($mysqli_version, 0, 1) == 5) {
@@ -274,27 +274,27 @@  discard block
 block discarded – undo
274 274
                 );
275 275
             }
276 276
             executeDbSql("update settings set version = '2.4.5'");
277
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.4.5', $_SESSION['userid']);
277
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.4.5', $_SESSION['userid']);
278 278
             insertStatistics('system', __FILE__, 'db-update', '2.4.5', $version);
279 279
         case '2.4.5':
280 280
             executeDbSql("update settings set version = '2.5.0'");
281
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.5.0', $_SESSION['userid']);
281
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.5.0', $_SESSION['userid']);
282 282
             insertStatistics('system', __FILE__, 'db-update', '2.5.0', $version);
283 283
         case '2.5.0':
284 284
             executeDbSql("update settings set version = '2.5.1'");
285
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.5.1', $_SESSION['userid']);
285
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.5.1', $_SESSION['userid']);
286 286
             insertStatistics('system', __FILE__, 'db-update', '2.5.1', $version);
287 287
         case '2.5.1':
288 288
             executeDbSql("update settings set version = '2.5.2'");
289
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.5.2', $_SESSION['userid']);
289
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.5.2', $_SESSION['userid']);
290 290
             insertStatistics('system', __FILE__, 'db-update', '2.5.2', $version);
291 291
         case '2.5.2':
292 292
             executeDbSql("update settings set version = '2.5.3'");
293
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.5.3', $_SESSION['userid']);
293
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.5.3', $_SESSION['userid']);
294 294
             insertStatistics('system', __FILE__, 'db-update', '2.5.3', $version);
295 295
         case '2.5.3':
296 296
             executeDbSql("update settings set version = '2.6.0'");
297
-            notifyInfo(__FILE__, 'db-update='.$version.'->2.6.0', $_SESSION['userid']);
297
+            notifyInfo(__FILE__, 'db-update=' . $version . '->2.6.0', $_SESSION['userid']);
298 298
             insertStatistics('system', __FILE__, 'db-update', '2.6.0', $version);
299 299
         case '2.6.0':
300 300
             $sql = "ALTER TABLE users
@@ -370,7 +370,7 @@  discard block
 block discarded – undo
370 370
             executeDbSql($sql);
371 371
             executeDbSql("update settings set version = '3.0.0-pre1'");
372 372
 
373
-            notifyInfo(__FILE__, 'db-update='.$version.'->3.0.0-pre1', $_SESSION['userid']);
373
+            notifyInfo(__FILE__, 'db-update=' . $version . '->3.0.0-pre1', $_SESSION['userid']);
374 374
             insertStatistics('system', __FILE__, 'db-update', '3.0.0-pre1', $version);
375 375
         case '3.0.0-pre1':
376 376
             $sql = "CREATE TABLE IF NOT EXISTS notifications (
Please login to merge, or discard this patch.
public/plugins/datatables/extensions/Scroller/examples/data/ssp.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -29,11 +29,11 @@
 block discarded – undo
29 29
 // parameter represents the DataTables column identifier. In this case simple
30 30
 // indexes
31 31
 $columns = [
32
-    ['db' => 'id',         'dt' => 0],
33
-    ['db' => 'firstname',  'dt' => 1],
34
-    ['db' => 'surname',    'dt' => 2],
35
-    ['db' => 'zip',        'dt' => 3],
36
-    ['db' => 'country',    'dt' => 4],
32
+    ['db' => 'id', 'dt' => 0],
33
+    ['db' => 'firstname', 'dt' => 1],
34
+    ['db' => 'surname', 'dt' => 2],
35
+    ['db' => 'zip', 'dt' => 3],
36
+    ['db' => 'country', 'dt' => 4],
37 37
 ];
38 38
 
39 39
 // SQL server connection information
Please login to merge, or discard this patch.
public/old/swaps.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 // ensure user is allowed to see page
40 40
 
41 41
 if (!isAdmin() && $queryStringUser != $sessionUserId) {
42
-    header('Location: swaps.php?user='.$sessionUserId);
42
+    header('Location: swaps.php?user=' . $sessionUserId);
43 43
 }
44 44
 
45 45
 // fetch swaps
@@ -90,11 +90,11 @@  discard block
 block discarded – undo
90 90
               <p>
91 91
                 <strong>
92 92
                   <s class="text-red">
93
-                    <?php echo $swap->getOldUserRole()->getUser()->getFirstName().' '.$swap->getOldUserRole()->getUser()->getLastName() ?> (<?php echo $swap->getOldUserRole()->getRole()->getName() ?>)
93
+                    <?php echo $swap->getOldUserRole()->getUser()->getFirstName() . ' ' . $swap->getOldUserRole()->getUser()->getLastName() ?> (<?php echo $swap->getOldUserRole()->getRole()->getName() ?>)
94 94
                   </s>
95 95
                   &#8594;
96 96
                   <span class="text-green">
97
-                    <?php echo $swap->getNewUserRole()->getUser()->getFirstName().' '.$swap->getNewUserRole()->getUser()->getLastName() ?> (<?php echo $swap->getNewUserRole()->getRole()->getName() ?>)
97
+                    <?php echo $swap->getNewUserRole()->getUser()->getFirstName() . ' ' . $swap->getNewUserRole()->getUser()->getLastName() ?> (<?php echo $swap->getNewUserRole()->getRole()->getName() ?>)
98 98
                   </span>
99 99
                 </strong>
100 100
               </p>
Please login to merge, or discard this patch.
public/old/overview.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
     exit;
34 34
 }
35 35
 if (!isAdmin()) {
36
-    header('Location: error.php?no=100&page='.basename($_SERVER['SCRIPT_FILENAME']));
36
+    header('Location: error.php?no=100&page=' . basename($_SERVER['SCRIPT_FILENAME']));
37 37
     exit;
38 38
 }
39 39
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 
116 116
 		  <?php
117 117
             else:
118
-                echo '<div class="box-body">'.$sentSuccess.'</div>';
118
+                echo '<div class="box-body">' . $sentSuccess . '</div>';
119 119
             endif;
120 120
             ?>
121 121
 				</div>
Please login to merge, or discard this patch.
public/old/emailGroup.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
         $statusMessage = 'Sent successfully';
54 54
     } else {
55 55
         foreach ($sent as $errorMessage) {
56
-            $statusMessage .= '<p>'.$errorMessage.'</p>';
56
+            $statusMessage .= '<p>' . $errorMessage . '</p>';
57 57
         }
58 58
     }
59 59
 
Please login to merge, or discard this patch.
public/old/editRole.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
 }
35 35
 
36 36
 if (!isAdmin()) {
37
-    header('Location: error.php?no=100&page='.basename($_SERVER['SCRIPT_FILENAME']));
37
+    header('Location: error.php?no=100&page=' . basename($_SERVER['SCRIPT_FILENAME']));
38 38
     exit;
39 39
 }
40 40
 
Please login to merge, or discard this patch.
public/old/editeventtype.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
     exit;
15 15
 }
16 16
 if (!isAdmin()) {
17
-    header('Location: error.php?no=100&page='.basename($_SERVER['SCRIPT_FILENAME']));
17
+    header('Location: error.php?no=100&page=' . basename($_SERVER['SCRIPT_FILENAME']));
18 18
     exit;
19 19
 }
20 20
 
Please login to merge, or discard this patch.
public/old/pendingAccounts.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
     exit;
15 15
 }
16 16
 if (!isAdmin()) {
17
-    header('Location: error.php?no=100&page='.basename($_SERVER['SCRIPT_FILENAME']));
17
+    header('Location: error.php?no=100&page=' . basename($_SERVER['SCRIPT_FILENAME']));
18 18
     exit;
19 19
 }
20 20
 
@@ -31,14 +31,14 @@  discard block
 block discarded – undo
31 31
     case 'approve':
32 32
       $userId = approvePendingUser($id);
33 33
       mailNewUser($userId);
34
-      header('Location: addUser.php?action=edit&user='.$userId);
34
+      header('Location: addUser.php?action=edit&user=' . $userId);
35 35
       break;
36 36
     case 'merge':
37 37
       $existingUserId = $_POST['existingUser'];
38 38
       $existingUserId = filter_var($existingUserId, FILTER_SANITIZE_NUMBER_INT);
39 39
       mergePendingUserWithUserId($id, $existingUserId);
40 40
       mailNewUser($existingUserId);
41
-      header('Location: addUser.php?action=edit&user='.$existingUserId);
41
+      header('Location: addUser.php?action=edit&user=' . $existingUserId);
42 42
       break;
43 43
     case 'decline':
44 44
       declinePendingUser($id);
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 <div class="box box-primary">
91 91
   <div class="box-header">
92 92
     <h2 class="box-title">
93
-      <?php echo $user->approved ? 'Approved' : ($user->declined ? 'Declined' : 'Pending') ?>: <?php echo $user->firstName.' '.$user->lastName ?>
93
+      <?php echo $user->approved ? 'Approved' : ($user->declined ? 'Declined' : 'Pending') ?>: <?php echo $user->firstName . ' ' . $user->lastName ?>
94 94
     </h2>
95 95
   </div>
96 96
   <div class="box-body">
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
             <?php
132 132
             $users = allUsersNames();
133 133
             foreach ($users as $existingUser): ?>
134
-            <option value="<?php echo $existingUser->id?>" <?php echo($existingUser->firstName == $user->firstName) && ($existingUser->lastName == $user->lastName) ? "selected='selected'" : '' ?>><?php echo $existingUser->firstName.' '.$existingUser->lastName ?></option>
134
+            <option value="<?php echo $existingUser->id?>" <?php echo($existingUser->firstName == $user->firstName) && ($existingUser->lastName == $user->lastName) ? "selected='selected'" : '' ?>><?php echo $existingUser->firstName . ' ' . $existingUser->lastName ?></option>
135 135
             <?php endforeach; ?>
136 136
           </select>
137 137
         </div>
Please login to merge, or discard this patch.
public/old/includes/errors.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,6 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace TechWilk\Rota;
4 4
 
5
-ini_set('display_errors', false);    // set on for development, off for production
5
+ini_set('display_errors', false); // set on for development, off for production
6 6
 ini_set('log_errors', true);
7 7
 error_reporting(E_ALL);
Please login to merge, or discard this patch.