Authentication::verifyCallback() - Code Metrics - Inspection of "Fix Facebook Auth" - TechWilk/rota - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#24)

by Christopher
created 2017-09-30 22:19 UTC
Authentication::verifyCallback() B

↳ Parent: Authentication
Complexity

Conditions	4
Paths	4
Size

Total Lines	24
Code Lines	14
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	4
eloc	14
c	0
b	0
f	0
nc	4
nop	1
dl	0
loc	24
rs	8.6845
<?php

namespace TechWilk\Rota;

use DateTime;
use DateTimeZone;
use Exception;
use Psr\Container\ContainerInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use TechWilk\Rota\AuthProvider\CallbackInterface;
use TechWilk\Rota\AuthProvider\UsernamePasswordInterface;
use TechWilk\Rota\Exception\UnknownUserException;

class Authentication
{
    protected $container;
    protected $authProvider;
    protected $routesWhitelist;

    public function __construct(ContainerInterface $container, AuthProviderInterface $authProvider, $routesWhitelist)
    {
        $this->container = $container;
        $this->authProvider = $authProvider;
        $this->routesWhitelist = $routesWhitelist;
    }

    public function __invoke(ServerRequestInterface $request, ResponseInterface $response, callable $next)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        /* Skip auth if uri is whitelisted. */
        if ($this->uriInWhitelist($request)) {
            $response = $next($request, $response);

            return $response;
        }

        if ($this->isUserLoggedIn()) {
            $response = $next($request, $response);
        } else {
            $_SESSION['urlRedirect'] = strval($request->getUri());
            $router = $this->container->get('router');

            return $response->withStatus(302)->withHeader('Location', $router->pathFor('login'));
        }

        return $response;
    }

    private function uriInWhitelist(ServerRequestInterface $request)
    {
        $route = $request->getAttribute('route');
        if (!isset($route)) {
            return false;
        }

        return in_array($route->getName(), $this->routesWhitelist);
    }

    public function isUserLoggedIn()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return isset($_SESSION['userId']);
    }

    public function loginAttempt(EmailAddress $email, $password)
    {
        if (!$this->numberOfLoginAttemptsIsOk($email)) {
            throw new Exception('Too many attempts.');
            return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }

        if ($this->authProvider->checkCredentials($email, $password) !== true) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $this->logFailedLoginAttempt($email);

            return false;
        }

        switch ($this->authProvider->getAuthProviderSlug()) {
            case 'onebody':
                if (is_null($this->authProvider->getUserId())) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    return false;
                }
                $socialAuth = SocialAuthQuery::create()
                    ->filterByPlatform($this->authProvider->getAuthProviderSlug())
                    ->filterBySocialId($this->authProvider->getUserId())
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    ->filterByRevoked(false)
                    ->findOne();
                if (is_null($socialAuth)) {
                    $user = UserQuery::create()->filterByEmail($email)->findOne();
                    if (!is_null($user)) {
                        $socialAuth = new SocialAuth();
                        $socialAuth->setUser($user);
                        $socialAuth->setPlatform('onebody');
                        $socialAuth->setSocialId($this->authProvider->getUserId());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    }
                }
                if (!is_null($socialAuth)) {
                    $socialAuth->setMeta($this->authProvider->getMeta());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    $socialAuth->save();
                    $user = $socialAuth->getUser();
                }
            break;
            default:
                $user = UserQuery::create()->filterByEmail($email)->findOne();
            break;
        }

        return $this->loginSuccess($user);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    private function loginSuccess(User $user)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (is_null($user)) {
            throw new UnknownUserException('User not found in the database.');
        }

        $_SESSION['userId'] = $user->getId();
        $user->setLastLogin(new DateTime());
        $user->save();

        return true;
    }

    private function numberOfLoginAttemptsIsOk($username)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $numberOfAllowedAttempts = 8;
        $lockOutInterval = 15; // mins

        $date = new DateTime("-$lockOutInterval minutes");
        $date->setTimezone(new DateTimeZone('UTC'));

        // check ip address
        if (isset($_SERVER['REMOTE_ADDR'])) {
            $loginFailures = LoginFailureQuery::create()
                ->filterByIpAddress($_SERVER['REMOTE_ADDR'])
                ->filterByTimestamp(['min' => $date])
                ->count();

            if ($loginFailures >= $numberOfAllowedAttempts) {
                $this->logFailedLoginAttempt($username);

                return false;
            }
        }

        // check user account
        $loginFailures = LoginFailureQuery::create()
            ->filterByUsername($username)
            ->filterByTimestamp(['min' => $date])
            ->count();

        if ($loginFailures >= $numberOfAllowedAttempts) {
            $this->logFailedLoginAttempt($username);

            return false;
        }

        return true;
    }

    private function logFailedLoginAttempt($username)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $f = new LoginFailure();
        $f->setUsername($username);
        $ip = isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : '0.0.0.0';
        $f->setIpAddress($ip);
        $f->save();
    }

    public function currentUser()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $userId = $_SESSION['userId'];

        return UserQuery::create()->findPK($userId);
    }

    public function getResetPasswordUrl()
    {
        if ($this->authProvider instanceof UsernamePasswordInterface) {
            return $this->authProvider->getResetPasswordUrl();
        }

        return '';
    }

    public function getCallbackUrl()
    {
        return $this->authProvider->getCallbackUrl();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function verifyCallback($args)
    {
        if ($this->authProvider->verifyCallback($args)) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            switch ($this->authProvider->getAuthProviderSlug()) {
                case 'facebook':
                    $socialAuth = SocialAuthQuery::create()
                        ->filterByPlatform($this->authProvider->getAuthProviderSlug())
                        ->filterBySocialId($this->authProvider->getUserId())
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                        ->filterByRevoked(false)
                        ->findOne();

                    if (!is_null($socialAuth)) {
                        //$socialAuth->setMeta($this->authProvider->getMeta());

                        //$socialAuth->save();

                        $user = $socialAuth->getUser();
                    }
                break;
            }

            return $this->loginSuccess($user);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        return false;
    }

    public function getAuthProviderSlug()
    {
        return $this->authProvider->getAuthProviderSlug();
    }

    public function isCallback()
    {
        return $this->authProvider instanceof CallbackInterface;
    }

    public function isCredential()
    {
        return $this->authProvider instanceof UsernamePasswordInterface;
    }

    public function getSocialUserId()
    {
        return $this->authProvider->getUserId();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getMeta()
    {
        return $this->authProvider->getMeta();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}

Pull Request — master (#24)

Authentication::verifyCallback() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

TechWilk / rota

Pull Request — master (#24)

Authentication::verifyCallback() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
