TechWilk / rota

api-classes/Database.php

Doc Comments +11 added lines

@@ -148,6 +148,12 @@ 
         return $statement->fetchAll(PDO::FETCH_CLASS, $returnClass);
     }
 
+    /**
+     * @param string $returnClass
+     * @param string $table
+     * @param string[] $columns
+     * @param string[] $where
+     */
     public function selectSingle($returnClass, $table, $columns, $where = null)
     {
         $statement = $this->selectStatement($table, $columns, $where);
@@ -215,6 +221,8 @@ 
 
   /**
    * Use with caution: it is often better to archive items to prevent creating null references.
+   * @param string $table
+   * @param string[] $where
    */
   public function delete($table, $where)
   {
@@ -253,6 +261,9 @@ 
         return $table;
     }
 
+    /**
+     * @param string $table
+     */
     private function tableExists($table)
     {
         // todo: implement table check

generated-classes/TechWilk/Rota/User.php

Doc Comments +1 added lines, -1 removed lines

@@ -196,7 +196,7 @@
     /**
      * Determine if the user is marked as available for an event.
      *
-     * @return bool if user is available
+     * @return null|boolean if user is available
      */
     public function isAvailableForEvent(Event $event)
     {

src/classes/Authentication.php

Doc Comments +3 added lines

@@ -119,6 +119,9 @@
         return true;
     }
 
+    /**
+     * @param EmailAddress $username
+     */
     private function numberOfLoginAttemptsIsOk($username)
     {
         $numberOfAllowedAttempts = 8;

public/old/swap.php

Switch Indentation +24 added lines, -24 removed lines

@@ -64,21 +64,21 @@ 
   case 'accept':
     if (canAcceptSwap($swapId) || $verify == verificationCodeForSwap($swapId)) {
         switch (acceptSwap($swapId)) {
-        case '1':
-          $message = 'Swap Successful';
-          break;
-        case '2':
-          $message = 'Swap already accepted.';
-          break;
-        case '3':
-          $message = 'Swap already declined.';
-          break;
-        case '4':
-          $message = 'Swap already reverted.';
-          break;
-        default:
-          $err = 'Technical issue - please inform system administrator';
-          break;
+            case '1':
+              $message = 'Swap Successful';
+              break;
+            case '2':
+              $message = 'Swap already accepted.';
+              break;
+            case '3':
+              $message = 'Swap already declined.';
+              break;
+            case '4':
+              $message = 'Swap already reverted.';
+              break;
+            default:
+              $err = 'Technical issue - please inform system administrator';
+              break;
       }
     } else {
         $err = 'Swap Already Actioned or Verification Code Invalid';
@@ -87,15 +87,15 @@ 
   case 'decline':
     if (canDeclineSwap($swapId) || $verify == verificationCodeForSwap($swapId)) {
         switch (declineSwap($swapId)) {
-        case '1':
-          $message = 'Swap declined';
-          break;
-        case '2':
-          $message = 'Swap already declined.';
-          break;
-        default:
-          $err = 'Technical issue - please inform system administrator';
-          break;
+            case '1':
+              $message = 'Swap declined';
+              break;
+            case '2':
+              $message = 'Swap already declined.';
+              break;
+            default:
+              $err = 'Technical issue - please inform system administrator';
+              break;
         }
     } else {
         $err = 'Swap Already Actioned or Verification Code Invalid';

public/old/pendingAccounts.php

Switch Indentation +19 added lines, -19 removed lines

@@ -28,25 +28,25 @@
     $id = filter_var($id, FILTER_SANITIZE_NUMBER_INT);
 
     switch ($_POST['action']) {
-    case 'approve':
-      $userId = approvePendingUser($id);
-      mailNewUser($userId);
-      header('Location: addUser.php?action=edit&user='.$userId);
-      break;
-    case 'merge':
-      $existingUserId = $_POST['existingUser'];
-      $existingUserId = filter_var($existingUserId, FILTER_SANITIZE_NUMBER_INT);
-      mergePendingUserWithUserId($id, $existingUserId);
-      mailNewUser($existingUserId);
-      header('Location: addUser.php?action=edit&user='.$existingUserId);
-      break;
-    case 'decline':
-      declinePendingUser($id);
-      break;
-
-    default:
-      // code...
-      break;
+        case 'approve':
+          $userId = approvePendingUser($id);
+          mailNewUser($userId);
+          header('Location: addUser.php?action=edit&user='.$userId);
+          break;
+        case 'merge':
+          $existingUserId = $_POST['existingUser'];
+          $existingUserId = filter_var($existingUserId, FILTER_SANITIZE_NUMBER_INT);
+          mergePendingUserWithUserId($id, $existingUserId);
+          mailNewUser($existingUserId);
+          header('Location: addUser.php?action=edit&user='.$existingUserId);
+          break;
+        case 'decline':
+          declinePendingUser($id);
+          break;
+
+        default:
+          // code...
+          break;
   }
 }
 

public/old/calendarTokens.php

Switch Indentation +27 added lines, -27 removed lines

@@ -21,36 +21,36 @@
     $method = $_POST['method'];
 
     switch ($method) {
-    case 'revoke':
-      $id = $_POST['id'];
-      $id = filter_var($id, FILTER_SANITIZE_NUMBER_INT);
+        case 'revoke':
+          $id = $_POST['id'];
+          $id = filter_var($id, FILTER_SANITIZE_NUMBER_INT);
 
-      revokeCalendarToken($id);
-      header('Location: calendarTokens.php');
-      break;
-
-    default:
-      // generate new URL
-      $format = $_POST['format'];
-      $description = $_POST['description'];
-
-      if (empty($format)) {
-          $error = 'Format must be set';
-          break;
-      }
-      if (empty($description)) {
-          $error = 'Device or software name cannot be empty';
+          revokeCalendarToken($id);
+          header('Location: calendarTokens.php');
           break;
-      }
-      $count = CalendarTokenQuery::create()->filterByUserId($sessionUserId)->filterByDescription($description)->filterByRevoked(false)->count();
-      if ($count > 0) {
-          $error = 'You already have a calendar for the same device or software name. Please revoke the existing token or use a different name.';
-          break;
-      }
 
-      $token = createCalendarToken($sessionUserId, $format, $description);
-      $url = siteSettings()->getSiteUrl()."/calendar.php?user=$sessionUserId&format=$format&token=$token";
-      break;
+        default:
+          // generate new URL
+          $format = $_POST['format'];
+          $description = $_POST['description'];
+
+          if (empty($format)) {
+              $error = 'Format must be set';
+              break;
+          }
+          if (empty($description)) {
+              $error = 'Device or software name cannot be empty';
+              break;
+          }
+          $count = CalendarTokenQuery::create()->filterByUserId($sessionUserId)->filterByDescription($description)->filterByRevoked(false)->count();
+          if ($count > 0) {
+              $error = 'You already have a calendar for the same device or software name. Please revoke the existing token or use a different name.';
+              break;
+          }
+
+          $token = createCalendarToken($sessionUserId, $format, $description);
+          $url = siteSettings()->getSiteUrl()."/calendar.php?user=$sessionUserId&format=$format&token=$token";
+          break;
   }
 }
 

public/old/linkSocialAuth.php

Switch Indentation +11 added lines, -11 removed lines

@@ -37,22 +37,22 @@
     $platform = strtolower($_POST['platform']);
 
     switch ($_POST['action']) {
-    case 'link':
-      switch ($platform) {
+        case 'link':
+          switch ($platform) {
         case 'facebook':
           $_SESSION['fb-callback-url'] = 'fb-link.php';
           header('Location: fb-login.php');
           exit;
-      }
-      break;
-    case 'unlink':
-      removeSocialAuthFromUserWithId($id, $platform);
-      createNotificationForUser($id, ucfirst($platform).' account unlinked', 'You have successfully unlinked your Facebook account.  Login via Facebook is now disabled for your account.  Feel free to relink your account at any time.', 'account', 'linkSocialAuth.php');
-      break;
-
-    default:
-      // code...
+          }
       break;
+        case 'unlink':
+          removeSocialAuthFromUserWithId($id, $platform);
+          createNotificationForUser($id, ucfirst($platform).' account unlinked', 'You have successfully unlinked your Facebook account.  Login via Facebook is now disabled for your account.  Feel free to relink your account at any time.', 'account', 'linkSocialAuth.php');
+          break;
+
+        default:
+          // code...
+          break;
   }
 }