TechWilk / rota

api-classes/Database.php

Doc Comments +11 added lines

@@ -148,6 +148,12 @@ 
         return $statement->fetchAll(PDO::FETCH_CLASS, $returnClass);
     }
 
+    /**
+     * @param string $returnClass
+     * @param string $table
+     * @param string[] $columns
+     * @param string[] $where
+     */
     public function selectSingle($returnClass, $table, $columns, $where = null)
     {
         $statement = $this->selectStatement($table, $columns, $where);
@@ -215,6 +221,8 @@ 
 
   /**
    * Use with caution: it is often better to archive items to prevent creating null references.
+   * @param string $table
+   * @param string[] $where
    */
   public function delete($table, $where)
   {
@@ -253,6 +261,9 @@ 
         return $table;
     }
 
+    /**
+     * @param string $table
+     */
     private function tableExists($table)
     {
         // todo: implement table check

generated-classes/TechWilk/Rota/User.php

Doc Comments +1 added lines, -1 removed lines

@@ -196,7 +196,7 @@
     /**
      * Determine if the user is marked as available for an event.
      *
-     * @return bool if user is available
+     * @return null|boolean if user is available
      */
     public function isAvailableForEvent(Event $event)
     {

src/classes/Authentication.php

Doc Comments +3 added lines

@@ -119,6 +119,9 @@
         return true;
     }
 
+    /**
+     * @param EmailAddress $username
+     */
     private function numberOfLoginAttemptsIsOk($username)
     {
         $numberOfAllowedAttempts = 8;

public/api/v1/index.php

Braces +3 added lines, -1 removed lines

@@ -419,7 +419,9 @@
 // End of very very very basic auth
 // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-else:
+else {
+    :
 http_response_code(401);
+}
 
 endif;

public/old/overview.php

Braces +3 added lines, -1 removed lines

@@ -114,8 +114,10 @@
 			</form>
 
 		  <?php
-            else:
+            else {
+                :
                 echo '<div class="box-body">'.$sentSuccess.'</div>';
+            }
             endif;
             ?>
 				</div>

public/old/swap.php

Braces +5 added lines, -2 removed lines

@@ -271,14 +271,17 @@
 
         <?php endforeach; ?>
       
-      <?php else: ?>
+      <?php else {
+    : ?>
       <?php // event has no roles the user can cover?>
       
       <div class="alert alert-warning">
         <h4><i class="icon fa fa-info"></i>There are no roles in the event you are skilled to cover.</h4>
         <p>If you need adding to the rota, speak to an admin.</p>
       </div>
-      <?php endif; ?>
+      <?php endif;
+}
+?>
 
 
 <?php include 'includes/footer.php'; ?>

public/old/createEvent.php

Braces +5 added lines, -2 removed lines

@@ -567,7 +567,8 @@ 
 											<?php if (!$userRole->getReserve()): ?>
 											<?php $isInEvent = in_array($userRole->getId(), $usersInEvent) ?>
 											<option value="<?php echo $userRole->getId() ?>" <?php echo $isInEvent ? 'selected="selected"' : '' ?>><?php echo $userRole->getUser()->getFirstName().' '.$userRole->getUser()->getLastName() ?></option>
-											<?php else: ?>
+											<?php else {
+    : ?>
 											<?php $countReserve += 1 ?>
 											<?php endif //!userRole->getReserve?>
 										<?php endforeach //users?>
@@ -646,4 +647,6 @@ 
   </div><!-- /.createSeries -->
 
 
-<?php include 'includes/footer.php'; ?>
+<?php include 'includes/footer.php';
+}
+?>

public/old/events.php

Braces +3 added lines, -1 removed lines

@@ -435,8 +435,10 @@
 
                             echo '</li>';
                         }
-        echo '</ul>'; else:
+        echo '</ul>'; else {
+            :
                         echo '<p>No roles assigned to this event.';
+        }
         endif; ?>
 			</div><!-- /.user-roles -->
 		</div><!-- /.box-body -->

public/old/includes/functions.mail.php

Braces +6 added lines, -2 removed lines

@@ -266,8 +266,10 @@ 
     if (is_array($rotaoutput)):
         foreach ($rotaoutput as $key => $skill):
             $skillfinal = $skillfinal.$skill.' ';
-    endforeach; else:
+    endforeach; else {
+        :
         $skillfinal = $rotaoutput;
+    }
     endif;
     $message = str_replace('[rotaoutput]', $skillfinal, $message);
     $message = str_replace('[siteurl]', $siteurl, $message);
@@ -445,8 +447,10 @@ 
             $roles = [];
             while ($roleRow = mysqli_fetch_array($roleResult, MYSQLI_ASSOC)) {
                 if (($roleRow['name'] == '') || ($roleRow['name'] == $roleRow['description'])):
-                    $roles[] = $roleRow['description']; else:
+                    $roles[] = $roleRow['description']; else {
+                        :
                     $roles[] = $roleRow['description'].' - '.$roleRow['name'];
+                    }
                 endif;
             }