History::getIterator() - Code Metrics - Inspection of "Enhance http history" - Taluu/Behapi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#47)

by Baptiste

created 2018-04-11 00:13 UTC

History::getIterator() A

↳ Parent: History

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php declare(strict_types=1);
namespace Behapi\HttpHistory;

use IteratorAggregate;

use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

use Http\Client\Common\Plugin\Journal;

use Http\Client\Exception;
use Http\Client\Exception\HttpException;

use function end;
use function reset;
use function count;

final class History implements Journal, IteratorAggregate
{
    /** @var Tuple[] */
    private $tuples = [];

    /** {@inheritDoc} */
    public function addSuccess(RequestInterface $request, ResponseInterface $response)
    {
        $this->tuples[] = new Tuple($request, $response);
    }

    /** {@inheritDoc} */
    public function addFailure(RequestInterface $request, Exception $exception)
    {
        $response = $exception instanceof HttpException
            ? $exception->getResponse()
            : null;

        $this->tuples[] = new Tuple($request, $response);
    }

    public function getLastResponse(): ?ResponseInterface
    {
        if (1 > count($this->tuples)) {
            return null;
        }

        /** @var Tuple $tuple */
        $tuple = end($this->tuples);
        reset($this->tuples);

        return $tuple->getResponse();
    }

    /** @return iterable<Tuple> */
    public function getIterator(): iterable
    {
        yield from $this->tuples;

        return count($this->tuples);

    }

    public function reset(): void
    {
        $this->tuples = [];
    }
}


1			<?php declare(strict_types=1);
2			namespace Behapi\HttpHistory;
3
4			use IteratorAggregate;
5
6			use Psr\Http\Message\RequestInterface;
7			use Psr\Http\Message\ResponseInterface;
8
9			use Http\Client\Common\Plugin\Journal;
10
11			use Http\Client\Exception;
12			use Http\Client\Exception\HttpException;
13
14			use function end;
15			use function reset;
16			use function count;
17
18			final class History implements Journal, IteratorAggregate
19			{
20			/** @var Tuple[] */
21			private $tuples = [];
22
23			/** {@inheritDoc} */
24			public function addSuccess(RequestInterface $request, ResponseInterface $response)
25			{
26			$this->tuples[] = new Tuple($request, $response);
27			}
28
29			/** {@inheritDoc} */
30			public function addFailure(RequestInterface $request, Exception $exception)
31			{
32			$response = $exception instanceof HttpException
33			? $exception->getResponse()
34			: null;
35
36			$this->tuples[] = new Tuple($request, $response);
37			}
38
39			public function getLastResponse(): ?ResponseInterface
40			{
41			if (1 > count($this->tuples)) {
42			return null;
43			}
44
45			/** @var Tuple $tuple */
46			$tuple = end($this->tuples);
47			reset($this->tuples);
48
49			return $tuple->getResponse();
50			}
51
52			/** @return iterable<Tuple> */
53			public function getIterator(): iterable
54			{
55			yield from $this->tuples;
56
57			return count($this->tuples);
			1 ignored issue – show Bug Best Practice introduced 2018-04-11 00:11 UTC by Report Bug Copy Issue Report The expression `return count($this->tuples)` returns the type `integer` which is incompatible with the type-hinted return `iterable`. Loading history...
58			}
59
60			public function reset(): void
61			{
62			$this->tuples = [];
63			}
64			}
65

Taluu / Behapi

Pull Request — master (#47)

History::getIterator() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like