talismanfr\rosselhozbank\stores\RegionBranchStoreUrlJson::findAll()

Complexity

Conditions	6
Paths	6

Size

Total Lines	28
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

<?php
    public function findAll(): array
    {
        if($this->all){
            return $this->all;
        }


        $resource=file_get_contents($this->url->__toString());

The method __toString() does not exist on null.

        if(empty($resource)){
            return [];
        }

        try{
            $resource=json_decode($resource,true);
            if(!$resource){
                return [];
            }
        }catch (\Exception $e){
            return [];
        }
        foreach ($resource as $item){
            $this->all[]=new RegionBranch(
                (int)$item['id'],
                $item['origName'],
                $item['newName']
            );
        }
        return $this->all;

The expression return $this->all could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }
}