UpdateCommand::execute() - Code Metrics - TYPO3GmbH/elasticorn - Measure and Improve Code Quality continuously with Scrutinizer

UpdateCommand::execute() A
last analyzed 2020-02-21 07:41 UTC

↳ Parent: UpdateCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	9.568
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php
declare(strict_types = 1);
namespace T3G\Elasticorn\Commands\Self;

use Humbug\SelfUpdate\Updater;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class UpdateCommand extends Command
{

    /**
     * Configure the update command
     *
     * @return void
     */
    protected function configure()
    {
        parent::configure();
        $this
            ->setName('self:update')
            ->setDescription('Update elasticorn to the newest version.');
    }

    public function execute(InputInterface $input, OutputInterface $output)
    {
        $urlToGithubPagesPharFile = 'https://typo3gmbh.github.io/elasticorn/elasticorn.phar';
        $urlToGithubPagesVersionFile = $urlToGithubPagesPharFile . '.version';
        $updater = new Updater();
        $updater->getStrategy()->setPharUrl($urlToGithubPagesPharFile);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $updater->getStrategy()->setVersionUrl($urlToGithubPagesVersionFile);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $result = $updater->update();
        if (!$result) {
            $output->writeln('No update necessary');
        } else {
            $new = $updater->getNewVersion();
            $old = $updater->getOldVersion();
            $output->writeln(
                sprintf(
                    'Updated from %s to %s. To perform a rollback use ./elasticorn.phar self:rollback',
                    $old,
                    $new
                )
            );
        }
    }
}

UpdateCommand::execute() A
last analyzed 2020-02-21 07:41 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2			declare(strict_types = 1);
3			namespace T3G\Elasticorn\Commands\Self;
4
5			use Humbug\SelfUpdate\Updater;
6			use Symfony\Component\Console\Command\Command;
7			use Symfony\Component\Console\Input\InputInterface;
8			use Symfony\Component\Console\Output\OutputInterface;
9
10			class UpdateCommand extends Command
11			{
12
13			/**
14			* Configure the update command
15			*
16			* @return void
17			*/
18			protected function configure()
19			{
20			parent::configure();
21			$this
22			->setName('self:update')
23			->setDescription('Update elasticorn to the newest version.');
24			}
25
26			public function execute(InputInterface $input, OutputInterface $output)
27			{
28			$urlToGithubPagesPharFile = 'https://typo3gmbh.github.io/elasticorn/elasticorn.phar';
29			$urlToGithubPagesVersionFile = $urlToGithubPagesPharFile . '.version';
30			$updater = new Updater();
31			$updater->getStrategy()->setPharUrl($urlToGithubPagesPharFile);
			0 ignored issues – show Bug introduced 2017-10-02 12:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Humbug\SelfUpdate\Strategy\StrategyInterface` as the method `setPharUrl()` does only exist in the following implementations of said interface: `Humbug\SelfUpdate\Strategy\ShaStrategy`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
32			$updater->getStrategy()->setVersionUrl($urlToGithubPagesVersionFile);
			0 ignored issues – show Bug introduced 2017-10-02 12:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Humbug\SelfUpdate\Strategy\StrategyInterface` as the method `setVersionUrl()` does only exist in the following implementations of said interface: `Humbug\SelfUpdate\Strategy\ShaStrategy`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
33			$result = $updater->update();
34			if (!$result) {
35			$output->writeln('No update necessary');
36			} else {
37			$new = $updater->getNewVersion();
38			$old = $updater->getOldVersion();
39			$output->writeln(
40			sprintf(
41			'Updated from %s to %s. To perform a rollback use ./elasticorn.phar self:rollback',
42			$old,
43			$new
44			)
45			);
46			}
47			}
48			}

TYPO3GmbH / elasticorn

UpdateCommand::execute() A last analyzed 2020-02-21 07:41 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

UpdateCommand::execute() A
last analyzed 2020-02-21 07:41 UTC