Reader::resolveContainer() - Code Metrics - Inspection of "[FEATURE ] Add possibility to retrieve low-level P..." - TYPO3/phar-stream-wrapper - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#10)

by Oliver

created 2019-01-19 12:15 UTC

Reader::resolveContainer() D

↳ Parent: Reader

Complexity

Conditions	21
Paths	24

Size

Total Lines	73
Code Lines	49

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	21
eloc	49
nc	24
nop	0
dl	0
loc	73
rs	4.1666
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
declare(strict_types=1);
namespace TYPO3\PharStreamWrapper\Phar;

/*
 * This file is part of the TYPO3 project.
 *
 * It is free software; you can redistribute it and/or modify it under the terms
 * of the MIT License (MIT). For the full copyright and license information,
 * please read the LICENSE file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

class Reader
{
    /**
     * @var string
     */
    private $fileName;

    /**
     * @var string
     */
    private $fileType;

    /**
     * @param string $fileName
     */
    public function __construct(string $fileName)
    {
        if (strpos($fileName, '://') !== false) {
            throw new \UnexpectedValueException(
                'File name must not contain stream prefix',
                1539623708
            );
        }

        $this->fileName = $fileName;
        $this->fileType = $this->determineFileType();
    }

    /**
     * @return Container
     */
    public function resolveContainer(): Container
    {
        $stream = '';
        if ($this->fileType === 'application/x-gzip') {
            $stream = 'compress.zlib://';
        } elseif ($this->fileType === 'application/x-bzip2') {
            $stream = 'compress.bzip2://';
        }

        $stubContent = null;
        $manifestContent = null;
        $manifestLength = null;
        $resource = fopen($stream . $this->fileName, 'r');
        while (!feof($resource)) {
        while (!feof(/** @scrutinizer ignore-type */ $resource)) {
            $line = fgets($resource);
            $line = fgets(/** @scrutinizer ignore-type */ $resource);
            // stop reading file when manifest can be extracted
            if ($manifestLength !== null && $manifestContent !== null && strlen($manifestContent) >= $manifestLength) {
                break;
            }

            $stubPosition = strpos($line, '<?php');
            $manifestPosition = strpos($line, '__HALT_COMPILER()');

            // line contains both, start of (empty) stub and start of manifest
            if ($stubContent === null && $stubPosition !== false
                && $manifestContent === null && $manifestPosition !== false) {
                $stubContent = substr($line, $stubPosition, $manifestPosition - $stubPosition - 1);
                $manifestContent = preg_replace('#^.*__HALT_COMPILER\(\)[^>]*\?>(\r|\n)*#', '', $line);
                $manifestLength = $this->resolveManifestLength($manifestContent);
            // line contains start of stub
            } elseif ($stubContent === null && $stubPosition !== false) {
                $stubContent = substr($line, $stubPosition);
            // line contains start of manifest
            } elseif ($manifestContent === null && $manifestPosition !== false) {
                $manifestContent = preg_replace('#^.*__HALT_COMPILER\(\)[^>]*\?>(\r|\n)*#', '', $line);
                $manifestLength = $this->resolveManifestLength($manifestContent);
            // manifest has been started (thus is cannot be stub anymore), add content
            } elseif ($manifestContent !== null) {
                $manifestContent .= $line;
                $manifestLength = $this->resolveManifestLength($manifestContent);
            // stub has been started (thus cannot be manifest here, yet), add content
            } elseif ($stubContent !== null) {
                $stubContent .= $line;
            }
        }
        fclose($resource);
        fclose(/** @scrutinizer ignore-type */ $resource);

        if ($stubContent === null) {
            throw new \UnexpectedValueException(
                'Cannot resolve stub',
                1547807881
            );
        }
        if ($manifestContent === null || $manifestLength === null) {
            throw new \UnexpectedValueException(
                'Cannot resolve manifest',
                1547807882
            );
        }
        if (strlen($manifestContent) < $manifestLength) {
            throw new \UnexpectedValueException(
                sprintf(
                    'Exected manifest length %d, got %d',
                    strlen($manifestContent),
                    $manifestLength
                ),
                1547807883
            );
        }

        return new Container(
            Stub::fromContent($stubContent),
            Manifest::fromContent($manifestContent)
        );
    }

    /**
     * @return string
     */
    private function determineFileType()
    {
        $fileInfo = new \finfo();
        return $fileInfo->file($this->fileName, FILEINFO_MIME_TYPE);
    }

    /**
     * @param string $content
     * @return int|null
     */
    private function resolveManifestLength(string $content)
    {
        if (strlen($content) < 4) {
            return null;
        }
        return static::resolveFourByteLittleEndian($content, 0);
    }

    /**
     * @param string $content
     * @param int $start
     * @return int
     */
    public static function resolveFourByteLittleEndian(string $content, int $start): int
    {
        $payload = substr($content, $start, 4);
        if (!is_string($payload)) {

            throw new \UnexpectedValueException(
                sprintf('Cannot resolve value at offset %d', $start),
                1539614260
            );
        }

        $value = unpack('V', $payload);
        if (!isset($value[1])) {
            throw new \UnexpectedValueException(
                sprintf('Cannot resolve value at offset %d', $start),
                1539614261
            );
        }
        return $value[1];
    }

    /**
     * @param string $content
     * @param int $start
     * @return int
     */
    public static function resolveTwoByteBigEndian(string $content, int $start): int
    {
        $payload = substr($content, $start, 2);
        if (!is_string($payload)) {

            throw new \UnexpectedValueException(
                sprintf('Cannot resolve value at offset %d', $start),
                1539614263
            );
        }

        $value = unpack('n', $payload);
        if (!isset($value[1])) {
            throw new \UnexpectedValueException(
                sprintf('Cannot resolve value at offset %d', $start),
                1539614264
            );
        }
        return $value[1];
    }
}


TYPO3 / phar-stream-wrapper

GitHub Access Token became invalid

Pull Request — master (#10)

Reader::resolveContainer() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like