View GitHub Repository TYPO3.CMS

Schedule Inspection
Subscribe
Passed
Branch — master (311f62)
by Christian
15:56
created
Status
Category
Toggle Patches
typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch 
@@ -113,29 +113,29 @@  discard block
 
 block discarded – undo
113 113 
         if (!$disabled) {
114 114 
             $html[] = $fieldInformationHtml;
115 115 
         }
116 
-        $html[] =   '<div class="form-control-wrap" style="max-width: ' . $width . 'px">';
117 
-        $html[] =       '<div class="form-wizards-wrap form-wizards-aside">';
118 
-        $html[] =           '<div class="form-wizards-element">';
116 
+        $html[] = '<div class="form-control-wrap" style="max-width: ' . $width . 'px">';
117 
+        $html[] = '<div class="form-wizards-wrap form-wizards-aside">';
118 
+        $html[] = '<div class="form-wizards-element">';
119 119 
         if (!$disabled) {
120 120 
             // Add an empty hidden field which will send a blank value if all items are unselected.
121 
-            $html[] =           '<input type="hidden" name="' . htmlspecialchars($parameterArray['itemFormElName']) . '" value="">';
121 
+            $html[] = '<input type="hidden" name="' . htmlspecialchars($parameterArray['itemFormElName']) . '" value="">';
122 122 
         }
123 
-        $html[] =               $selectElement;
124 
-        $html[] =           '</div>';
123 
+        $html[] = $selectElement;
124 
+        $html[] = '</div>';
125 125 
         if (!$disabled) {
126 
-            $html[] =       '<div class="form-wizards-items-aside">';
127 
-            $html[] =           $fieldControlHtml;
128 
-            $html[] =       '</div>';
129 
-            $html[] =   '</div>';
130 
-
131 
-            $html[] =   '<p>';
132 
-            $html[] =       '<em>' . htmlspecialchars($languageService->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:labels.holdDownCTRL')) . '</em>';
133 
-            $html[] =   '</p>';
134 
-            $html[] =   '<div class="form-wizards-items-bottom">';
135 
-            $html[] =       $fieldWizardHtml;
136 
-            $html[] =   '</div>';
126 
+            $html[] = '<div class="form-wizards-items-aside">';
127 
+            $html[] = $fieldControlHtml;
128 
+            $html[] = '</div>';
129 
+            $html[] = '</div>';
130 
+
131 
+            $html[] = '<p>';
132 
+            $html[] = '<em>' . htmlspecialchars($languageService->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:labels.holdDownCTRL')) . '</em>';
133 
+            $html[] = '</p>';
134 
+            $html[] = '<div class="form-wizards-items-bottom">';
135 
+            $html[] = $fieldWizardHtml;
136 
+            $html[] = '</div>';
137 137 
         }
138 
-        $html[] =   '</div>';
138 
+        $html[] = '</div>';
139 139 
         $html[] = '</div>';
140 140
141 141 
         $resultArray['html'] = implode(LF, $html);
 
@@ -184,7 +184,7 @@  discard block
 
 block discarded – undo
184 184
185 185 
         $html = [];
186 186 
         $html[] = '<select ' . GeneralUtility::implodeAttributes($attributes, true) . '>';
187 
-        $html[] =   implode(LF, $optionElements);
187 
+        $html[] = implode(LF, $optionElements);
188 188 
         $html[] = '</select>';
189 189
190 190 
         return implode(LF, $html);
Please login to merge, or discard this patch.
typo3/sysext/backend/Classes/Form/Element/RadioElement.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch 
@@ -52,7 +52,7 @@  discard block
 
 block discarded – undo
52 52
53 53 
         $html = [];
54 54 
         foreach ($this->data['parameterArray']['fieldConf']['config']['items'] as $itemNumber => $itemLabelAndValue) {
55 
-            $label =  $itemLabelAndValue[0];
55 
+            $label = $itemLabelAndValue[0];
56 56 
             $value = $itemLabelAndValue[1];
57 57 
             $radioId = htmlspecialchars($this->data['parameterArray']['itemFormElID'] . '_' . $itemNumber);
58 58 
             $radioChecked = (string)$value === (string)$this->data['parameterArray']['itemFormElValue'] ? ' checked="checked"' : '';
 
@@ -69,28 +69,28 @@  discard block
 
 block discarded – undo
69 69 
             if (!$disabled) {
70 70 
                 $html[] = $fieldInformationHtml;
71 71 
             }
72 
-            $html[] =   '<div class="form-wizards-wrap">';
73 
-            $html[] =       '<div class="form-wizards-element">';
74 
-            $html[] =           '<div class="radio' . $disabled . '">';
75 
-            $html[] =               '<label for="' . $radioId . '">';
76 
-            $html[] =                   '<input type="radio"';
77 
-            $html[] =                       ' name="' . htmlspecialchars($this->data['parameterArray']['itemFormElName']) . '"';
78 
-            $html[] =                       ' id="' . $radioId . '"';
79 
-            $html[] =                       ' value="' . htmlspecialchars($value) . '"';
80 
-            $html[] =                       $radioChecked;
81 
-            $html[] =                       $disabled;
82 
-            $html[] =                       ' onclick="' . htmlspecialchars(implode('', $this->data['parameterArray']['fieldChangeFunc'])) . '"';
83 
-            $html[] =                   '/>';
84 
-            $html[] =                       htmlspecialchars($label);
85 
-            $html[] =               '</label>';
86 
-            $html[] =           '</div>';
87 
-            $html[] =       '</div>';
72 
+            $html[] = '<div class="form-wizards-wrap">';
73 
+            $html[] = '<div class="form-wizards-element">';
74 
+            $html[] = '<div class="radio' . $disabled . '">';
75 
+            $html[] = '<label for="' . $radioId . '">';
76 
+            $html[] = '<input type="radio"';
77 
+            $html[] = ' name="' . htmlspecialchars($this->data['parameterArray']['itemFormElName']) . '"';
78 
+            $html[] = ' id="' . $radioId . '"';
79 
+            $html[] = ' value="' . htmlspecialchars($value) . '"';
80 
+            $html[] = $radioChecked;
81 
+            $html[] = $disabled;
82 
+            $html[] = ' onclick="' . htmlspecialchars(implode('', $this->data['parameterArray']['fieldChangeFunc'])) . '"';
83 
+            $html[] = '/>';
84 
+            $html[] = htmlspecialchars($label);
85 
+            $html[] = '</label>';
86 
+            $html[] = '</div>';
87 
+            $html[] = '</div>';
88 88 
             if (!$disabled) {
89 
-                $html[] =   '<div class="form-wizards-items-bottom">';
90 
-                $html[] =       $fieldWizardHtml;
91 
-                $html[] =   '</div>';
89 
+                $html[] = '<div class="form-wizards-items-bottom">';
90 
+                $html[] = $fieldWizardHtml;
91 
+                $html[] = '</div>';
92 92 
             }
93 
-            $html[] =   '</div>';
93 
+            $html[] = '</div>';
94 94 
             $html[] = '</div>';
95 95 
         }
96 96
Please login to merge, or discard this patch.
typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-declare(strict_types=1);
2 
+declare(strict_types = 1);
3 3 
 namespace TYPO3\CMS\Backend\Form\FieldControl;
4 4
5 5 
 /*
 
@@ -68,15 +68,15 @@  discard block
 
 block discarded – undo
68 68 
         $onClick = [];
69 69 
         $onClick[] = 'this.blur();';
70 70 
         $onClick[] = 'vHWin=window.open(';
71 
-        $onClick[] =    GeneralUtility::quoteJSvalue($url);
72 
-        $onClick[] =    '+\'&P[currentValue]=\'+TBE_EDITOR.rawurlencode(';
73 
-        $onClick[] =        'document.editform[' . GeneralUtility::quoteJSvalue($itemName) . '].value,300';
74 
-        $onClick[] =    ')';
75 
-        $onClick[] =    '+\'&P[currentSelectedValues]=\'+TBE_EDITOR.curSelected(';
76 
-        $onClick[] =        GeneralUtility::quoteJSvalue($itemName);
77 
-        $onClick[] =    '),';
78 
-        $onClick[] =    '\'\',';
79 
-        $onClick[] =    GeneralUtility::quoteJSvalue($windowOpenParameters);
71 
+        $onClick[] = GeneralUtility::quoteJSvalue($url);
72 
+        $onClick[] = '+\'&P[currentValue]=\'+TBE_EDITOR.rawurlencode(';
73 
+        $onClick[] = 'document.editform[' . GeneralUtility::quoteJSvalue($itemName) . '].value,300';
74 
+        $onClick[] = ')';
75 
+        $onClick[] = '+\'&P[currentSelectedValues]=\'+TBE_EDITOR.curSelected(';
76 
+        $onClick[] = GeneralUtility::quoteJSvalue($itemName);
77 
+        $onClick[] = '),';
78 
+        $onClick[] = '\'\',';
79 
+        $onClick[] = GeneralUtility::quoteJSvalue($windowOpenParameters);
80 80 
         $onClick[] = ');';
81 81 
         $onClick[] = 'vHWin.focus();';
82 82 
         $onClick[] = 'return false;';
Please login to merge, or discard this patch.
typo3/sysext/backend/Classes/Form/FieldControl/ListModule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-declare(strict_types=1);
2 
+declare(strict_types = 1);
3 3 
 namespace TYPO3\CMS\Backend\Form\FieldControl;
4 4
5 5 
 /*
 
@@ -71,7 +71,7 @@  discard block
 
 block discarded – undo
71 71 
             $pid = 0;
72 72 
         }
73 73
74 
-        $urlParameters  = [
74 
+        $urlParameters = [
75 75 
             'P' => [
76 76 
                 'params' => [
77 77 
                     'table' => $table,
Please login to merge, or discard this patch.
typo3/sysext/backend/Classes/Form/FieldControl/EditPopup.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-declare(strict_types=1);
2 
+declare(strict_types = 1);
3 3 
 namespace TYPO3\CMS\Backend\Form\FieldControl;
4 4
5 5 
 /*
 
@@ -42,7 +42,7 @@  discard block
 
 block discarded – undo
42 42 
         $itemName = $parameterArray['itemFormElName'];
43 43 
         $windowOpenParameters = $options['windowOpenParameters'] ?? 'height=800,width=600,status=0,menubar=0,scrollbars=1';
44 44
45 
-        $urlParameters  = [
45 
+        $urlParameters = [
46 46 
             'P' => [
47 47 
                 'table' => $this->data['tableName'],
48 48 
                 'field' => $this->data['fieldName'],
 
@@ -57,26 +57,26 @@  discard block
 
 block discarded – undo
57 57 
         $onClick = [];
58 58 
         $onClick[] = 'this.blur();';
59 59 
         $onClick[] = 'if (!TBE_EDITOR.curSelected(' . GeneralUtility::quoteJSvalue($itemName) . ')) {';
60 
-        $onClick[] =    'top.TYPO3.Modal.confirm(';
61 
-        $onClick[] =        '"' . $languageService->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:warning.header') . '",';
62 
-        $onClick[] =        '"' . $languageService->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:mess.noSelItemForEdit') . '",';
63 
-        $onClick[] =        'top.TYPO3.Severity.notice, [{text: TYPO3.lang[\'button.ok\'] || \'OK\', btnClass: \'btn-notice\', name: \'ok\'}]';
64 
-        $onClick[] =    ')';
65 
-        $onClick[] =    '.on("button.clicked", function(e) {';
66 
-        $onClick[] =        'if (e.target.name == "ok") { top.TYPO3.Modal.dismiss(); }}';
67 
-        $onClick[] =    ');';
68 
-        $onClick[] =    'return false;';
60 
+        $onClick[] = 'top.TYPO3.Modal.confirm(';
61 
+        $onClick[] = '"' . $languageService->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:warning.header') . '",';
62 
+        $onClick[] = '"' . $languageService->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:mess.noSelItemForEdit') . '",';
63 
+        $onClick[] = 'top.TYPO3.Severity.notice, [{text: TYPO3.lang[\'button.ok\'] || \'OK\', btnClass: \'btn-notice\', name: \'ok\'}]';
64 
+        $onClick[] = ')';
65 
+        $onClick[] = '.on("button.clicked", function(e) {';
66 
+        $onClick[] = 'if (e.target.name == "ok") { top.TYPO3.Modal.dismiss(); }}';
67 
+        $onClick[] = ');';
68 
+        $onClick[] = 'return false;';
69 69 
         $onClick[] = '}';
70 70 
         $onClick[] = 'vHWin=window.open(';
71 
-        $onClick[] =    GeneralUtility::quoteJSvalue($url);
72 
-        $onClick[] =    '+\'&P[currentValue]=\'+TBE_EDITOR.rawurlencode(';
73 
-        $onClick[] =        'document.editform[' . GeneralUtility::quoteJSvalue($itemName) . '].value,300';
74 
-        $onClick[] =    ')';
75 
-        $onClick[] =    '+\'&P[currentSelectedValues]=\'+TBE_EDITOR.curSelected(';
76 
-        $onClick[] =        GeneralUtility::quoteJSvalue($itemName);
77 
-        $onClick[] =    '),';
78 
-        $onClick[] =    '\'\',';
79 
-        $onClick[] =    GeneralUtility::quoteJSvalue($windowOpenParameters);
71 
+        $onClick[] = GeneralUtility::quoteJSvalue($url);
72 
+        $onClick[] = '+\'&P[currentValue]=\'+TBE_EDITOR.rawurlencode(';
73 
+        $onClick[] = 'document.editform[' . GeneralUtility::quoteJSvalue($itemName) . '].value,300';
74 
+        $onClick[] = ')';
75 
+        $onClick[] = '+\'&P[currentSelectedValues]=\'+TBE_EDITOR.curSelected(';
76 
+        $onClick[] = GeneralUtility::quoteJSvalue($itemName);
77 
+        $onClick[] = '),';
78 
+        $onClick[] = '\'\',';
79 
+        $onClick[] = GeneralUtility::quoteJSvalue($windowOpenParameters);
80 80 
         $onClick[] = ');';
81 81 
         $onClick[] = 'vHWin.focus();';
82 82 
         $onClick[] = 'return false;';
Please login to merge, or discard this patch.
typo3/sysext/backend/Classes/Form/FieldControl/AddRecord.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-declare(strict_types=1);
2 
+declare(strict_types = 1);
3 3 
 namespace TYPO3\CMS\Backend\Form\FieldControl;
4 4
5 5 
 /*
 
@@ -79,7 +79,7 @@  discard block
 
 block discarded – undo
79 79 
             $flexFormPath = str_replace('][', '/', substr($itemName, strlen($prefixOfFormElName) + 1, -1));
80 80 
         }
81 81
82 
-        $urlParameters  = [
82 
+        $urlParameters = [
83 83 
             'P' => [
84 84 
                 'params' => [
85 85 
                     'table' => $table,
Please login to merge, or discard this patch.
typo3/sysext/backend/Classes/Form/FieldControl/TableWizard.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-declare(strict_types=1);
2 
+declare(strict_types = 1);
3 3 
 namespace TYPO3\CMS\Backend\Form\FieldControl;
4 4
5 5 
 /*
 
@@ -53,7 +53,7 @@  discard block
 
 block discarded – undo
53 53 
             $flexFormPath = str_replace('][', '/', substr($itemName, strlen($prefixOfFormElName) + 1, -1));
54 54 
         }
55 55
56 
-        $urlParameters  = [
56 
+        $urlParameters = [
57 57 
             'P' => [
58 58 
                 'params' => [
59 59 
                     'xmlOutput' => $xmlOutput,
Please login to merge, or discard this patch.
typo3/sysext/backend/Classes/Form/NodeExpansion/FieldControl.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-declare(strict_types=1);
2 
+declare(strict_types = 1);
3 3 
 namespace TYPO3\CMS\Backend\Form\NodeExpansion;
4 4
5 5 
 /*
 
@@ -122,9 +122,9 @@  discard block
 
 block discarded – undo
122 122
123 123 
             $html = [];
124 124 
             $html[] = '<a ' . GeneralUtility::implodeAttributes($linkAttributes, true) . '>';
125 
-            $html[] =   '<span alt="' . htmlspecialchars($title) . '" title="' . htmlspecialchars($title) . '">';
126 
-            $html[] =       $iconFactory->getIcon($icon, Icon::SIZE_SMALL)->render();
127 
-            $html[] =   '</span>';
125 
+            $html[] = '<span alt="' . htmlspecialchars($title) . '" title="' . htmlspecialchars($title) . '">';
126 
+            $html[] = $iconFactory->getIcon($icon, Icon::SIZE_SMALL)->render();
127 
+            $html[] = '</span>';
128 128 
             $html[] = '</a>';
129 129
130 130 
             $finalControlResult = $this->initializeResultArray();
Please login to merge, or discard this patch.
typo3/sysext/extbase/Classes/Mvc/Web/CacheHashEnforcer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@
 
 block discarded – undo
1 1 
 <?php
2 
-declare(strict_types=1);
2 
+declare(strict_types = 1);
3 3 
 namespace TYPO3\CMS\Extbase\Mvc\Web;
4 4
5 5 
 /*
Please login to merge, or discard this patch.