| Conditions | 25 |
| Paths | > 20000 |
| Total Lines | 149 |
| Code Lines | 125 |
| Lines | 54 |
| Ratio | 36.24 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 46 | public function getAdditionalFields(array &$taskInfo, $task, SchedulerModuleController $schedulerModule) |
||
| 47 | { |
||
| 48 | $additionalFields = []; |
||
| 49 | View Code Duplication | if (empty($taskInfo['configuration'])) { |
|
| 50 | if ($schedulerModule->CMD === 'add') { |
||
| 51 | $taskInfo['configuration'] = $taskInfo['linkvalidator']['configuration']; |
||
| 52 | } elseif ($schedulerModule->CMD === 'edit') { |
||
| 53 | $taskInfo['configuration'] = $task->getConfiguration(); |
||
| 54 | } else { |
||
| 55 | $taskInfo['configuration'] = $task->getConfiguration(); |
||
| 56 | } |
||
| 57 | } |
||
| 58 | View Code Duplication | if (empty($taskInfo['depth'])) { |
|
| 59 | if ($schedulerModule->CMD === 'add') { |
||
| 60 | $taskInfo['depth'] = $taskInfo['linkvalidator']['depth']; |
||
| 61 | } elseif ($schedulerModule->CMD === 'edit') { |
||
| 62 | $taskInfo['depth'] = $task->getDepth(); |
||
| 63 | } else { |
||
| 64 | $taskInfo['depth'] = $task->getDepth(); |
||
| 65 | } |
||
| 66 | } |
||
| 67 | View Code Duplication | if (empty($taskInfo['page'])) { |
|
| 68 | if ($schedulerModule->CMD === 'add') { |
||
| 69 | $taskInfo['page'] = $taskInfo['linkvalidator']['page']; |
||
| 70 | } elseif ($schedulerModule->CMD === 'edit') { |
||
| 71 | $taskInfo['page'] = $task->getPage(); |
||
| 72 | } else { |
||
| 73 | $taskInfo['page'] = $task->getPage(); |
||
| 74 | } |
||
| 75 | } |
||
| 76 | View Code Duplication | if (empty($taskInfo['email'])) { |
|
| 77 | if ($schedulerModule->CMD === 'add') { |
||
| 78 | $taskInfo['email'] = $taskInfo['linkvalidator']['email']; |
||
| 79 | } elseif ($schedulerModule->CMD === 'edit') { |
||
| 80 | $taskInfo['email'] = $task->getEmail(); |
||
| 81 | } else { |
||
| 82 | $taskInfo['email'] = $task->getEmail(); |
||
| 83 | } |
||
| 84 | } |
||
| 85 | View Code Duplication | if (empty($taskInfo['emailOnBrokenLinkOnly'])) { |
|
| 86 | if ($schedulerModule->CMD === 'add') { |
||
| 87 | $taskInfo['emailOnBrokenLinkOnly'] = $taskInfo['linkvalidator']['emailOnBrokenLinkOnly'] ? $taskInfo['linkvalidator']['emailOnBrokenLinkOnly'] : 1; |
||
| 88 | } elseif ($schedulerModule->CMD === 'edit') { |
||
| 89 | $taskInfo['emailOnBrokenLinkOnly'] = $task->getEmailOnBrokenLinkOnly(); |
||
| 90 | } else { |
||
| 91 | $taskInfo['emailOnBrokenLinkOnly'] = $task->getEmailOnBrokenLinkOnly(); |
||
| 92 | } |
||
| 93 | } |
||
| 94 | View Code Duplication | if (empty($taskInfo['emailTemplateFile'])) { |
|
| 95 | if ($schedulerModule->CMD === 'add') { |
||
| 96 | $taskInfo['emailTemplateFile'] = $taskInfo['linkvalidator']['emailTemplateFile'] ? $taskInfo['linkvalidator']['emailTemplateFile'] : 'EXT:linkvalidator/Resources/Private/Templates/mailtemplate.html'; |
||
| 97 | } elseif ($schedulerModule->CMD === 'edit') { |
||
| 98 | $taskInfo['emailTemplateFile'] = $task->getEmailTemplateFile(); |
||
| 99 | } else { |
||
| 100 | $taskInfo['emailTemplateFile'] = $task->getEmailTemplateFile(); |
||
| 101 | } |
||
| 102 | } |
||
| 103 | $fieldId = 'task_page'; |
||
| 104 | $fieldCode = '<input type="number" min="0" class="form-control" name="tx_scheduler[linkvalidator][page]" id="' |
||
| 105 | . $fieldId |
||
| 106 | . '" value="' |
||
| 107 | . htmlspecialchars($taskInfo['page']) |
||
| 108 | . '">'; |
||
| 109 | $lang = $this->getLanguageService(); |
||
| 110 | $label = $lang->sL($this->languageFile . ':tasks.validate.page'); |
||
| 111 | $label = BackendUtility::wrapInHelp('linkvalidator', $fieldId, $label); |
||
| 112 | $pageTitle = ''; |
||
| 113 | if (!empty($taskInfo['page'])) { |
||
| 114 | $pageTitle = $this->getPageTitle((int)$taskInfo['page']); |
||
| 115 | } |
||
| 116 | $additionalFields[$fieldId] = [ |
||
| 117 | 'browser' => 'page', |
||
| 118 | 'pageTitle' => $pageTitle, |
||
| 119 | 'code' => $fieldCode, |
||
| 120 | 'label' => $label |
||
| 121 | ]; |
||
| 122 | // input for depth |
||
| 123 | $fieldId = 'task_depth'; |
||
| 124 | $fieldValueArray = [ |
||
| 125 | '0' => $lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:labels.depth_0'), |
||
| 126 | '1' => $lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:labels.depth_1'), |
||
| 127 | '2' => $lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:labels.depth_2'), |
||
| 128 | '3' => $lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:labels.depth_3'), |
||
| 129 | '4' => $lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:labels.depth_4'), |
||
| 130 | '999' => $lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:labels.depth_infi') |
||
| 131 | ]; |
||
| 132 | $fieldCode = '<select class="form-control" name="tx_scheduler[linkvalidator][depth]" id="' . $fieldId . '">'; |
||
| 133 | foreach ($fieldValueArray as $depth => $label) { |
||
| 134 | $fieldCode .= "\t" . '<option value="' . htmlspecialchars($depth) . '"' |
||
| 135 | . (($depth == $taskInfo['depth']) ? ' selected="selected"' : '') . '>' |
||
| 136 | . $label |
||
| 137 | . '</option>'; |
||
| 138 | } |
||
| 139 | $fieldCode .= '</select>'; |
||
| 140 | $label = $lang->sL($this->languageFile . ':tasks.validate.depth'); |
||
| 141 | $label = BackendUtility::wrapInHelp('linkvalidator', $fieldId, $label); |
||
| 142 | $additionalFields[$fieldId] = [ |
||
| 143 | 'code' => $fieldCode, |
||
| 144 | 'label' => $label |
||
| 145 | ]; |
||
| 146 | $fieldId = 'task_configuration'; |
||
| 147 | $fieldCode = '<textarea class="form-control" name="tx_scheduler[linkvalidator][configuration]" id="' |
||
| 148 | . $fieldId |
||
| 149 | . '" >' |
||
| 150 | . htmlspecialchars($taskInfo['configuration']) |
||
| 151 | . '</textarea>'; |
||
| 152 | $label = $lang->sL($this->languageFile . ':tasks.validate.conf'); |
||
| 153 | $label = BackendUtility::wrapInHelp('linkvalidator', $fieldId, $label); |
||
| 154 | $additionalFields[$fieldId] = [ |
||
| 155 | 'code' => $fieldCode, |
||
| 156 | 'label' => $label |
||
| 157 | ]; |
||
| 158 | $fieldId = 'task_email'; |
||
| 159 | $fieldCode = '<textarea class="form-control" rows="5" cols="50" name="tx_scheduler[linkvalidator][email]" id="' |
||
| 160 | . $fieldId |
||
| 161 | . '">' |
||
| 162 | . htmlspecialchars($taskInfo['email']) |
||
| 163 | . '</textarea>'; |
||
| 164 | $label = $lang->sL($this->languageFile . ':tasks.validate.email'); |
||
| 165 | $label = BackendUtility::wrapInHelp('linkvalidator', $fieldId, $label); |
||
| 166 | $additionalFields[$fieldId] = [ |
||
| 167 | 'code' => $fieldCode, |
||
| 168 | 'label' => $label |
||
| 169 | ]; |
||
| 170 | $fieldId = 'task_emailOnBrokenLinkOnly'; |
||
| 171 | $fieldCode = '<div class="checkbox"><label>' |
||
| 172 | . '<input type="checkbox" name="tx_scheduler[linkvalidator][emailOnBrokenLinkOnly]" id="' . $fieldId . '" ' |
||
| 173 | . (htmlspecialchars($taskInfo['emailOnBrokenLinkOnly']) ? 'checked="checked"' : '') |
||
| 174 | . '></label></div>'; |
||
| 175 | $label = $lang->sL($this->languageFile . ':tasks.validate.emailOnBrokenLinkOnly'); |
||
| 176 | $label = BackendUtility::wrapInHelp('linkvalidator', $fieldId, $label); |
||
| 177 | $additionalFields[$fieldId] = [ |
||
| 178 | 'code' => $fieldCode, |
||
| 179 | 'label' => $label |
||
| 180 | ]; |
||
| 181 | $fieldId = 'task_emailTemplateFile'; |
||
| 182 | $fieldCode = '<input class="form-control" type="text" name="tx_scheduler[linkvalidator][emailTemplateFile]" ' |
||
| 183 | . 'id="' |
||
| 184 | . $fieldId |
||
| 185 | . '" value="' |
||
| 186 | . htmlspecialchars($taskInfo['emailTemplateFile']) |
||
| 187 | . '">'; |
||
| 188 | $label = $lang->sL($this->languageFile . ':tasks.validate.emailTemplateFile'); |
||
| 189 | $label = BackendUtility::wrapInHelp('linkvalidator', $fieldId, $label); |
||
| 190 | $additionalFields[$fieldId] = [ |
||
| 191 | 'code' => $fieldCode, |
||
| 192 | 'label' => $label |
||
| 193 | ]; |
||
| 194 | return $additionalFields; |
||
| 195 | } |
||
| 307 |