MfaProviderManifest::__construct() - Code Metrics - Inspection of "[FEATURE] Introduce MFA in Core" - TYPO3/TYPO3.CMS - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 25a926...39145a )

unknown

created 2021-02-19 14:39 UTC

MfaProviderManifest::__construct() A

↳ Parent: MfaProviderManifest

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	8
c	1
b	0
f	0
dl	0
loc	18
rs	10
cc	1
nc	1
nop	8

How to fix Many Parameters

<?php

declare(strict_types=1);

/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

namespace TYPO3\CMS\Core\Authentication\Mfa;

use Psr\Container\ContainerInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;

/**
 * Adapter for MFA providers
 *
 * @internal
 */
final class MfaProviderManifest implements MfaProviderManifestInterface
{
    private string $identifier;
    private string $title;
    private string $description;
    private string $setupInstructions;
    private string $iconIdentifier;
    private bool $isDefaultProviderAllowed;
    private string $serviceName;
    private ContainerInterface $container;
    private ?MfaProviderInterface $instance = null;

    public function __construct(
        string $identifier,
        string $title,
        string $description,
        string $setupInstructions,
        string $iconIdentifier,
        bool $isDefaultProviderAllowed,
        string $serviceName,
        ContainerInterface $container
    ) {
        $this->identifier = $identifier;
        $this->title = $title;
        $this->description = $description;
        $this->setupInstructions = $setupInstructions;
        $this->iconIdentifier = $iconIdentifier;
        $this->isDefaultProviderAllowed = $isDefaultProviderAllowed;
        $this->serviceName = $serviceName;
        $this->container = $container;
    }

    public function getIdentifier(): string
    {
        return $this->identifier;
    }

    public function getTitle(): string
    {
        return $this->title;
    }

    public function getDescription(): string
    {
        return $this->description;
    }

    public function getIconIdentifier(): string
    {
        return $this->iconIdentifier;
    }

    public function getSetupInstructions(): string
    {
        return $this->setupInstructions;
    }

    public function isDefaultProviderAllowed(): bool
    {
        return $this->isDefaultProviderAllowed;
    }

    public function canProcess(ServerRequestInterface $request): bool
    {
        return $this->getInstance()->canProcess($request);
    }

    public function isActive(MfaProviderPropertyManager $propertyManager): bool
    {
        return $this->getInstance()->isActive($propertyManager);
    }

    public function isLocked(MfaProviderPropertyManager $propertyManager): bool
    {
        return $this->getInstance()->isLocked($propertyManager);
    }

    public function verify(ServerRequestInterface $request, MfaProviderPropertyManager $propertyManager): bool
    {
        return $this->getInstance()->verify($request, $propertyManager);
    }

    public function handleRequest(
        ServerRequestInterface $request,
        MfaProviderPropertyManager $propertyManager,
        string $type
    ): ResponseInterface {
        return $this->getInstance()->handleRequest($request, $propertyManager, $type);
    }

    public function activate(ServerRequestInterface $request, MfaProviderPropertyManager $propertyManager): bool
    {
        return $this->getInstance()->activate($request, $propertyManager);
    }

    public function deactivate(ServerRequestInterface $request, MfaProviderPropertyManager $propertyManager): bool
    {
        return $this->getInstance()->deactivate($request, $propertyManager);
    }

    public function unlock(ServerRequestInterface $request, MfaProviderPropertyManager $propertyManager): bool
    {
        return $this->getInstance()->unlock($request, $propertyManager);
    }

    public function update(ServerRequestInterface $request, MfaProviderPropertyManager $propertyManager): bool
    {
        return $this->getInstance()->update($request, $propertyManager);
    }

    private function getInstance(): MfaProviderInterface
    {
        return $this->instance ?? $this->createInstance();
    }

    private function createInstance(): MfaProviderInterface
    {
        $this->instance = $this->container->get($this->serviceName);
        return $this->instance;

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the TYPO3 CMS project.
7			*
8			* It is free software; you can redistribute it and/or modify it under
9			* the terms of the GNU General Public License, either version 2
10			* of the License, or any later version.
11			*
12			* For the full copyright and license information, please read the
13			* LICENSE.txt file that was distributed with this source code.
14			*
15			* The TYPO3 project - inspiring people to share!
16			*/
17
18			namespace TYPO3\CMS\Core\Authentication\Mfa;
19
20			use Psr\Container\ContainerInterface;
21			use Psr\Http\Message\ResponseInterface;
22			use Psr\Http\Message\ServerRequestInterface;
23
24			/**
25			* Adapter for MFA providers
26			*
27			* @internal
28			*/
29			final class MfaProviderManifest implements MfaProviderManifestInterface
30			{
31			private string $identifier;
32			private string $title;
33			private string $description;
34			private string $setupInstructions;
35			private string $iconIdentifier;
36			private bool $isDefaultProviderAllowed;
37			private string $serviceName;
38			private ContainerInterface $container;
39			private ?MfaProviderInterface $instance = null;
40
41			public function __construct(
42			string $identifier,
43			string $title,
44			string $description,
45			string $setupInstructions,
46			string $iconIdentifier,
47			bool $isDefaultProviderAllowed,
48			string $serviceName,
49			ContainerInterface $container
50			) {
51			$this->identifier = $identifier;
52			$this->title = $title;
53			$this->description = $description;
54			$this->setupInstructions = $setupInstructions;
55			$this->iconIdentifier = $iconIdentifier;
56			$this->isDefaultProviderAllowed = $isDefaultProviderAllowed;
57			$this->serviceName = $serviceName;
58			$this->container = $container;
59			}
60
61			public function getIdentifier(): string
62			{
63			return $this->identifier;
64			}
65
66			public function getTitle(): string
67			{
68			return $this->title;
69			}
70
71			public function getDescription(): string
72			{
73			return $this->description;
74			}
75
76			public function getIconIdentifier(): string
77			{
78			return $this->iconIdentifier;
79			}
80
81			public function getSetupInstructions(): string
82			{
83			return $this->setupInstructions;
84			}
85
86			public function isDefaultProviderAllowed(): bool
87			{
88			return $this->isDefaultProviderAllowed;
89			}
90
91			public function canProcess(ServerRequestInterface $request): bool
92			{
93			return $this->getInstance()->canProcess($request);
94			}
95
96			public function isActive(MfaProviderPropertyManager $propertyManager): bool
97			{
98			return $this->getInstance()->isActive($propertyManager);
99			}
100
101			public function isLocked(MfaProviderPropertyManager $propertyManager): bool
102			{
103			return $this->getInstance()->isLocked($propertyManager);
104			}
105
106			public function verify(ServerRequestInterface $request, MfaProviderPropertyManager $propertyManager): bool
107			{
108			return $this->getInstance()->verify($request, $propertyManager);
109			}
110
111			public function handleRequest(
112			ServerRequestInterface $request,
113			MfaProviderPropertyManager $propertyManager,
114			string $type
115			): ResponseInterface {
116			return $this->getInstance()->handleRequest($request, $propertyManager, $type);
117			}
118
119			public function activate(ServerRequestInterface $request, MfaProviderPropertyManager $propertyManager): bool
120			{
121			return $this->getInstance()->activate($request, $propertyManager);
122			}
123
124			public function deactivate(ServerRequestInterface $request, MfaProviderPropertyManager $propertyManager): bool
125			{
126			return $this->getInstance()->deactivate($request, $propertyManager);
127			}
128
129			public function unlock(ServerRequestInterface $request, MfaProviderPropertyManager $propertyManager): bool
130			{
131			return $this->getInstance()->unlock($request, $propertyManager);
132			}
133
134			public function update(ServerRequestInterface $request, MfaProviderPropertyManager $propertyManager): bool
135			{
136			return $this->getInstance()->update($request, $propertyManager);
137			}
138
139			private function getInstance(): MfaProviderInterface
140			{
141			return $this->instance ?? $this->createInstance();
142			}
143
144			private function createInstance(): MfaProviderInterface
145			{
146			$this->instance = $this->container->get($this->serviceName);
147			return $this->instance;
			0 ignored issues – show Bug Best Practice introduced 2021-02-19 14:59 UTC by Report Bug Copy Issue Report The expression `return $this->instance` could return the type `null` which is incompatible with the type-hinted return `TYPO3\CMS\Core\Authentic...fa\MfaProviderInterface`. Consider adding an additional type-check to rule them out. Loading history...
148			}
149			}
150

TYPO3 / TYPO3.CMS

Push — master ( 25a926...39145a )

MfaProviderManifest::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like