Code Duplication - TYPO3/TYPO3.CMS - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 8-14 lines in 6 locations

typo3/sysext/backend/Classes/Controller/EditDocumentController.php 1 location


                                // Display "is-locked" message:
                                if ($command === 'edit') {
                                    $lockInfo = BackendUtility::isRecordLocked($table, $formData['databaseRow']['uid']);
                                    if ($lockInfo) {
                                        /** @var $flashMessage \TYPO3\CMS\Core\Messaging\FlashMessage */
                                        $flashMessage = GeneralUtility::makeInstance(
                                            FlashMessage::class,
                                            $lockInfo['msg'],
                                            '',
                                            FlashMessage::WARNING
                                        );
                                        /** @var $flashMessageService \TYPO3\CMS\Core\Messaging\FlashMessageService */
                                        $flashMessageService = GeneralUtility::makeInstance(FlashMessageService::class);
                                        /** @var $defaultFlashMessageQueue FlashMessageQueue */
                                        $defaultFlashMessageQueue = $flashMessageService->getMessageQueueByIdentifier();
                                        $defaultFlashMessageQueue->enqueue($flashMessage);
                                    }
                                }

                                // Record title

typo3/sysext/backend/Classes/View/PageLayoutView.php 1 location


                        }
                    }
                    if ($columnId === 'unused') {
                        if (empty($unusedElementsMessage)) {
                            $unusedElementsMessage = GeneralUtility::makeInstance(
                                FlashMessage::class,
                                $this->getLanguageService()->getLL('staleUnusedElementsWarning'),
                                $this->getLanguageService()->getLL('staleUnusedElementsWarningTitle'),
                                FlashMessage::WARNING
                            );
                            $service = GeneralUtility::makeInstance(FlashMessageService::class);
                            $queue = $service->getMessageQueueByIdentifier();
                            $queue->addMessage($unusedElementsMessage);
                        }
                        $colTitle = $this->getLanguageService()->sL('LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:colPos.I.unused');
                        $editParam = '';
                    } else {

typo3/sysext/impexp/Classes/Task/ImportExportTask.php 1 location


                }
                // Render preset list
                $content .= $this->taskObject->renderListMenu($lines);
            } else {
                // No presets found
                $flashMessage = GeneralUtility::makeInstance(
                    FlashMessage::class,
                    $lang->getLL('no-presets'),
                    $lang->getLL('.alttitle'),
                    FlashMessage::NOTICE
                );
                /** @var $flashMessageService \TYPO3\CMS\Core\Messaging\FlashMessageService */
                $flashMessageService = GeneralUtility::makeInstance(FlashMessageService::class);
                /** @var $defaultFlashMessageQueue \TYPO3\CMS\Core\Messaging\FlashMessageQueue */
                $defaultFlashMessageQueue = $flashMessageService->getMessageQueueByIdentifier();
                $defaultFlashMessageQueue->enqueue($flashMessage);
            }
        }
        return $content;
    }

typo3/sysext/recordlist/Classes/RecordList.php 1 location



        if (!empty($dblist->HTMLcode)) {
            $output .= $dblist->HTMLcode;
        } else {
            $flashMessage = GeneralUtility::makeInstance(
                FlashMessage::class,
                $lang->getLL('noRecordsOnThisPage'),
                '',
                FlashMessage::INFO
            );
            /** @var $flashMessageService \TYPO3\CMS\Core\Messaging\FlashMessageService */
            $flashMessageService = GeneralUtility::makeInstance(FlashMessageService::class);
            /** @var $defaultFlashMessageQueue \TYPO3\CMS\Core\Messaging\FlashMessageQueue */
            $defaultFlashMessageQueue = $flashMessageService->getMessageQueueByIdentifier();
            $defaultFlashMessageQueue->enqueue($flashMessage);
        }

        $this->body .= '<form action="' . htmlspecialchars($dblist->listURL()) . '" method="post" name="dblistForm">';
        $this->body .= $output;

typo3/sysext/taskcenter/Classes/Controller/TaskModuleController.php 1 location


                }
            }
            $content .= $this->renderListMenu($tasks, true);
        } else {
            $flashMessage = GeneralUtility::makeInstance(
                FlashMessage::class,
                $this->getLanguageService()->getLL('no-tasks'),
                '',
                FlashMessage::INFO
            );
            /** @var $flashMessageService \TYPO3\CMS\Core\Messaging\FlashMessageService */
            $flashMessageService = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Messaging\FlashMessageService::class);
            /** @var $defaultFlashMessageQueue \TYPO3\CMS\Core\Messaging\FlashMessageQueue */
            $defaultFlashMessageQueue = $flashMessageService->getMessageQueueByIdentifier();
            $defaultFlashMessageQueue->enqueue($flashMessage);
        }
        return $content;
    }


typo3/sysext/core/Classes/DataHandling/DataHandler.php 1 location


            foreach ($res as $deleteId) {
                $this->deleteSpecificPage($deleteId, $forceHardDelete);
            }
        } else {
            /** @var FlashMessage $flashMessage */
            $flashMessage = GeneralUtility::makeInstance(FlashMessage::class, $res, '', FlashMessage::ERROR, true);
            /** @var $flashMessageService FlashMessageService */
            $flashMessageService = GeneralUtility::makeInstance(FlashMessageService::class);
            $flashMessageService->getMessageQueueByIdentifier()->addMessage($flashMessage);
            $this->newlog($res, 1);
        }
    }

    /**

		@@ 1066-1079 (lines=14) @@
1063		// Display "is-locked" message:
1064		if ($command === 'edit') {
1065		$lockInfo = BackendUtility::isRecordLocked($table, $formData['databaseRow']['uid']);
1066		if ($lockInfo) {
1067		/** @var $flashMessage \TYPO3\CMS\Core\Messaging\FlashMessage */
1068		$flashMessage = GeneralUtility::makeInstance(
1069		FlashMessage::class,
1070		$lockInfo['msg'],
1071		'',
1072		FlashMessage::WARNING
1073		);
1074		/** @var $flashMessageService \TYPO3\CMS\Core\Messaging\FlashMessageService */
1075		$flashMessageService = GeneralUtility::makeInstance(FlashMessageService::class);
1076		/** @var $defaultFlashMessageQueue FlashMessageQueue */
1077		$defaultFlashMessageQueue = $flashMessageService->getMessageQueueByIdentifier();
1078		$defaultFlashMessageQueue->enqueue($flashMessage);
1079		}
1080		}
1081
1082		// Record title

		@@ 1104-1114 (lines=11) @@
1101		}
1102		}
1103		if ($columnId === 'unused') {
1104		if (empty($unusedElementsMessage)) {
1105		$unusedElementsMessage = GeneralUtility::makeInstance(
1106		FlashMessage::class,
1107		$this->getLanguageService()->getLL('staleUnusedElementsWarning'),
1108		$this->getLanguageService()->getLL('staleUnusedElementsWarningTitle'),
1109		FlashMessage::WARNING
1110		);
1111		$service = GeneralUtility::makeInstance(FlashMessageService::class);
1112		$queue = $service->getMessageQueueByIdentifier();
1113		$queue->addMessage($unusedElementsMessage);
1114		}
1115		$colTitle = $this->getLanguageService()->sL('LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:colPos.I.unused');
1116		$editParam = '';
1117		} else {

		@@ 166-179 (lines=14) @@
163		}
164		// Render preset list
165		$content .= $this->taskObject->renderListMenu($lines);
166		} else {
167		// No presets found
168		$flashMessage = GeneralUtility::makeInstance(
169		FlashMessage::class,
170		$lang->getLL('no-presets'),
171		$lang->getLL('.alttitle'),
172		FlashMessage::NOTICE
173		);
174		/** @var $flashMessageService \TYPO3\CMS\Core\Messaging\FlashMessageService */
175		$flashMessageService = GeneralUtility::makeInstance(FlashMessageService::class);
176		/** @var $defaultFlashMessageQueue \TYPO3\CMS\Core\Messaging\FlashMessageQueue */
177		$defaultFlashMessageQueue = $flashMessageService->getMessageQueueByIdentifier();
178		$defaultFlashMessageQueue->enqueue($flashMessage);
179		}
180		}
181		return $content;
182		}

		@@ 482-494 (lines=13) @@
479
480		if (!empty($dblist->HTMLcode)) {
481		$output .= $dblist->HTMLcode;
482		} else {
483		$flashMessage = GeneralUtility::makeInstance(
484		FlashMessage::class,
485		$lang->getLL('noRecordsOnThisPage'),
486		'',
487		FlashMessage::INFO
488		);
489		/** @var $flashMessageService \TYPO3\CMS\Core\Messaging\FlashMessageService */
490		$flashMessageService = GeneralUtility::makeInstance(FlashMessageService::class);
491		/** @var $defaultFlashMessageQueue \TYPO3\CMS\Core\Messaging\FlashMessageQueue */
492		$defaultFlashMessageQueue = $flashMessageService->getMessageQueueByIdentifier();
493		$defaultFlashMessageQueue->enqueue($flashMessage);
494		}
495
496		$this->body .= '<form action="' . htmlspecialchars($dblist->listURL()) . '" method="post" name="dblistForm">';
497		$this->body .= $output;

		@@ 386-398 (lines=13) @@
383		}
384		}
385		$content .= $this->renderListMenu($tasks, true);
386		} else {
387		$flashMessage = GeneralUtility::makeInstance(
388		FlashMessage::class,
389		$this->getLanguageService()->getLL('no-tasks'),
390		'',
391		FlashMessage::INFO
392		);
393		/** @var $flashMessageService \TYPO3\CMS\Core\Messaging\FlashMessageService */
394		$flashMessageService = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Messaging\FlashMessageService::class);
395		/** @var $defaultFlashMessageQueue \TYPO3\CMS\Core\Messaging\FlashMessageQueue */
396		$defaultFlashMessageQueue = $flashMessageService->getMessageQueueByIdentifier();
397		$defaultFlashMessageQueue->enqueue($flashMessage);
398		}
399		return $content;
400		}
401

		@@ 5346-5353 (lines=8) @@
5343		foreach ($res as $deleteId) {
5344		$this->deleteSpecificPage($deleteId, $forceHardDelete);
5345		}
5346		} else {
5347		/** @var FlashMessage $flashMessage */
5348		$flashMessage = GeneralUtility::makeInstance(FlashMessage::class, $res, '', FlashMessage::ERROR, true);
5349		/** @var $flashMessageService FlashMessageService */
5350		$flashMessageService = GeneralUtility::makeInstance(FlashMessageService::class);
5351		$flashMessageService->getMessageQueueByIdentifier()->addMessage($flashMessage);
5352		$this->newlog($res, 1);
5353		}
5354		}
5355
5356		/**

TYPO3 / TYPO3.CMS

Code Duplication Length = 8-14 lines in 6 locations

typo3/sysext/backend/Classes/Controller/EditDocumentController.php 1 location

typo3/sysext/backend/Classes/View/PageLayoutView.php 1 location

typo3/sysext/impexp/Classes/Task/ImportExportTask.php 1 location

typo3/sysext/recordlist/Classes/RecordList.php 1 location

typo3/sysext/taskcenter/Classes/Controller/TaskModuleController.php 1 location

typo3/sysext/core/Classes/DataHandling/DataHandler.php 1 location