Conditions | 10 |
Paths | 408 |
Total Lines | 41 |
Code Lines | 27 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
43 | public function invoke($viewHelperClassNameOrInstance, array $arguments, RenderingContextInterface $renderingContext, \Closure $renderChildrenClosure = null) |
||
44 | { |
||
45 | $viewHelperResolver = $renderingContext->getViewHelperResolver(); |
||
46 | if ($viewHelperClassNameOrInstance instanceof ViewHelperInterface) { |
||
47 | $viewHelper = $viewHelperClassNameOrInstance; |
||
48 | } else { |
||
49 | $viewHelper = $viewHelperResolver->createViewHelperInstanceFromClassName($viewHelperClassNameOrInstance); |
||
50 | } |
||
51 | $expectedViewHelperArguments = $viewHelperResolver->getArgumentDefinitionsForViewHelper($viewHelper); |
||
52 | |||
53 | // Rendering process |
||
54 | $evaluatedArguments = []; |
||
55 | $undeclaredArguments = []; |
||
56 | |||
57 | try { |
||
58 | foreach ($expectedViewHelperArguments as $argumentName => $argumentDefinition) { |
||
59 | if (isset($arguments[$argumentName])) { |
||
60 | /** @var NodeInterface|mixed $argumentValue */ |
||
61 | $argumentValue = $arguments[$argumentName]; |
||
62 | $evaluatedArguments[$argumentName] = $argumentValue instanceof NodeInterface ? $argumentValue->evaluate($renderingContext) : $argumentValue; |
||
63 | } else { |
||
64 | $evaluatedArguments[$argumentName] = $argumentDefinition->getDefaultValue(); |
||
65 | } |
||
66 | } |
||
67 | foreach ($arguments as $argumentName => $argumentValue) { |
||
68 | if (!array_key_exists($argumentName, $evaluatedArguments)) { |
||
69 | $undeclaredArguments[$argumentName] = $argumentValue instanceof NodeInterface ? $argumentValue->evaluate($renderingContext) : $argumentValue; |
||
70 | } |
||
71 | } |
||
72 | |||
73 | if ($renderChildrenClosure) { |
||
74 | $viewHelper->setRenderChildrenClosure($renderChildrenClosure); |
||
75 | } |
||
76 | $viewHelper->setRenderingContext($renderingContext); |
||
77 | $viewHelper->setArguments($evaluatedArguments); |
||
78 | $viewHelper->handleAdditionalArguments($undeclaredArguments); |
||
79 | return $viewHelper->initializeArgumentsAndRender(); |
||
80 | } catch (Exception $error) { |
||
81 | return $renderingContext->getErrorHandler()->handleViewHelperError($error); |
||
82 | } |
||
83 | } |
||
84 | } |
||
85 |