Completed
Pull Request — master (#744)
by Georg
28:12 queued 04:03
created
Classes/IndexQueue/Queue.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -856,7 +856,7 @@
 block discarded – undo
856 856
      * Marks an item as failed and causes the indexer to skip the item in the
857 857
      * next run.
858 858
      *
859
-     * @param int|Item $item Either the item's Index Queue
859
+     * @param Item $item Either the item's Index Queue
860 860
      *      uid or the complete item
861 861
      * @param string $errorMessage Error message
862 862
      */
Please login to merge, or discard this patch.
Classes/Plugin/PluginBase.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -438,7 +438,7 @@
 block discarded – undo
438 438
      * This method executes the requested commands and applies the changes to
439 439
      * the template.
440 440
      *
441
-     * @param $actionResult
441
+     * @param string $actionResult
442 442
      * @return string Rendered plugin content
443 443
      */
444 444
     abstract protected function render($actionResult);
Please login to merge, or discard this patch.
Classes/Plugin/Results/NoResultsCommand.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
     /**
81 81
      * Constructs label markers.
82 82
      *
83
-     * @return array Array of label markers.
83
+     * @return string Array of label markers.
84 84
      */
85 85
     protected function getLabelMarkers()
86 86
     {
Please login to merge, or discard this patch.
Classes/System/Configuration/TypoScriptConfiguration.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -544,7 +544,7 @@  discard block
 block discarded – undo
544 544
      *
545 545
      * @param string $configurationName
546 546
      * @param string $defaultIfEmpty
547
-     * @return mixed
547
+     * @return string
548 548
      */
549 549
     public function getIndexQueueInitializerClassByConfigurationName($configurationName, $defaultIfEmpty = 'ApacheSolrForTypo3\\Solr\\IndexQueue\\Initializer\\Record')
550 550
     {
@@ -1237,7 +1237,7 @@  discard block
 block discarded – undo
1237 1237
      * plugin.tx_solr.search.query.allowEmptyQuery
1238 1238
      *
1239 1239
      * @param string $defaultIfEmpty
1240
-     * @return string
1240
+     * @return boolean
1241 1241
      */
1242 1242
     public function getSearchQueryAllowEmptyQuery($defaultIfEmpty = '')
1243 1243
     {
@@ -1299,7 +1299,7 @@  discard block
 block discarded – undo
1299 1299
      *
1300 1300
      * plugin.tx_solr.search.query.returnFields
1301 1301
      *
1302
-     * @param array $defaultIfEmpty
1302
+     * @param string[] $defaultIfEmpty
1303 1303
      * @return array
1304 1304
      */
1305 1305
     public function getSearchQueryReturnFieldsAsArray($defaultIfEmpty = array())
Please login to merge, or discard this patch.
Classes/Typo3PageIndexer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -441,7 +441,7 @@
 block discarded – undo
441 441
      * should be indexed for the current page.
442 442
      *
443 443
      * @param \Apache_Solr_Document $pageDocument The main document representing this page.
444
-     * @param array $existingDocuments An array of documents already created for this page.
444
+     * @param \Apache_Solr_Document[] $existingDocuments An array of documents already created for this page.
445 445
      * @return array An array of additional \Apache_Solr_Document objects to index
446 446
      */
447 447
     protected function getAdditionalDocuments(
Please login to merge, or discard this patch.
Classes/IndexQueue/PageIndexerRequest.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
     /**
205 205
      * Generates the headers to be send with the request.
206 206
      *
207
-     * @return array Array of HTTP headers.
207
+     * @return string[] Array of HTTP headers.
208 208
      */
209 209
     public function getHeaders()
210 210
     {
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
      * Sets a request's parameter and its value.
325 325
      *
326 326
      * @param string $parameter Parameter name
327
-     * @param mixed $value Parameter value.
327
+     * @param string $value Parameter value.
328 328
      */
329 329
     public function setParameter($parameter, $value)
330 330
     {
Please login to merge, or discard this patch.
Classes/Domain/Search/LastSearches/LastSearchesService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
     /**
135 135
      * Gets the last searched keywords from the database
136 136
      *
137
-     * @param int|bool $limit
137
+     * @param integer $limit
138 138
      * @return array An array containing the last searches of the current user
139 139
      */
140 140
     protected function getLastSearchesFromDatabase($limit = false)
Please login to merge, or discard this patch.
Classes/Site.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -274,7 +274,7 @@
 block discarded – undo
274 274
      * Generates a list of page IDs in this site. Attention, this includes
275 275
      * all page types! Deleted pages are not included.
276 276
      *
277
-     * @param int|string $rootPageId Page ID from where to start collection sub pages
277
+     * @param integer $rootPageId Page ID from where to start collection sub pages
278 278
      * @param int $maxDepth Maximum depth to decend into the site tree
279 279
      * @return array Array of pages (IDs) in this site
280 280
      */
Please login to merge, or discard this patch.
Classes/SolrService.php 1 patch
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     /**
129 129
      * Returns the current time in milliseconds.
130 130
      *
131
-     * @return int
131
+     * @return double
132 132
      */
133 133
     protected function getMilliseconds()
134 134
     {
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
      *
175 175
      * Also does not report the time, see https://forge.typo3.org/issues/64551
176 176
      *
177
-     * @param float|int $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
177
+     * @param integer $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
178 178
      * @return bool TRUE if Solr can be reached, FALSE if not
179 179
      */
180 180
     public function ping($timeout = 2)
@@ -186,8 +186,8 @@  discard block
 block discarded – undo
186 186
     /**
187 187
      * Call the /admin/ping servlet, can be used to get the runtime of a ping request.
188 188
      *
189
-     * @param float|int $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
190
-     * @return int runtime in milliseconds
189
+     * @param integer $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
190
+     * @return double runtime in milliseconds
191 191
      * @throws \ApacheSolrForTypo3\Solr\PingFailedException
192 192
      */
193 193
     public function getPingRoundTripRuntime($timeout = 2)
@@ -581,7 +581,7 @@  discard block
 block discarded – undo
581 581
      * a complete and well formed "delete" xml document
582 582
      *
583 583
      * @param string $rawPost Expected to be utf-8 encoded xml document
584
-     * @param float|int $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
584
+     * @param integer $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
585 585
      * @return \Apache_Solr_Response
586 586
      */
587 587
     public function delete($rawPost, $timeout = 3600)
@@ -678,7 +678,7 @@  discard block
 block discarded – undo
678 678
     /**
679 679
      * Add list of synonyms for base word to managed synonyms map
680 680
      *
681
-     * @param $baseWord
681
+     * @param string $baseWord
682 682
      * @param array $synonyms
683 683
      *
684 684
      * @return \Apache_Solr_Response
@@ -699,7 +699,7 @@  discard block
 block discarded – undo
699 699
     /**
700 700
      * Remove a synonym from the synonyms map
701 701
      *
702
-     * @param $baseWord
702
+     * @param string $baseWord
703 703
      * @return \Apache_Solr_Response
704 704
      * @throws \Apache_Solr_InvalidArgumentException
705 705
      */
@@ -715,7 +715,7 @@  discard block
 block discarded – undo
715 715
     /**
716 716
      * Central method for making a HTTP DELETE operation against the Solr server
717 717
      *
718
-     * @param $url
718
+     * @param string $url
719 719
      * @param bool|float $timeout Read timeout in seconds
720 720
      * @return \Apache_Solr_Response
721 721
      */
Please login to merge, or discard this patch.