Passed
Push — master ( fa56d4...93fed3 )
by Timo
55s
created

OptionsFacetParser::parse()   C

Complexity

Conditions 7
Paths 16

Size

Total Lines 51
Code Lines 32

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 25
CRAP Score 7

Importance

Changes 0
Metric Value
dl 0
loc 51
ccs 25
cts 25
cp 1
rs 6.9743
c 0
b 0
f 0
cc 7
eloc 32
nc 16
nop 3
crap 7

How to fix   Long Method   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
namespace ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Options;
3
4
/*
5
 * This file is part of the TYPO3 CMS project.
6
 *
7
 * It is free software; you can redistribute it and/or modify it under
8
 * the terms of the GNU General Public License, either version 2
9
 * of the License, or any later version.
10
 *
11
 * For the full copyright and license information, please read the
12
 * LICENSE.txt file that was distributed with this source code.
13
 *
14
 * The TYPO3 project - inspiring people to share!
15
 */
16
17
use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetParser;
18
use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
19
20
/**
21
 * Class OptionsFacetParser
22
 */
23
class OptionsFacetParser extends AbstractFacetParser
24
{
25
    /**
26
     * @param SearchResultSet $resultSet
27
     * @param string $facetName
28
     * @param array $facetConfiguration
29
     * @return OptionsFacet|null
30
     */
31 40
    public function parse(SearchResultSet $resultSet, $facetName, array $facetConfiguration)
32
    {
33 40
        $response = $resultSet->getResponse();
34 40
        $fieldName = $facetConfiguration['field'];
35 40
        $label = $this->getPlainLabelOrApplyCObject($facetConfiguration);
36 40
        $optionsFromSolrResponse = isset($response->facet_counts->facet_fields->{$fieldName}) ? get_object_vars($response->facet_counts->facet_fields->{$fieldName}) : [];
37 40
        $optionsFromRequest = $this->getActiveFacetValuesFromRequest($resultSet, $facetName);
38
39 40
        $hasOptionsInResponse = !empty($optionsFromSolrResponse);
40 40
        $hasSelectedOptionsInRequest = count($optionsFromRequest) > 0;
41 40
        $hasNoOptionsToShow = !$hasOptionsInResponse && !$hasSelectedOptionsInRequest;
42 40
        $hideEmpty = !$resultSet->getUsedSearchRequest()->getContextTypoScriptConfiguration()->getSearchFacetingShowEmptyFacetsByName($facetName);
43
44 40
        if ($hasNoOptionsToShow && $hideEmpty) {
45 3
            return null;
46
        }
47
48
        /** @var $facet OptionsFacet */
49 38
        $facet = $this->objectManager->get(
50 38
            OptionsFacet::class,
51
            $resultSet,
0 ignored issues
show
Unused Code introduced by
The call to ObjectManagerInterface::get() has too many arguments starting with $resultSet.

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress.

In this case you can add the @ignore PhpDoc annotation to the duplicate definition and it will be ignored.

Loading history...
52
            $facetName,
53
            $fieldName,
54
            $label,
55
            $facetConfiguration
56
        );
57
58 38
        $hasActiveOptions = count($optionsFromRequest) > 0;
59 38
        $facet->setIsUsed($hasActiveOptions);
60 38
        $facet->setIsAvailable($hasOptionsInResponse);
61
62 38
        $optionsToCreate = $this->getMergedFacetValueFromSearchRequestAndSolrResponse($optionsFromSolrResponse, $optionsFromRequest);
63 38
        foreach ($optionsToCreate as $optionsValue => $count) {
64 38
            if ($this->getIsExcludedFacetValue($optionsValue, $facetConfiguration)) {
65 38
                continue;
66 38
            }
67
68
            $isOptionsActive = in_array($optionsValue, $optionsFromRequest);
69
            $label = $this->getLabelFromRenderingInstructions($optionsValue, $count, $facetName, $facetConfiguration);
70
            $facet->addOption(new Option($facet, $label, $optionsValue, $count, $isOptionsActive));
71
        }
72 38
73
        // after all options have been created we apply a manualSortOrder if configured
74 38
        // the sortBy (lex,..) is done by the solr server and triggered by the query, therefore it does not
75
        // need to be handled in the frontend.
76 38
        $facet = $this->applyManualSortOrder($facet, $facetConfiguration);
77
78
        $facet = $this->applyReverseOrder($facet, $facetConfiguration);
79
80
        return $facet;
81
    }
82
}
83