StrategyFactory::getByTable() - Code Metrics - Inspection of "[BUGFIX:P_main] Update GarbageCollector.php" - TYPO3-Solr/ext-solr - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#3280)

by Rafael

created 2022-07-07 11:16 UTC

StrategyFactory::getByTable() A

↳ Parent: StrategyFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	4
dl	0
loc	6
ccs	5
cts	5
cp	1
rs	10
c	1
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php

declare(strict_types=1);

/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

namespace ApacheSolrForTypo3\Solr\Domain\Index\Queue\GarbageRemover;

use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Class StrategyFactory
 */
class StrategyFactory
{
    /**
     * @param string $table
     * @return PageStrategy|RecordStrategy
     */
    public static function getByTable(string $table): AbstractStrategy
    {
        $isPageRelated = in_array($table, ['tt_content', 'pages']);
        return $isPageRelated
            ? GeneralUtility::makeInstance(PageStrategy::class)
            : GeneralUtility::makeInstance(RecordStrategy::class);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the TYPO3 CMS project.
7		*
8		* It is free software; you can redistribute it and/or modify it under
9		* the terms of the GNU General Public License, either version 2
10		* of the License, or any later version.
11		*
12		* For the full copyright and license information, please read the
13		* LICENSE.txt file that was distributed with this source code.
14		*
15		* The TYPO3 project - inspiring people to share!
16		*/
17
18		namespace ApacheSolrForTypo3\Solr\Domain\Index\Queue\GarbageRemover;
19
20		use TYPO3\CMS\Core\Utility\GeneralUtility;
21
22		/**
23		* Class StrategyFactory
24		*/
25		class StrategyFactory
26		{
27		/**
28		* @param string $table
29		* @return PageStrategy\|RecordStrategy
30		*/
31	27	public static function getByTable(string $table): AbstractStrategy
32		{
33	27	$isPageRelated = in_array($table, ['tt_content', 'pages']);
34	27	return $isPageRelated
35	23	? GeneralUtility::makeInstance(PageStrategy::class)
36	27	: GeneralUtility::makeInstance(RecordStrategy::class);
37		}
38		}
39

TYPO3-Solr / ext-solr

Pull Request — main (#3280)

StrategyFactory::getByTable() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like