Passed
Pull Request — master (#1668)
by Timo
04:12
created
Classes/Domain/Search/SearchRequestBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@
 block discarded – undo
175 175
      * This methods sets the page argument to an expected positive integer value in the arguments array.
176 176
      *
177 177
      * @param array $arguments
178
-     * @return array
178
+     * @return integer
179 179
      */
180 180
     protected function adjustPageArgumentToPositiveInteger(array $arguments)
181 181
     {
Please login to merge, or discard this patch.
Classes/Domain/Search/Suggest/SuggestService.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
      *
79 79
      * @param SearchRequest $searchRequest
80 80
      * @param string $additionalFilters
81
-     * @return array
81
+     * @return string
82 82
      */
83 83
     public function getSuggestions(SearchRequest $searchRequest, $additionalFilters) : array
84 84
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -256,7 +256,7 @@
 block discarded – undo
256 256
      * @param string $additionalFilters
257 257
      * @return SuggestQuery
258 258
      */
259
-    protected function buildSuggestQuery(string $queryString ,string $additionalFilters) : SuggestQuery
259
+    protected function buildSuggestQuery(string $queryString, string $additionalFilters) : SuggestQuery
260 260
     {
261 261
         $suggestQuery = GeneralUtility::makeInstance(SuggestQuery::class, $queryString);
262 262
 
Please login to merge, or discard this patch.
Classes/Domain/Search/ResultSet/SearchResultSetService.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -421,7 +421,7 @@
 block discarded – undo
421 421
 
422 422
         }
423 423
 
424
-        if($response === null) {
424
+        if ($response === null) {
425 425
             throw new SolrIncompleteResponseException('The response retrieved from solr was incomplete', 1505989678);
426 426
         }
427 427
 
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -26,8 +26,6 @@
 block discarded – undo
26 26
  ***************************************************************/
27 27
 
28 28
 use ApacheSolrForTypo3\Solr\Domain\Search\Query\ParameterBuilder\QueryFields;
29
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Result\Parser\DefaultParser;
30
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Result\Parser\DefaultResultParser;
31 29
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Result\Parser\ResultParserRegistry;
32 30
 use ApacheSolrForTypo3\Solr\Domain\Search\SearchRequest;
33 31
 use ApacheSolrForTypo3\Solr\Domain\Search\SearchRequestAware;
Please login to merge, or discard this patch.
Classes/Domain/Search/ResultSet/Result/Parser/DefaultResultParser.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
     /**
64 64
      * @param \Apache_Solr_Response $response
65 65
      * @param SearchResultSet $resultSet
66
-     * @return mixed
66
+     * @return boolean
67 67
      */
68 68
     public function canParse(\Apache_Solr_Response $response, SearchResultSet $resultSet)
69 69
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
         }
49 49
 
50 50
         $documents = $parsedData->response->docs;
51
-        if(!$useRawDocuments) {
51
+        if (!$useRawDocuments) {
52 52
             $documents = $this->applyHtmlSpecialCharsOnAllFields($documents);
53 53
         }
54 54
 
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
     public function canParse(\Apache_Solr_Response $response, SearchResultSet $resultSet)
69 69
     {
70 70
         // This parsers should not be used when grouping is enabled
71
-        if($this->typoScriptConfiguration->getSearchGrouping())
71
+        if ($this->typoScriptConfiguration->getSearchGrouping())
72 72
         {
73 73
             return false;
74 74
         }
Please login to merge, or discard this patch.
Classes/ViewHelpers/Widget/Controller/ResultPaginateController.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,6 @@
 block discarded – undo
16 16
 
17 17
 use ApacheSolrForTypo3\Solr\Widget\AbstractWidgetController;
18 18
 use TYPO3\CMS\Core\Utility\ArrayUtility;
19
-use TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface;
20 19
 
21 20
 /**
22 21
  * Class ResultPaginateController
Please login to merge, or discard this patch.
Classes/System/Data/AbstractCollection.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
      */
148 148
     public function offsetSet($offset, $value)
149 149
     {
150
-        if($offset === null) {
150
+        if ($offset === null) {
151 151
             $this->data[] = $value;
152 152
             return;
153 153
         }
Please login to merge, or discard this patch.