TYPO3-Solr / ext-solr

Classes/Backend/SolrModule/IndexMaintenanceModuleController.php

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 
 use ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration;
 use ApacheSolrForTypo3\Solr\Tests\Unit\UnitTest;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**
  * Testcase to check if the configuration object can be used as expected

Classes/Domain/Search/Statistics/StatisticsRepository.php

Doc Comments +1 added lines

@@ -201,6 +201,7 @@
      *
      * @param array $mergedRow
      * @param array $statisticsRow
+     * @param string $fieldName
      * @return float|int
      */
     protected function getAverageFromField(array &$mergedRow, array $statisticsRow,  $fieldName)

Spacing +9 added lines, -9 removed lines

@@ -46,9 +46,9 @@ 
     public function getSearchStatistics($rootPageId, $days = 30, $limit = 10)
     {
         $now = time();
-        $timeStart = (int) ($now - 86400 * intval($days)); // 86400 seconds/day
-        $rootPageId = (int) $rootPageId;
-        $limit = (int) $limit;
+        $timeStart = (int)($now - 86400 * intval($days)); // 86400 seconds/day
+        $rootPageId = (int)$rootPageId;
+        $limit = (int)$limit;
 
         $statisticsRows = $this->getDatabase()->exec_SELECTgetRows(
             'keywords, count(keywords) as count, num_found as hits',
@@ -66,7 +66,7 @@ 
             $sumCount += $statisticsRow['count'];
         }
 
-        $statisticsRows = array_map(function ($row) use ($sumCount) {
+        $statisticsRows = array_map(function($row) use ($sumCount) {
             $row['percent'] = $row['count'] * 100 / $sumCount;
 
             return $row;
@@ -112,9 +112,9 @@ 
      */
     protected function getTopKeyWordsWithOrWithoutHits($rootPageId, $days = 30, $limit, $withoutHits)
     {
-        $rootPageId = (int) $rootPageId;
-        $limit = (int) $limit;
-        $withoutHits = (bool) $withoutHits;
+        $rootPageId = (int)$rootPageId;
+        $limit = (int)$limit;
+        $withoutHits = (bool)$withoutHits;
 
         $now = time();
         $timeStart = $now - 86400 * intval($days); // 86400 seconds/day
@@ -159,7 +159,7 @@ 
 
                 // for the hits we need to take the average
             $avgHits = $this->getAverageFromField($mergedRow, $statisticsRow, 'hits');
-            $mergedRow['hits'] = (int) $avgHits;
+            $mergedRow['hits'] = (int)$avgHits;
 
                 // for the count we need to take the sum, because it's the sum of searches
             $mergedRow['count'] = $mergedRow['count'] + $statisticsRow['count'];
@@ -203,7 +203,7 @@ 
      * @param array $statisticsRow
      * @return float|int
      */
-    protected function getAverageFromField(array &$mergedRow, array $statisticsRow,  $fieldName)
+    protected function getAverageFromField(array &$mergedRow, array $statisticsRow, $fieldName)
     {
         // when this is the first row we can take it.
         if ($mergedRow['mergedrows'] === 1) {

Classes/GarbageCollector.php

Doc Comments +8 added lines, -8 removed lines

@@ -169,7 +169,7 @@ 
     }
 
     /**
-     * @param $table
+     * @param string $table
      * @param $uid
      * @param $changedFields
      * @param $indexQueue
@@ -349,7 +349,7 @@ 
      *
      * @param string $table The record's table name.
      * @param integer $record The record's uid.
-     * @return array The cleaned record
+     * @return integer The cleaned record
      */
     protected function normalizeFrontendGroupField($table, $record)
     {
@@ -418,7 +418,7 @@ 
      * determines whether it is set on the current record.
      *
      * @param string $table The table name.
-     * @param array $record An array with record fields that may affect visibility.
+     * @param integer $record An array with record fields that may affect visibility.
      * @return boolean True if the record is hidden, FALSE otherwise.
      */
     protected function isHidden($table, $record)
@@ -439,7 +439,7 @@ 
      * making the record invisible on the website.
      *
      * @param string $table The table name.
-     * @param array $record An array with record fields that may affect visibility.
+     * @param integer $record An array with record fields that may affect visibility.
      * @return boolean True if the record's start time is in the future, FALSE otherwise.
      */
     protected function isStartTimeInFuture($table, $record)
@@ -459,7 +459,7 @@ 
      * indexed already.
      *
      * @param string $table The table name.
-     * @param array $record An array with record fields that may affect visibility.
+     * @param integer $record An array with record fields that may affect visibility.
      * @return boolean True if the record is marked as being indexed
      */
     protected function isMarkedAsIndexed($table, $record)
@@ -474,7 +474,7 @@ 
      * the record invisible to at least some people.
      *
      * @param string $table The table name.
-     * @param array $record An array with record fields that may affect visibility.
+     * @param integer $record An array with record fields that may affect visibility.
      * @return boolean TRUE if frontend groups have been removed from access to the record, FALSE otherwise.
      */
     protected function hasFrontendGroupsRemoved($table, $record)
@@ -501,7 +501,7 @@ 
     /**
      * Checks whether the page has been excluded from searching.
      *
-     * @param array $record An array with record fields that may affect visibility.
+     * @param integer $record An array with record fields that may affect visibility.
      * @return boolean True if the page has been excluded from searching, FALSE otherwise
      */
     protected function isPageExcludedFromSearch($record)
@@ -513,7 +513,7 @@ 
      * Checks whether a page has a page type that can be indexed.
      * Currently standard pages and mount pages can be indexed.
      *
-     * @param array $record A page record
+     * @param integer $record A page record
      * @return boolean TRUE if the page can be indexed according to its page type, FALSE otherwise
      */
     protected function isIndexablePageType(array $record)

Classes/IndexQueue/PageIndexerRequest.php

Doc Comments +2 added lines, -2 removed lines

@@ -204,7 +204,7 @@ 
     /**
      * Generates the headers to be send with the request.
      *
-     * @return array Array of HTTP headers.
+     * @return string[] Array of HTTP headers.
      */
     public function getHeaders()
     {
@@ -324,7 +324,7 @@ 
      * Sets a request's parameter and its value.
      *
      * @param string $parameter Parameter name
-     * @param mixed $value Parameter value.
+     * @param string $value Parameter value.
      */
     public function setParameter($parameter, $value)
     {

Classes/SuggestQuery.php

Indentation +3 added lines, -3 removed lines

@@ -39,9 +39,9 @@
      */
     protected $configuration;
 
-     /**
-     * @var string
-     */
+        /**
+         * @var string
+         */
     protected $prefix;
 
     /**

Spacing +1 added lines, -1 removed lines

@@ -157,7 +157,7 @@
      */
     public function __construct($keywords, $solrConfiguration = null)
     {
-        $keywords = (string) $keywords;
+        $keywords = (string)$keywords;
         if ($solrConfiguration == null) {
             $this->solrConfiguration = Util::getSolrConfiguration();
         } else {