TYPO3-Solr / ext-solr

Classes/IndexQueue/Initializer/Page.php

Spacing +2 added lines, -2 removed lines

@@ -287,8 +287,8 @@
 
         $mountedPagesIdsWithQueueItems = [];
         foreach ($queueItemsOfExistingMountPoints as $id => $queueItemsOfExistingMountPoint) {
-            if (((int) $queueItemsOfExistingMountPoint['queueItemCount']) > 0) {
-                $mountedPagesIdsWithQueueItems[] = (int) $id;
+            if (((int)$queueItemsOfExistingMountPoint['queueItemCount']) > 0) {
+                $mountedPagesIdsWithQueueItems[] = (int)$id;
             }
         }
 

Classes/SolrService.php

Doc Comments +4 added lines, -4 removed lines

@@ -232,7 +232,7 @@ 
      *
      * Also does not report the time, see https://forge.typo3.org/issues/64551
      *
-     * @param float|int $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
+     * @param integer $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
      * @param boolean $useCache indicates if the ping result should be cached in the instance or not
      * @return bool TRUE if Solr can be reached, FALSE if not
      */
@@ -245,7 +245,7 @@ 
     /**
      * Call the /admin/ping servlet, can be used to get the runtime of a ping request.
      *
-     * @param float|int $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
+     * @param integer $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
      * @param boolean $useCache indicates if the ping result should be cached in the instance or not
      * @return double runtime in milliseconds
      * @throws \ApacheSolrForTypo3\Solr\PingFailedException
@@ -482,7 +482,7 @@ 
      *
      * @param string $url
      * @param float|bool $timeout Read timeout in seconds
-     * @return \Apache_Solr_Response
+     * @return string
      */
     protected function _sendRawGet($url, $timeout = false)
     {
@@ -656,7 +656,7 @@ 
      * a complete and well formed "delete" xml document
      *
      * @param string $rawPost Expected to be utf-8 encoded xml document
-     * @param float|int $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
+     * @param integer $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
      * @return \Apache_Solr_Response
      */
     public function delete($rawPost, $timeout = 3600)

Spacing +3 added lines, -3 removed lines

@@ -300,7 +300,7 @@ 
      */
     protected function performPingRequest($timeout = 2, $useCache = true)
     {
-        $cacheKey = (string) ($this);
+        $cacheKey = (string)($this);
         if ($useCache && isset(static::$pingCache[$cacheKey])) {
             return static::$pingCache[$cacheKey];
         }
@@ -629,7 +629,7 @@ 
             $solrconfigXmlUrl = $this->_scheme . '://'
                 . $this->_host . ':' . $this->_port
                 . $this->_path . 'admin/file/?file=solrconfig.xml';
-            $response= $this->_sendRawGet($solrconfigXmlUrl);
+            $response = $this->_sendRawGet($solrconfigXmlUrl);
 
             $solrconfigXml = simplexml_load_string($response->getRawResponse());
             if ($solrconfigXml === false) {
@@ -892,7 +892,7 @@ 
      */
     public function getCoreName()
     {
-        return (string) array_pop(explode('/', trim($this->_path, '/')));
+        return (string)array_pop(explode('/', trim($this->_path, '/')));
     }
 
     /**

Classes/System/DateTime/FormatService.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
         }
 
         // try to create DateTime object
-        $timezone = is_null($timezone) ?  new DateTimeZone(date_default_timezone_get()) : $timezone;
+        $timezone = is_null($timezone) ? new DateTimeZone(date_default_timezone_get()) : $timezone;
         return $this->getFormattedDate($input, $inputFormat, $outputFormat, $timezone);
     }
 

Classes/Domain/Index/IndexService.php

Spacing +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
         $this->configuration = $site->getSolrConfiguration();
         $this->site = $site;
         $this->indexQueue = is_null($queue) ? GeneralUtility::makeInstance(Queue::class) : $queue;
-        $this->signalSlotDispatcher = is_null($dispatcher)  ? GeneralUtility::makeInstance(Dispatcher::class) : $dispatcher;
+        $this->signalSlotDispatcher = is_null($dispatcher) ? GeneralUtility::makeInstance(Dispatcher::class) : $dispatcher;
     }
 
     /**
@@ -140,7 +140,7 @@ 
     protected function generateIndexingErrorLog(Item $itemToIndex, \Exception $e)
     {
         $message = 'Failed indexing Index Queue item ' . $itemToIndex->getIndexQueueUid();
-        $data = [   'code' => $e->getCode(),
+        $data = ['code' => $e->getCode(),
                     'message' => $e->getMessage(),
                     'trace' => $e->getTrace(),
                     'item' => (array)$itemToIndex];

Classes/ConnectionManager.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use ApacheSolrForTypo3\Solr\NoSolrConnectionFoundException;
 use ApacheSolrForTypo3\Solr\Site;
 use ApacheSolrForTypo3\Solr\SolrService;
-use ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration;
 use ApacheSolrForTypo3\Solr\System\Page\Rootline;
 use TYPO3\CMS\Backend\Routing\UriBuilder;
 use TYPO3\CMS\Backend\Toolbar\ClearCacheActionsHookInterface;

Classes/Backend/SolrModule/IndexMaintenanceModuleController.php

Spacing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
 
         if ($coresReloaded) {
             $this->addFlashMessage(
-                'Core configuration reloaded ('.implode(', ', $reloadedCores).').',
+                'Core configuration reloaded (' . implode(', ', $reloadedCores) . ').',
                 '',
                 FlashMessage::OK
             );

Classes/IndexQueue/FrontendHelper/PageIndexer.php

Spacing +1 added lines, -1 removed lines

@@ -173,7 +173,7 @@
             'auth', // service type
             AuthorizationService::class,
             // service key
-            [ // service meta data
+            [// service meta data
                 'title' => 'Solr Indexer Authorization',
                 'description' => 'Authorizes the Solr Index Queue indexer to access protected pages.',
 

Classes/System/TCA/TCAService.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
      */
     public function __construct($TCA = null)
     {
-        $this->tca = (array) (is_null($TCA) ? $GLOBALS['TCA'] : $TCA);
+        $this->tca = (array)(is_null($TCA) ? $GLOBALS['TCA'] : $TCA);
     }
 
     /**

Classes/Util.php

Doc Comments +4 added lines, -4 removed lines

@@ -243,7 +243,7 @@ 
      * @param int $pageId Id of the (root) page to get the Solr configuration from.
      * @param string $path The TypoScript configuration path to retrieve.
      * @param bool $initializeTsfe Optionally initializes a full TSFE to get the configuration, defaults to FALSE
-     * @param int|bool $language System language uid or FALSE to disable language usage, optional, defaults to 0
+     * @param integer $language System language uid or FALSE to disable language usage, optional, defaults to 0
      * @param bool $useTwoLevelCache Flag to enable the two level cache for the typoscript configuration array
      * @return TypoScriptConfiguration The Solr configuration for the requested tree.
      */
@@ -343,9 +343,9 @@ 
 
     /**
      * This function is used to retrieve the configuration from an existing TSFE instance
-     * @param $pageId
-     * @param $path
-     * @param $language
+     * @param integer $pageId
+     * @param string $path
+     * @param integer $language
      * @return mixed
      */
     private static function getConfigurationFromExistingTSFE($pageId, $path, $language)