ApacheSolrForTypo3\Solr\Eid\ApiEid

Complexity

Total Complexity

3

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	main()	0	23	3

<?php

/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

namespace ApacheSolrForTypo3\Solr\Eid;

use ApacheSolrForTypo3\Solr\Api;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use TYPO3\CMS\Core\Http\Response;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\Utility\HttpUtility;

class ApiEid
{
    public function main(ServerRequestInterface $request): ResponseInterface
    {
        $api = GeneralUtility::_GP('api');
        $apiKey = trim(GeneralUtility::_GP('apiKey'));

It seems like TYPO3\CMS\Core\Utility\GeneralUtility::_GP('apiKey') can also be of type null; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

        if (!Api::isValidApiKey($apiKey)) {
            header(HttpUtility::HTTP_STATUS_403);
            header('Content-Type: application/json; charset=utf-8');
            echo json_encode(['errorMessage' => 'Invalid API key']);
        } else {
            switch ($api) {
                case 'siteHash':
                    include('SiteHash.php');
                    break;

                default:
                    header(HttpUtility::HTTP_STATUS_400);
                    header('Content-Type: application/json; charset=utf-8');
                    echo json_encode(['errorMessage' => 'You must provide an available API method, e.g. siteHash.']);
                    break;
            }
        }
        return new Response();
    }
}