IndexQueueModuleController::initializeIndexQueueAction() - Code Metrics - Inspection of "[BUGFIX] Selecting a page outside a siteroot do no..." - TYPO3-Solr/ext-solr - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1317)

unknown

created 2017-06-07 09:15 UTC

initializeIndexQueueAction() B

↳ Parent: IndexQueueModuleController

Complexity

Conditions	6
Paths	12

Size

Total Lines	48
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
dl	0
loc	48
ccs	0
cts	41
cp	0
rs	8.551
c	0
b	0
f	0
cc	6
eloc	31
nc	12
nop	0
crap	42

<?php
namespace ApacheSolrForTypo3\Solr\Controller\Backend\Search;

/***************************************************************
 *  Copyright notice
 *
 *  (c) 2013-2015 Ingo Renner <[email protected]>
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/

use ApacheSolrForTypo3\Solr\Backend\IndexingConfigurationSelectorField;
use ApacheSolrForTypo3\Solr\Domain\Index\IndexService;
use ApacheSolrForTypo3\Solr\IndexQueue\Queue;
use TYPO3\CMS\Backend\View\BackendTemplateView;
use TYPO3\CMS\Core\Messaging\FlashMessage;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Extbase\Mvc\View\ViewInterface;
use TYPO3\CMS\Extbase\Utility\LocalizationUtility;

/**
 * Index Queue Module
 *
 * @author Ingo Renner <[email protected]>
 * @property BackendTemplateView $view
 */
class IndexQueueModuleController extends AbstractModuleController
{

    /**
     * Module name, used to identify a module f.e. in URL parameters.
     *
     * @var string
     */
    protected $moduleName = 'IndexQueue';

    /**
     * Module title, shows up in the module menu.
     *
     * @var string
     */
    protected $moduleTitle = 'Index Queue';

    /**
     * @var Queue
     */
    protected $indexQueue;

    /**
     * Initializes the controller before invoking an action method.
     */
    protected function initializeAction()
    {
        parent::initializeAction();
        $this->indexQueue = GeneralUtility::makeInstance(Queue::class);
    }

    /**
     * Set up the doc header properly here
     *
     * @param ViewInterface $view
     * @return void
     */
    protected function initializeView(ViewInterface $view)
    {
        parent::initializeView($view);
    }

    /**
     * Lists the available indexing configurations
     *
     * @return void
     */
    public function indexAction()
    {
        if ($this->selectedSite === null) {
            $this->view->assignMultiple([
                'can_not_proceed' => true,
                'pageUID' => $this->selectedPageUID
            ]);
            return;
        }

        $statistics = $this->indexQueue->getStatisticsBySite($this->selectedSite);
        $this->view->assign('indexQueueInitializationSelector', $this->getIndexQueueInitializationSelector());
        $this->view->assign('indexqueue_statistics', $statistics);
        $this->view->assign('indexqueue_errors', $this->indexQueue->getErrorsBySite($this->selectedSite));
    }

    /**
     * Renders a field to select which indexing configurations to initialize.
     *
     * Uses TCEforms.
     *
     * @return string Markup for the select field
     */
    protected function getIndexQueueInitializationSelector()
    {
        $selector = GeneralUtility::makeInstance(IndexingConfigurationSelectorField::class, $this->selectedSite);
        $selector->setFormElementName('tx_solr-index-queue-initialization');

        return $selector->render();
    }

    /**
     * Initializes the Index Queue for selected indexing configurations
     *
     * @return void
     */
    public function initializeIndexQueueAction()
    {
        $initializedIndexingConfigurations = [];

        $indexingConfigurationsToInitialize = GeneralUtility::_POST('tx_solr-index-queue-initialization');
        if ((!empty($indexingConfigurationsToInitialize)) && (is_array($indexingConfigurationsToInitialize))) {
            // initialize selected indexing configuration
            foreach ($indexingConfigurationsToInitialize as $indexingConfigurationName) {
                $initializedIndexingConfiguration = $this->indexQueue->initialize(
                    $this->selectedSite,
                    $indexingConfigurationName
                );

                // track initialized indexing configurations for the flash message
                $initializedIndexingConfigurations = array_merge(
                    $initializedIndexingConfigurations,
                    $initializedIndexingConfiguration
                );
            }
        } else {
            $messageLabel = 'solr.backend.index_queue_module.flashmessage.initialize.no_selection';
            $titleLabel = 'solr.backend.index_queue_module.flashmessage.not_initialized.title';
            $this->addFlashMessage(
                LocalizationUtility::translate($messageLabel, 'Solr'),
                LocalizationUtility::translate($titleLabel, 'Solr'),
                FlashMessage::WARNING
            );
        }

        $messagesForConfigurations = [];
        foreach (array_keys($initializedIndexingConfigurations) as $indexingConfigurationName) {
            $itemCount = $this->indexQueue->getStatisticsBySite($this->selectedSite, $indexingConfigurationName)->getTotalCount();
            $messagesForConfigurations[] = $indexingConfigurationName . ' (' . $itemCount . ' records)';
        }

        if (!empty($initializedIndexingConfigurations)) {
            $messageLabel = 'solr.backend.index_queue_module.flashmessage.initialize.success';
            $titleLabel = 'solr.backend.index_queue_module.flashmessage.initialize.title';
            $this->addFlashMessage(
                LocalizationUtility::translate($messageLabel, 'Solr',
                    [implode(', ', $messagesForConfigurations)]),
                LocalizationUtility::translate($titleLabel, 'Solr'),
                FlashMessage::OK
            );
        }

        $this->redirect('index');
    }

    /**
     * Removes all errors in the index queue list. So that the items can be indexed again.
     *
     * @return void
     */
    public function resetLogErrorsAction()
    {
        $resetResult = $this->indexQueue->resetAllErrors();

        $label = 'solr.backend.index_queue_module.flashmessage.success.reset_errors';
        $severity = FlashMessage::OK;
        if (!$resetResult) {
            $label = 'solr.backend.index_queue_module.flashmessage.error.reset_errors';
            $severity = FlashMessage::ERROR;
        }

        $this->addFlashMessage(
            LocalizationUtility::translate($label, 'Solr'),
            LocalizationUtility::translate('solr.backend.index_queue_module.flashmessage.title', 'Solr'),
            $severity
        );

        $this->redirect('index');
    }

    /**
     * Shows the error message for one queue item.
     *
     * @param int $indexQueueItemId
     * @return void
     */
    public function showErrorAction(int $indexQueueItemId)
    {
        if (is_null($indexQueueItemId)) {
            // add a flash message and quit
            $label = 'solr.backend.index_queue_module.flashmessage.error.no_queue_item_for_queue_error';
            $severity = FlashMessage::ERROR;
            $this->addFlashMessage(
                LocalizationUtility::translate($label, 'Solr'),
                LocalizationUtility::translate('solr.backend.index_queue_module.flashmessage.title',
                    'Solr'),
                $severity
            );

            return;
        }

        $item = $this->indexQueue->getItem($indexQueueItemId);
        $this->view->assign('indexQueueItem', $item);
    }

    /**
     * Indexes a few documents with the index service.
     * @return void
     */
    public function doIndexingRunAction()
    {
        /** @var $indexService \ApacheSolrForTypo3\Solr\Domain\Index\IndexService */
        $indexService = GeneralUtility::makeInstance(IndexService::class, $this->selectedSite);
        $indexWithoutErrors = $indexService->indexItems(10);

        $label = 'solr.backend.index_queue_module.flashmessage.success.index_manual';
        $severity = FlashMessage::OK;
        if (!$indexWithoutErrors) {
            $label = 'solr.backend.index_queue_module.flashmessage.error.index_manual';
            $severity = FlashMessage::ERROR;
        }

        $this->addFlashMessage(
            LocalizationUtility::translate($label, 'Solr'),
            LocalizationUtility::translate('solr.backend.index_queue_module.flashmessage.index_manual', 'Solr'),
            $severity
        );

        $this->redirect('index');
    }
}


1			<?php
2			namespace ApacheSolrForTypo3\Solr\Controller\Backend\Search;
3
4			/***************************************************************
5			* Copyright notice
6			*
7			* (c) 2013-2015 Ingo Renner <[email protected]>
8			* All rights reserved
9			*
10			* This script is part of the TYPO3 project. The TYPO3 project is
11			* free software; you can redistribute it and/or modify
12			* it under the terms of the GNU General Public License as published by
13			* the Free Software Foundation; either version 2 of the License, or
14			* (at your option) any later version.
15			*
16			* The GNU General Public License can be found at
17			* http://www.gnu.org/copyleft/gpl.html.
18			*
19			* This script is distributed in the hope that it will be useful,
20			* but WITHOUT ANY WARRANTY; without even the implied warranty of
21			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
22			* GNU General Public License for more details.
23			*
24			* This copyright notice MUST APPEAR in all copies of the script!
25			***************************************************************/
26
27			use ApacheSolrForTypo3\Solr\Backend\IndexingConfigurationSelectorField;
28			use ApacheSolrForTypo3\Solr\Domain\Index\IndexService;
29			use ApacheSolrForTypo3\Solr\IndexQueue\Queue;
30			use TYPO3\CMS\Backend\View\BackendTemplateView;
31			use TYPO3\CMS\Core\Messaging\FlashMessage;
32			use TYPO3\CMS\Core\Utility\GeneralUtility;
33			use TYPO3\CMS\Extbase\Mvc\View\ViewInterface;
34			use TYPO3\CMS\Extbase\Utility\LocalizationUtility;
35
36			/**
37			* Index Queue Module
38			*
39			* @author Ingo Renner <[email protected]>
40			* @property BackendTemplateView $view
41			*/
42			class IndexQueueModuleController extends AbstractModuleController
43			{
44
45			/**
46			* Module name, used to identify a module f.e. in URL parameters.
47			*
48			* @var string
49			*/
50			protected $moduleName = 'IndexQueue';
51
52			/**
53			* Module title, shows up in the module menu.
54			*
55			* @var string
56			*/
57			protected $moduleTitle = 'Index Queue';
58
59			/**
60			* @var Queue
61			*/
62			protected $indexQueue;
63
64			/**
65			* Initializes the controller before invoking an action method.
66			*/
67			protected function initializeAction()
68			{
69			parent::initializeAction();
70			$this->indexQueue = GeneralUtility::makeInstance(Queue::class);
71			}
72
73			/**
74			* Set up the doc header properly here
75			*
76			* @param ViewInterface $view
77			* @return void
78			*/
79			protected function initializeView(ViewInterface $view)
80			{
81			parent::initializeView($view);
82			}
83
84			/**
85			* Lists the available indexing configurations
86			*
87			* @return void
88			*/
89			public function indexAction()
90			{
91			if ($this->selectedSite === null) {
92			$this->view->assignMultiple([
93			'can_not_proceed' => true,
94			'pageUID' => $this->selectedPageUID
95			]);
96			return;
97			}
98
99			$statistics = $this->indexQueue->getStatisticsBySite($this->selectedSite);
100			$this->view->assign('indexQueueInitializationSelector', $this->getIndexQueueInitializationSelector());
101			$this->view->assign('indexqueue_statistics', $statistics);
102			$this->view->assign('indexqueue_errors', $this->indexQueue->getErrorsBySite($this->selectedSite));
103			}
104
105			/**
106			* Renders a field to select which indexing configurations to initialize.
107			*
108			* Uses TCEforms.
109			*
110			* @return string Markup for the select field
111			*/
112			protected function getIndexQueueInitializationSelector()
113			{
114			$selector = GeneralUtility::makeInstance(IndexingConfigurationSelectorField::class, $this->selectedSite);
115			$selector->setFormElementName('tx_solr-index-queue-initialization');
116
117			return $selector->render();
118			}
119
120			/**
121			* Initializes the Index Queue for selected indexing configurations
122			*
123			* @return void
124			*/
125			public function initializeIndexQueueAction()
126			{
127			$initializedIndexingConfigurations = [];
128
129			$indexingConfigurationsToInitialize = GeneralUtility::_POST('tx_solr-index-queue-initialization');
130			if ((!empty($indexingConfigurationsToInitialize)) && (is_array($indexingConfigurationsToInitialize))) {
131			// initialize selected indexing configuration
132			foreach ($indexingConfigurationsToInitialize as $indexingConfigurationName) {
133			$initializedIndexingConfiguration = $this->indexQueue->initialize(
134			$this->selectedSite,
135			$indexingConfigurationName
136			);
137
138			// track initialized indexing configurations for the flash message
139			$initializedIndexingConfigurations = array_merge(
140			$initializedIndexingConfigurations,
141			$initializedIndexingConfiguration
142			);
143			}
144			} else {
145			$messageLabel = 'solr.backend.index_queue_module.flashmessage.initialize.no_selection';
146			$titleLabel = 'solr.backend.index_queue_module.flashmessage.not_initialized.title';
147			$this->addFlashMessage(
148			LocalizationUtility::translate($messageLabel, 'Solr'),
149			LocalizationUtility::translate($titleLabel, 'Solr'),
150			FlashMessage::WARNING
151			);
152			}
153
154			$messagesForConfigurations = [];
155			foreach (array_keys($initializedIndexingConfigurations) as $indexingConfigurationName) {
156			$itemCount = $this->indexQueue->getStatisticsBySite($this->selectedSite, $indexingConfigurationName)->getTotalCount();
157			$messagesForConfigurations[] = $indexingConfigurationName . ' (' . $itemCount . ' records)';
158			}
159
160			if (!empty($initializedIndexingConfigurations)) {
161			$messageLabel = 'solr.backend.index_queue_module.flashmessage.initialize.success';
162			$titleLabel = 'solr.backend.index_queue_module.flashmessage.initialize.title';
163			$this->addFlashMessage(
164			LocalizationUtility::translate($messageLabel, 'Solr',
165			[implode(', ', $messagesForConfigurations)]),
166			LocalizationUtility::translate($titleLabel, 'Solr'),
167			FlashMessage::OK
168			);
169			}
170
171			$this->redirect('index');
172			}
173
174			/**
175			* Removes all errors in the index queue list. So that the items can be indexed again.
176			*
177			* @return void
178			*/
179			public function resetLogErrorsAction()
180			{
181			$resetResult = $this->indexQueue->resetAllErrors();
182
183			$label = 'solr.backend.index_queue_module.flashmessage.success.reset_errors';
184			$severity = FlashMessage::OK;
185			if (!$resetResult) {
186			$label = 'solr.backend.index_queue_module.flashmessage.error.reset_errors';
187			$severity = FlashMessage::ERROR;
188			}
189
190			$this->addFlashMessage(
191			LocalizationUtility::translate($label, 'Solr'),
192			LocalizationUtility::translate('solr.backend.index_queue_module.flashmessage.title', 'Solr'),
193			$severity
194			);
195
196			$this->redirect('index');
197			}
198
199			/**
200			* Shows the error message for one queue item.
201			*
202			* @param int $indexQueueItemId
203			* @return void
204			*/
205			public function showErrorAction(int $indexQueueItemId)
206			{
207			if (is_null($indexQueueItemId)) {
208			// add a flash message and quit
209			$label = 'solr.backend.index_queue_module.flashmessage.error.no_queue_item_for_queue_error';
210			$severity = FlashMessage::ERROR;
211			$this->addFlashMessage(
212			LocalizationUtility::translate($label, 'Solr'),
213			LocalizationUtility::translate('solr.backend.index_queue_module.flashmessage.title',
214			'Solr'),
215			$severity
216			);
217
218			return;
219			}
220
221			$item = $this->indexQueue->getItem($indexQueueItemId);
222			$this->view->assign('indexQueueItem', $item);
223			}
224
225			/**
226			* Indexes a few documents with the index service.
227			* @return void
228			*/
229			public function doIndexingRunAction()
230			{
231			/** @var $indexService \ApacheSolrForTypo3\Solr\Domain\Index\IndexService */
232			$indexService = GeneralUtility::makeInstance(IndexService::class, $this->selectedSite);
233			$indexWithoutErrors = $indexService->indexItems(10);
234
235			$label = 'solr.backend.index_queue_module.flashmessage.success.index_manual';
236			$severity = FlashMessage::OK;
237			if (!$indexWithoutErrors) {
238			$label = 'solr.backend.index_queue_module.flashmessage.error.index_manual';
239			$severity = FlashMessage::ERROR;
240			}
241
242			$this->addFlashMessage(
243			LocalizationUtility::translate($label, 'Solr'),
244			LocalizationUtility::translate('solr.backend.index_queue_module.flashmessage.index_manual', 'Solr'),
245			$severity
246			);
247
248			$this->redirect('index');
249			}
250			}
251

TYPO3-Solr / ext-solr

Pull Request — master (#1317)

initializeIndexQueueAction() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like