View GitHub Repository ext-solr

Schedule Inspection
Subscribe
Failed Conditions
Pull Request — master (#1308)
by Timo
21:31
created
Status
Category
Toggle Patches
Search/ResultSet/Facets/OptionBased/QueryGroup/QueryGroupFacetParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -32,7 +32,7 @@
 
 block discarded – undo
32 32 
      * @param SearchResultSet $resultSet
33 33 
      * @param string $facetName
34 34 
      * @param array $facetConfiguration
35 
-     * @return QueryGroupFacet|null
35 
+     * @return null|\ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\AbstractOptionsFacet
36 36 
      */
37 37 
     public function parse(SearchResultSet $resultSet, $facetName, array $facetConfiguration)
38 38 
     {
Please login to merge, or discard this patch.
Classes/ViewHelpers/Document/RelevanceViewHelper.php 3 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -14,7 +14,6 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Search;
18 17 
 use ApacheSolrForTypo3\Solr\ViewHelpers\AbstractViewHelper;
19 18 
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
20 19 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -67,7 +67,7 @@
 
 block discarded – undo
67 67 
             /** @var $resultSet SearchResultSet */
68 68 
         $resultSet = $arguments['resultSet'];
69 69
70 
-        $maximumScore = $document->__solr_grouping_groupMaximumScore ? : $resultSet->getUsedSearch()->getMaximumResultScore();
70 
+        $maximumScore = $document->__solr_grouping_groupMaximumScore ?: $resultSet->getUsedSearch()->getMaximumResultScore();
71 71 
         $content = 0;
72 72
73 73 
         if ($maximumScore <= 0) {
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -59,7 +59,7 @@
 
 block discarded – undo
59 59
60 60 
     /**
61 61 
      * @param array $arguments
62 
-     * @param callable $renderChildrenClosure
62 
+     * @param \Closure $renderChildrenClosure
63 63 
      * @param RenderingContextInterface $renderingContext
64 64 
      * @return string
65 65 
      */
Please login to merge, or discard this patch.
Classes/ViewHelpers/PageBrowserRangeViewHelper.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -14,7 +14,6 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 17 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
19 18 
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
20 19
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -59,7 +59,7 @@
 
 block discarded – undo
59 59
60 60 
     /**
61 61 
      * @param array $arguments
62 
-     * @param callable $renderChildrenClosure
62 
+     * @param \Closure $renderChildrenClosure
63 63 
      * @param RenderingContextInterface $renderingContext
64 64 
      * @return string
65 65 
      */
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Facet/RemoveAllFacetsViewHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -49,7 +49,7 @@
 
 block discarded – undo
49 49 
     }
50 50 
     /**
51 51 
      * @param array $arguments
52 
-     * @param callable $renderChildrenClosure
52 
+     * @param \Closure $renderChildrenClosure
53 53 
      * @param RenderingContextInterface $renderingContext
54 54 
      * @return string
55 55 
      * @throws \InvalidArgumentException
Please login to merge, or discard this patch.
Unused Use Statements   -9 removed lines patch added patch discarded remove patch 
@@ -14,16 +14,7 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
19 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionsFacet\Option;
20 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionsFacet\OptionsFacet;
21 
-use ApacheSolrForTypo3\Solr\Domain\Search\Uri\SearchUriBuilder;
22 
-use ApacheSolrForTypo3\Solr\Mvc\Controller\SolrControllerContext;
23 
-use ApacheSolrForTypo3\Solr\ViewHelpers\AbstractTagBasedViewHelper;
24 17 
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
25 
-use TYPO3\CMS\Core\Utility\GeneralUtility;
26 
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
27 18 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
28 19 
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
29 20
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Facet/RemoveFacetViewHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -44,7 +44,7 @@
 
 block discarded – undo
44 44
45 45 
     /**
46 46 
      * @param array $arguments
47 
-     * @param callable $renderChildrenClosure
47 
+     * @param \Closure $renderChildrenClosure
48 48 
      * @param RenderingContextInterface $renderingContext
49 49 
      * @return string
50 50 
      * @throws \InvalidArgumentException
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Paginate/ResultPageViewHelper.php 2 patches
Unused Use Statements   -3 removed lines patch added patch discarded remove patch 
@@ -14,10 +14,7 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 17 
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
19 
-use TYPO3\CMS\Core\Utility\GeneralUtility;
20 
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
21 18 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
22 19 
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
23 20
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -59,7 +59,7 @@
 
 block discarded – undo
59 59
60 60 
     /**
61 61 
      * @param array $arguments
62 
-     * @param callable $renderChildrenClosure
62 
+     * @param \Closure $renderChildrenClosure
63 63 
      * @param RenderingContextInterface $renderingContext
64 64 
      * @return string
65 65 
      */
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Search/StartNewSearchViewHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -54,7 +54,7 @@
 
 block discarded – undo
54 54
55 55 
     /**
56 56 
      * @param array $arguments
57 
-     * @param callable|\Closure $renderChildrenClosure
57 
+     * @param \Closure $renderChildrenClosure
58 58 
      * @param RenderingContextInterface $renderingContext
59 59 
      * @return string
60 60 
      */
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch 
@@ -14,10 +14,7 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 17 
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
19 
-use TYPO3\CMS\Core\Utility\GeneralUtility;
20 
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
21 18 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
22 19 
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
23 20
Please login to merge, or discard this patch.
Classes/ViewHelpers/Widget/ResultPaginateViewHelper.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -24,7 +24,6 @@
 
 block discarded – undo
24 24 
  *  This copyright notice MUST APPEAR in all copies of the script!
25 25 
  ***************************************************************/
26 26
27 
-use ApacheSolrForTypo3\Solr\Search;
28 27 
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
29 28 
 use ApacheSolrForTypo3\Solr\Widget\AbstractWidgetViewHelper;
30 29
Please login to merge, or discard this patch.
Classes/Domain/Search/Uri/SearchUriBuilder.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -304,10 +304,10 @@
 
 block discarded – undo
304 304 
             self::$preCompiledLinks[$hash] = $template;
305 305 
         }
306 306
307 
-        $keys = array_map(function ($value) {
307 
+        $keys = array_map(function($value) {
308 308 
             return urlencode($value);
309 309 
         }, array_keys($values));
310 
-        $values = array_map(function ($value) {
310 
+        $values = array_map(function($value) {
311 311 
             return urlencode($value);
312 312 
         }, $values);
313 313 
         $uri = str_replace($keys, $values, $template);
Please login to merge, or discard this patch.