Complex classes like SearchRequest often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use SearchRequest, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 37 | class SearchRequest |
||
| 38 | { |
||
| 39 | /** |
||
| 40 | * @var string |
||
| 41 | */ |
||
| 42 | protected $id; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @var string |
||
| 46 | */ |
||
| 47 | protected $argumentNameSpace = 'tx_solr'; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Arguments that should be kept for sub requests. |
||
| 51 | * |
||
| 52 | * @var array |
||
| 53 | */ |
||
| 54 | protected $persistentArgumentsPaths = ['q', 'tx_solr:filter', 'tx_solr:sort']; |
||
| 55 | |||
| 56 | /** |
||
| 57 | * @var bool |
||
| 58 | */ |
||
| 59 | protected $stateChanged = false; |
||
| 60 | |||
| 61 | /** |
||
| 62 | * @var ArrayAccessor |
||
| 63 | */ |
||
| 64 | protected $argumentsAccessor; |
||
| 65 | |||
| 66 | /** |
||
| 67 | * The sys_language_uid that was used in the context where the request was build. |
||
| 68 | * This could be different from the "L" parameter and and not relevant for urls, |
||
| 69 | * because typolink itself will handle it. |
||
| 70 | * |
||
| 71 | * @var int |
||
| 72 | */ |
||
| 73 | protected $contextSystemLanguageUid; |
||
| 74 | |||
| 75 | /** |
||
| 76 | * The page_uid that was used in the context where the request was build. |
||
| 77 | * |
||
| 78 | * The pageUid is not relevant for the typolink additionalArguments and therefore |
||
| 79 | * a separate property. |
||
| 80 | * |
||
| 81 | * @var int |
||
| 82 | */ |
||
| 83 | protected $contextPageUid; |
||
| 84 | |||
| 85 | /** |
||
| 86 | * @var TypoScriptConfiguration |
||
| 87 | */ |
||
| 88 | protected $contextTypoScriptConfiguration; |
||
| 89 | |||
| 90 | /** |
||
| 91 | * @var array |
||
| 92 | */ |
||
| 93 | protected $persistedArguments = []; |
||
| 94 | |||
| 95 | /** |
||
| 96 | * @param array $argumentsArray |
||
| 97 | * @param int $pageUid |
||
| 98 | * @param int $sysLanguageUid |
||
| 99 | * @param TypoScriptConfiguration $typoScriptConfiguration |
||
| 100 | */ |
||
| 101 | 57 | public function __construct(array $argumentsArray = [], $pageUid = 0, $sysLanguageUid = 0, TypoScriptConfiguration $typoScriptConfiguration = null) |
|
| 111 | |||
| 112 | /** |
||
| 113 | * @return string |
||
| 114 | */ |
||
| 115 | 1 | public function getId() |
|
| 119 | |||
| 120 | /** |
||
| 121 | * Can be used do merge arguments into the request arguments |
||
| 122 | * |
||
| 123 | * @param array $argumentsToMerge |
||
| 124 | * @return SearchRequest |
||
| 125 | */ |
||
| 126 | 24 | public function mergeArguments(array $argumentsToMerge) |
|
| 127 | { |
||
| 128 | 24 | ArrayUtility::mergeRecursiveWithOverrule( |
|
| 129 | 24 | $this->persistedArguments, |
|
| 130 | $argumentsToMerge |
||
| 131 | 24 | ); |
|
| 132 | |||
| 133 | 24 | $this->reset(); |
|
| 134 | |||
| 135 | 24 | return $this; |
|
| 136 | } |
||
| 137 | |||
| 138 | /** |
||
| 139 | * Helper method to prefix an accessor with the arguments namespace. |
||
| 140 | * |
||
| 141 | * @param string $path |
||
| 142 | * @return string |
||
| 143 | */ |
||
| 144 | 48 | protected function prefixWithNamespace($path) |
|
| 148 | |||
| 149 | /** |
||
| 150 | * @return array |
||
| 151 | */ |
||
| 152 | 1 | public function getActiveFacetNames() |
|
| 163 | |||
| 164 | /** |
||
| 165 | * Returns all facet values for a certain facetName |
||
| 166 | * @param string $facetName |
||
| 167 | * @return array |
||
| 168 | */ |
||
| 169 | 1 | public function getActiveFacetValuesByName($facetName) |
|
| 170 | { |
||
| 171 | 1 | $values = []; |
|
| 172 | 1 | $activeFacets = $this->getActiveFacets(); |
|
| 173 | |||
| 174 | array_map(function ($activeFacet) use (&$values, $facetName) { |
||
| 175 | 1 | $parts = explode(':', $activeFacet, 2); |
|
| 176 | 1 | if ($parts[0] === $facetName) { |
|
| 177 | 1 | $values[] = $parts[1]; |
|
| 178 | 1 | } |
|
| 179 | 1 | }, $activeFacets); |
|
| 180 | |||
| 181 | 1 | return $values; |
|
| 182 | } |
||
| 183 | |||
| 184 | /** |
||
| 185 | * @return array |
||
| 186 | */ |
||
| 187 | 11 | protected function getActiveFacets() |
|
| 194 | |||
| 195 | /** |
||
| 196 | * @return int |
||
| 197 | */ |
||
| 198 | 2 | public function getActiveFacetCount() |
|
| 202 | |||
| 203 | /** |
||
| 204 | * @param $activeFacets |
||
| 205 | * |
||
| 206 | * @return SearchRequest |
||
| 207 | */ |
||
| 208 | 8 | protected function setActiveFacets($activeFacets = []) |
|
| 215 | |||
| 216 | /** |
||
| 217 | * Adds a facet value to the request. |
||
| 218 | * |
||
| 219 | * @param string $facetName |
||
| 220 | * @param mixed $facetValue |
||
| 221 | * |
||
| 222 | * @return SearchRequest |
||
| 223 | */ |
||
| 224 | 6 | public function addFacetValue($facetName, $facetValue) |
|
| 237 | |||
| 238 | /** |
||
| 239 | * Removes a facet value from the request. |
||
| 240 | * |
||
| 241 | * @param string $facetName |
||
| 242 | * @param mixed $facetValue |
||
| 243 | * |
||
| 244 | * @return SearchRequest |
||
| 245 | */ |
||
| 246 | 1 | public function removeFacetValue($facetName, $facetValue) |
|
| 247 | { |
||
| 248 | 1 | if (!$this->getHasFacetValue($facetName, $facetValue)) { |
|
| 249 | return $this; |
||
| 250 | } |
||
| 251 | 1 | $facetValues = $this->getActiveFacets(); |
|
| 252 | 1 | $facetValueToLookFor = $facetName . ':' . $facetValue; |
|
| 253 | |||
| 254 | 1 | foreach ($facetValues as $index => $facetValue) { |
|
| 255 | 1 | if ($facetValue === $facetValueToLookFor) { |
|
| 256 | 1 | unset($facetValues[$index]); |
|
| 257 | 1 | break; |
|
| 258 | } |
||
| 259 | 1 | } |
|
| 260 | |||
| 261 | 1 | $this->setActiveFacets($facetValues); |
|
| 262 | 1 | $this->stateChanged = true; |
|
| 263 | 1 | return $this; |
|
| 264 | } |
||
| 265 | |||
| 266 | /** |
||
| 267 | * Removes all facet values from the request by a certain facet name |
||
| 268 | * |
||
| 269 | * @param string $facetName |
||
| 270 | * |
||
| 271 | * @return SearchRequest |
||
| 272 | */ |
||
| 273 | 1 | public function removeAllFacetValuesByName($facetName) |
|
| 285 | |||
| 286 | /** |
||
| 287 | * Removes all active facets from the request. |
||
| 288 | * |
||
| 289 | * @return SearchRequest |
||
| 290 | */ |
||
| 291 | 1 | public function removeAllFacets() |
|
| 298 | |||
| 299 | /** |
||
| 300 | * @param string $facetName |
||
| 301 | * @param mixed $facetValue |
||
| 302 | * @return bool |
||
| 303 | */ |
||
| 304 | 7 | public function getHasFacetValue($facetName, $facetValue) |
|
| 309 | |||
| 310 | /** |
||
| 311 | * @return bool |
||
| 312 | */ |
||
| 313 | 3 | public function getHasSorting() |
|
| 318 | |||
| 319 | /** |
||
| 320 | * Returns the sorting string in the url e.g. title asc. |
||
| 321 | * |
||
| 322 | * @return string |
||
| 323 | */ |
||
| 324 | 2 | protected function getSorting() |
|
| 329 | |||
| 330 | /** |
||
| 331 | * Helper function to get the sorting configuration name or direction. |
||
| 332 | * |
||
| 333 | * @param int $index |
||
| 334 | * @return string |
||
| 335 | */ |
||
| 336 | 2 | protected function getSortingPart($index) |
|
| 346 | |||
| 347 | /** |
||
| 348 | * Returns the sorting configuration name that is currently used. |
||
| 349 | * |
||
| 350 | * @return string |
||
| 351 | */ |
||
| 352 | 2 | public function getSortingName() |
|
| 356 | |||
| 357 | /** |
||
| 358 | * Returns the sorting direction that is currently used. |
||
| 359 | * |
||
| 360 | * @return string |
||
| 361 | */ |
||
| 362 | 1 | public function getSortingDirection() |
|
| 366 | |||
| 367 | /** |
||
| 368 | * @return SearchRequest |
||
| 369 | */ |
||
| 370 | 1 | public function removeSorting() |
|
| 377 | |||
| 378 | /** |
||
| 379 | * @param string $sortingName |
||
| 380 | * @param string $direction (asc or desc) |
||
| 381 | * |
||
| 382 | * @return SearchRequest |
||
| 383 | */ |
||
| 384 | 1 | public function setSorting($sortingName, $direction = 'asc') |
|
| 392 | |||
| 393 | /** |
||
| 394 | * Method to set the paginated page of the search |
||
| 395 | * |
||
| 396 | * @param int $page |
||
| 397 | * @return SearchRequest |
||
| 398 | */ |
||
| 399 | 1 | public function setPage($page) |
|
| 406 | |||
| 407 | /** |
||
| 408 | * Returns the passed page. |
||
| 409 | * |
||
| 410 | * @return int|null |
||
| 411 | */ |
||
| 412 | 33 | public function getPage() |
|
| 417 | |||
| 418 | /** |
||
| 419 | * Method to overwrite the query string. |
||
| 420 | * |
||
| 421 | * @param string $rawQueryString |
||
| 422 | * @return SearchRequest |
||
| 423 | */ |
||
| 424 | 10 | public function setRawQueryString($rawQueryString) |
|
| 430 | |||
| 431 | /** |
||
| 432 | * Returns the passed rawQueryString. |
||
| 433 | * |
||
| 434 | * @return string |
||
| 435 | */ |
||
| 436 | 32 | public function getRawUserQuery() |
|
| 440 | |||
| 441 | /** |
||
| 442 | * Method to check if the query string is an empty string |
||
| 443 | * (also empty string or whitespaces only are handled as empty). |
||
| 444 | * |
||
| 445 | * When no query string is set (null) the method returns false. |
||
| 446 | * @return bool |
||
| 447 | */ |
||
| 448 | 34 | public function getRawUserQueryIsEmptyString() |
|
| 462 | |||
| 463 | /** |
||
| 464 | * This method returns true when no querystring is present at all. |
||
| 465 | * Which means no search by the user was triggered |
||
| 466 | * |
||
| 467 | * @return bool |
||
| 468 | */ |
||
| 469 | 34 | public function getRawUserQueryIsNull() |
|
| 474 | |||
| 475 | /** |
||
| 476 | * Sets the results per page that are used during search. |
||
| 477 | * |
||
| 478 | * @param int $resultsPerPage |
||
| 479 | * @return SearchRequest |
||
| 480 | */ |
||
| 481 | 1 | public function setResultsPerPage($resultsPerPage) |
|
| 489 | |||
| 490 | /** |
||
| 491 | * @return bool |
||
| 492 | */ |
||
| 493 | 1 | public function getStateChanged() |
|
| 497 | |||
| 498 | /** |
||
| 499 | * Returns the passed resultsPerPage value |
||
| 500 | * @return int|null |
||
| 501 | */ |
||
| 502 | 31 | public function getResultsPerPage() |
|
| 507 | |||
| 508 | /** |
||
| 509 | * @return int |
||
| 510 | */ |
||
| 511 | 1 | public function getContextSystemLanguageUid() |
|
| 515 | |||
| 516 | /** |
||
| 517 | * @return int |
||
| 518 | */ |
||
| 519 | 2 | public function getContextPageUid() |
|
| 523 | |||
| 524 | /** |
||
| 525 | * Get contextTypoScriptConfiguration |
||
| 526 | * |
||
| 527 | * @return TypoScriptConfiguration |
||
| 528 | */ |
||
| 529 | 2 | public function getContextTypoScriptConfiguration() |
|
| 533 | |||
| 534 | /** |
||
| 535 | * Assigns the last known persistedArguments and restores their state. |
||
| 536 | * |
||
| 537 | * @return SearchRequest |
||
| 538 | */ |
||
| 539 | 57 | public function reset() |
|
| 545 | |||
| 546 | /** |
||
| 547 | * This can be used to start a new sub request, e.g. for a faceted search. |
||
| 548 | * |
||
| 549 | * @param bool $onlyPersistentArguments |
||
| 550 | * @return SearchRequest |
||
| 551 | */ |
||
| 552 | 2 | public function getCopyForSubRequest($onlyPersistentArguments = true) |
|
| 553 | { |
||
| 554 | 2 | if (!$onlyPersistentArguments) { |
|
| 555 | // create a new request with all data |
||
| 556 | $argumentsArray = $this->argumentsAccessor->getData(); |
||
| 557 | return new SearchRequest($argumentsArray); |
||
| 558 | } |
||
| 559 | |||
| 560 | 2 | $arguments = new ArrayAccessor(); |
|
| 561 | 2 | foreach ($this->persistentArgumentsPaths as $persistentArgumentPath) { |
|
| 562 | 2 | if ($this->argumentsAccessor->has($persistentArgumentPath)) { |
|
| 563 | 2 | $arguments->set($persistentArgumentPath, $this->argumentsAccessor->get($persistentArgumentPath)); |
|
| 564 | 2 | } |
|
| 565 | 2 | } |
|
| 566 | |||
| 567 | 2 | return new SearchRequest($arguments->getData()); |
|
| 568 | } |
||
| 569 | |||
| 570 | /** |
||
| 571 | * @return array |
||
| 572 | */ |
||
| 573 | 8 | public function getAsArray() |
|
| 577 | } |
||
| 578 |