ApacheSolrForTypo3\Solr\Domain\Search\Uri\SearchUriBuilder::buildLinkWithInMemoryCache()

Complexity

Conditions	5
Paths	4

Size

Total Lines	77
Code Lines	52

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	47
CRAP Score	5.1349

Importance

Changes

0

<?php
    protected function buildLinkWithInMemoryCache(int $pageUid, array $arguments): string
    {
        $values = [];
        $structure = $arguments;
        $this->getSubstitution($structure, $values);
        $hash = md5($pageUid . json_encode($structure));
        if (isset(self::$preCompiledLinks[$hash])) {
            self::$hitCount++;
            $uriCacheTemplate = self::$preCompiledLinks[$hash];
        } else {
            self::$missCount++;
            $this->uriBuilder->reset()->setTargetPageUid($pageUid);
            $uriCacheTemplate = $this->uriBuilder->setArguments($structure)->setUseCacheHash(false)->build();

The call to TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setUseCacheHash() has too many arguments starting with false.

            // even if we call build with disabled cHash in TYPO3 9 a cHash will be generated when site management is active
            // to prevent wrong cHashes we remove the cHash here from the cached uri template.
            // @todo: This can be removed when https://forge.typo3.org/issues/87120 is resolved and we can ship a proper configuration
            /* @var UrlHelper $urlHelper */
            $urlHelper = GeneralUtility::makeInstance(UrlHelper::class, $uriCacheTemplate);
            $urlHelper->removeQueryParameter('cHash');

The function ApacheSolrForTypo3\Solr\System\Url\UrlHelper::removeQueryParameter() has been deprecated: Will be removed with v12. Use withoutQueryParameter instead.

            self::$preCompiledLinks[$hash] = (string)$urlHelper;
        }

        $keys = array_map(function($value) {
            return urlencode($value);
        }, array_keys($values));
        $values = array_map(function($value) {
            return urlencode($value);
        }, $values);

        $routingConfigurations = $this->routingService
            ->fetchEnhancerByPageUid($pageUid);
        $enhancedRouting = count($routingConfigurations) > 0;
        $this->routingService->reset();
        if ($enhancedRouting && is_array($routingConfigurations[0])) {
            $this->routingService->fromRoutingConfiguration($routingConfigurations[0]);
        }

        /* @var Uri $uri */
        $uri = GeneralUtility::makeInstance(
            Uri::class,
            $uriCacheTemplate
        );

        $urlEvent = new BeforeReplaceVariableInCachedUrlEvent($uri, $enhancedRouting);
        /* @var BeforeReplaceVariableInCachedUrlEvent $urlEvent */
        $urlEvent = $this->eventDispatcher->dispatch($urlEvent);
        $uriCacheTemplate = (string)$urlEvent->getUri();

        $variableEvent = new BeforeProcessCachedVariablesEvent(
            $uri,
            $routingConfigurations,
            $keys,
            $values
        );
        $this->eventDispatcher->dispatch($variableEvent);

        $values = $variableEvent->getVariableValues();
        // Take care that everything is urlencoded!
        $keys = array_map(function($value) {
            // @TODO: With only PHP 8 support, replace this with str_contains()
            if (strpos($value, '###') === false) {
                return $value;
            }
            return urlencode($value);
        }, array_keys($values));

        $uri = str_replace($keys, $values, $uriCacheTemplate);
        $uri = GeneralUtility::makeInstance(
            Uri::class,
            $uri
        );
        $uriEvent = new PostProcessUriEvent($uri, $routingConfigurations);
        $this->eventDispatcher->dispatch($uriEvent);
        $uri = $uriEvent->getUri();
        return (string)$uri;
    }