Complex classes like Util often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Util, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
49 | class Util |
||
50 | { |
||
51 | |||
52 | /** |
||
53 | * Generates a document id for documents representing page records. |
||
54 | * |
||
55 | * @param int $uid The page's uid |
||
56 | * @param int $typeNum The page's typeNum |
||
57 | * @param int $language the language id, defaults to 0 |
||
58 | * @param string $accessGroups comma separated list of uids of groups that have access to that page |
||
59 | * @param string $mountPointParameter The mount point parameter that is used to access the page. |
||
60 | * @return string The document id for that page |
||
61 | */ |
||
62 | 45 | public static function getPageDocumentId( |
|
63 | $uid, |
||
64 | $typeNum = 0, |
||
65 | $language = 0, |
||
66 | $accessGroups = '0,-1', |
||
67 | $mountPointParameter = '' |
||
68 | ) { |
||
69 | 45 | $additionalParameters = $typeNum . '/' . $language . '/' . $accessGroups; |
|
70 | |||
71 | 45 | if ((string)$mountPointParameter !== '') { |
|
72 | $additionalParameters = $mountPointParameter . '/' . $additionalParameters; |
||
73 | } |
||
74 | |||
75 | 45 | $documentId = self::getDocumentId( |
|
76 | 45 | 'pages', |
|
77 | 45 | $uid, |
|
78 | 45 | $uid, |
|
79 | $additionalParameters |
||
80 | 45 | ); |
|
81 | |||
82 | 45 | return $documentId; |
|
83 | } |
||
84 | |||
85 | /** |
||
86 | * Generates a document id in the form $siteHash/$type/$uid. |
||
87 | * |
||
88 | * @param string $table The records table name |
||
89 | * @param int $pid The record's pid |
||
90 | * @param int $uid The record's uid |
||
91 | * @param string $additionalIdParameters Additional ID parameters |
||
92 | * @return string A document id |
||
93 | */ |
||
94 | 56 | public static function getDocumentId( |
|
95 | $table, |
||
96 | $pid, |
||
97 | $uid, |
||
98 | $additionalIdParameters = '' |
||
99 | ) { |
||
100 | 56 | $siteRepository = GeneralUtility::makeInstance(SiteRepository::class); |
|
101 | 56 | $site = $siteRepository->getSiteByPageId($pid); |
|
102 | 56 | $siteHash = $site->getSiteHash(); |
|
103 | |||
104 | 56 | $documentId = $siteHash . '/' . $table . '/' . $uid; |
|
105 | 56 | if (!empty($additionalIdParameters)) { |
|
106 | 45 | $documentId .= '/' . $additionalIdParameters; |
|
107 | 45 | } |
|
108 | |||
109 | 56 | return $documentId; |
|
110 | } |
||
111 | |||
112 | /** |
||
113 | * Returns given word as CamelCased. |
||
114 | * |
||
115 | * Converts a word like "send_email" to "SendEmail". It |
||
116 | * will remove non alphanumeric characters from the word, so |
||
117 | * "who's online" will be converted to "WhoSOnline" |
||
118 | * |
||
119 | * @param string $word Word to convert to camel case |
||
120 | * @return string UpperCamelCasedWord |
||
121 | */ |
||
122 | public static function camelize($word) |
||
123 | { |
||
124 | return str_replace(' ', '', |
||
125 | ucwords(preg_replace('![^A-Z^a-z^0-9]+!', ' ', $word))); |
||
126 | } |
||
127 | |||
128 | /** |
||
129 | * Returns a given CamelCasedString as an lowercase string with underscores. |
||
130 | * Example: Converts BlogExample to blog_example, and minimalValue to minimal_value |
||
131 | * |
||
132 | * @param string $string String to be converted to lowercase underscore |
||
133 | * @return string lowercase_and_underscored_string |
||
134 | */ |
||
135 | public static function camelCaseToLowerCaseUnderscored($string) |
||
136 | { |
||
137 | return strtolower(preg_replace('/(?<=\w)([A-Z])/', '_\\1', $string)); |
||
138 | } |
||
139 | |||
140 | /** |
||
141 | * Returns a given string with underscores as UpperCamelCase. |
||
142 | * Example: Converts blog_example to BlogExample |
||
143 | * |
||
144 | * @param string $string String to be converted to camel case |
||
145 | * @return string UpperCamelCasedWord |
||
146 | */ |
||
147 | public static function underscoredToUpperCamelCase($string) |
||
148 | { |
||
149 | return str_replace(' ', '', |
||
150 | ucwords(str_replace('_', ' ', strtolower($string)))); |
||
151 | } |
||
152 | |||
153 | /** |
||
154 | * Shortcut to retrieve the TypoScript configuration for EXT:solr |
||
155 | * (plugin.tx_solr) from TSFE. |
||
156 | * |
||
157 | * @return TypoScriptConfiguration |
||
158 | */ |
||
159 | public static function getSolrConfiguration() |
||
160 | { |
||
161 | $configurationManager = self::getConfigurationManager(); |
||
162 | |||
163 | return $configurationManager->getTypoScriptConfiguration(); |
||
164 | } |
||
165 | |||
166 | /** |
||
167 | * @return ConfigurationManager |
||
168 | */ |
||
169 | private static function getConfigurationManager() |
||
170 | { |
||
171 | /** @var ConfigurationManager $configurationManager */ |
||
172 | $configurationManager = GeneralUtility::makeInstance(ConfigurationManager::class); |
||
173 | return $configurationManager; |
||
174 | } |
||
175 | |||
176 | /** |
||
177 | * Gets the Solr configuration for a specific root page id. |
||
178 | * To be used from the backend. |
||
179 | * |
||
180 | * @param int $pageId Id of the (root) page to get the Solr configuration from. |
||
181 | * @param bool $initializeTsfe Optionally initializes a full TSFE to get the configuration, defaults to FALSE |
||
182 | * @param int $language System language uid, optional, defaults to 0 |
||
183 | * @return TypoScriptConfiguration The Solr configuration for the requested tree. |
||
184 | */ |
||
185 | public static function getSolrConfigurationFromPageId( |
||
186 | $pageId, |
||
187 | $initializeTsfe = false, |
||
188 | $language = 0 |
||
189 | ) { |
||
190 | $rootPath = ''; |
||
191 | return self::getConfigurationFromPageId($pageId, $rootPath, $initializeTsfe, $language); |
||
192 | } |
||
193 | |||
194 | /** |
||
195 | * Loads the TypoScript configuration for a given page id and language. |
||
196 | * Language usage may be disabled to get the default TypoScript |
||
197 | * configuration. |
||
198 | * |
||
199 | * @param int $pageId Id of the (root) page to get the Solr configuration from. |
||
200 | * @param string $path The TypoScript configuration path to retrieve. |
||
201 | * @param bool $initializeTsfe Optionally initializes a full TSFE to get the configuration, defaults to FALSE |
||
202 | * @param int $language System language uid, optional, defaults to 0 |
||
203 | * @param bool $useTwoLevelCache Flag to enable the two level cache for the typoscript configuration array |
||
204 | * @return TypoScriptConfiguration The Solr configuration for the requested tree. |
||
205 | */ |
||
206 | public static function getConfigurationFromPageId( |
||
207 | 26 | $pageId, |
|
208 | $path, |
||
209 | 26 | $initializeTsfe = false, |
|
210 | 26 | $language = 0, |
|
211 | $useTwoLevelCache = true |
||
212 | ) { |
||
213 | $pageId = self::getConfigurationPageIdToUse($pageId); |
||
214 | |||
215 | static $configurationObjectCache = []; |
||
216 | $cacheId = md5($pageId . '|' . $path . '|' . $language); |
||
217 | if (isset($configurationObjectCache[$cacheId])) { |
||
218 | return $configurationObjectCache[$cacheId]; |
||
219 | 156 | } |
|
220 | |||
221 | 156 | // If we're on UID 0, we cannot retrieve a configuration currently. |
|
222 | // getRootline() below throws an exception (since #typo3-60 ) |
||
223 | 156 | // as UID 0 cannot have any parent rootline by design. |
|
224 | if ($pageId == 0) { |
||
225 | return $configurationObjectCache[$cacheId] = self::buildTypoScriptConfigurationFromArray([], $pageId, $language, $path); |
||
226 | } |
||
227 | |||
228 | if ($useTwoLevelCache) { |
||
229 | 195 | /** @var $cache TwoLevelCache */ |
|
230 | $cache = GeneralUtility::makeInstance(TwoLevelCache::class, 'tx_solr_configuration'); |
||
231 | $configurationArray = $cache->get($cacheId); |
||
232 | 195 | } |
|
233 | 195 | ||
234 | if (!empty($configurationArray)) { |
||
235 | // we have a cache hit and can return it. |
||
236 | return $configurationObjectCache[$cacheId] = self::buildTypoScriptConfigurationFromArray($configurationArray, $pageId, $language, $path); |
||
237 | } |
||
238 | |||
239 | // we have nothing in the cache. We need to build the configurationToUse |
||
240 | $configurationArray = self::buildConfigurationArray($pageId, $path, $initializeTsfe, $language); |
||
241 | |||
242 | if ($useTwoLevelCache && isset($cache)) { |
||
243 | $cache->set($cacheId, $configurationArray); |
||
244 | } |
||
245 | 63 | ||
246 | return $configurationObjectCache[$cacheId] = self::buildTypoScriptConfigurationFromArray($configurationArray, $pageId, $language, $path); |
||
247 | } |
||
248 | |||
249 | /** |
||
250 | 63 | * This method retrieves the closest pageId where a configuration is located, when this |
|
251 | 63 | * feature is enabled. |
|
252 | * |
||
253 | * @param int $pageId |
||
254 | * @return int |
||
255 | */ |
||
256 | protected static function getConfigurationPageIdToUse($pageId) |
||
257 | { |
||
258 | $extensionConfiguration = GeneralUtility::makeInstance(ExtensionConfiguration::class); |
||
259 | if ($extensionConfiguration->getIsUseConfigurationFromClosestTemplateEnabled()) { |
||
260 | /** @var $configurationPageResolve ConfigurationPageResolver */ |
||
261 | $configurationPageResolver = GeneralUtility::makeInstance(ConfigurationPageResolver::class); |
||
262 | $pageId = $configurationPageResolver->getClosestPageIdWithActiveTemplate($pageId); |
||
263 | return $pageId; |
||
264 | } |
||
265 | return $pageId; |
||
266 | 65 | } |
|
267 | |||
268 | /** |
||
269 | * Initializes a TSFE, if required and builds an configuration array, containing the solr configuration. |
||
270 | * |
||
271 | * @param integer $pageId |
||
272 | * @param string $path |
||
273 | 65 | * @param boolean $initializeTsfe |
|
274 | * @param integer $language |
||
275 | 65 | * @return array |
|
276 | 65 | */ |
|
277 | 65 | protected static function buildConfigurationArray($pageId, $path, $initializeTsfe, $language) |
|
278 | 57 | { |
|
279 | if ($initializeTsfe) { |
||
280 | self::initializeTsfe($pageId, $language); |
||
281 | $configurationToUse = self::getConfigurationFromInitializedTSFE($path); |
||
282 | } else { |
||
283 | $configurationToUse = self::getConfigurationFromExistingTSFE($pageId, $path, $language); |
||
284 | 65 | } |
|
285 | 2 | ||
286 | return is_array($configurationToUse) ? $configurationToUse : []; |
||
287 | } |
||
288 | 64 | ||
289 | /** |
||
290 | 64 | * Builds the configuration object from a config array and returns it. |
|
291 | 64 | * |
|
292 | 64 | * @param array $configurationToUse |
|
293 | * @param int $pageId |
||
294 | 64 | * @param int $languageId |
|
295 | * @param string $typoScriptPath |
||
296 | * @return TypoScriptConfiguration |
||
297 | */ |
||
298 | protected static function buildTypoScriptConfigurationFromArray(array $configurationToUse, $pageId, $languageId, $typoScriptPath) |
||
303 | 64 | ||
304 | 64 | /** |
|
305 | * This function is used to retrieve the configuration from a previous initialized TSFE |
||
306 | 64 | * (see: getConfigurationFromPageId) |
|
307 | * |
||
308 | * @param string $path |
||
309 | * @return mixed |
||
310 | */ |
||
311 | private static function getConfigurationFromInitializedTSFE($path) |
||
319 | 65 | ||
320 | /** |
||
321 | * This function is used to retrieve the configuration from an existing TSFE instance |
||
322 | * @param $pageId |
||
323 | * @param $path |
||
324 | * @param $language |
||
325 | 65 | * @return mixed |
|
326 | */ |
||
327 | private static function getConfigurationFromExistingTSFE($pageId, $path, $language) |
||
328 | { |
||
329 | if (is_int($language)) { |
||
330 | GeneralUtility::_GETset($language, 'L'); |
||
331 | } |
||
332 | |||
333 | /** @var $pageSelect PageRepository */ |
||
334 | $pageSelect = GeneralUtility::makeInstance(PageRepository::class); |
||
335 | $rootLine = $pageSelect->getRootLine($pageId); |
||
336 | |||
337 | 64 | $initializedTsfe = false; |
|
338 | $initializedPageSelect = false; |
||
339 | 64 | if (empty($GLOBALS['TSFE']->sys_page)) { |
|
340 | 2 | if (empty($GLOBALS['TSFE'])) { |
|
341 | 2 | $GLOBALS['TSFE'] = new \stdClass(); |
|
342 | 2 | $GLOBALS['TSFE']->tmpl = new \stdClass(); |
|
343 | 64 | $GLOBALS['TSFE']->tmpl->rootLine = $rootLine; |
|
344 | $GLOBALS['TSFE']->sys_page = $pageSelect; |
||
345 | $GLOBALS['TSFE']->id = $pageId; |
||
346 | 64 | $GLOBALS['TSFE']->tx_solr_initTsfe = 1; |
|
347 | $initializedTsfe = true; |
||
348 | } |
||
349 | |||
350 | $GLOBALS['TSFE']->sys_page = $pageSelect; |
||
351 | $initializedPageSelect = true; |
||
352 | } |
||
353 | /** @var $tmpl ExtendedTemplateService */ |
||
354 | $tmpl = GeneralUtility::makeInstance(ExtendedTemplateService::class); |
||
355 | $tmpl->tt_track = false; // Do not log time-performance information |
||
356 | $tmpl->init(); |
||
357 | $tmpl->runThroughTemplates($rootLine); // This generates the constants/config + hierarchy info for the template. |
||
358 | 65 | $tmpl->generateConfig(); |
|
359 | |||
360 | 65 | $getConfigurationFromInitializedTSFEAndWriteToCache = $tmpl->ext_getSetup($tmpl->setup, $path); |
|
361 | 65 | $configurationToUse = $getConfigurationFromInitializedTSFEAndWriteToCache[0]; |
|
362 | |||
363 | if ($initializedPageSelect) { |
||
364 | $GLOBALS['TSFE']->sys_page = null; |
||
365 | } |
||
366 | if ($initializedTsfe) { |
||
367 | unset($GLOBALS['TSFE']); |
||
368 | } |
||
369 | return $configurationToUse; |
||
370 | } |
||
371 | 2 | ||
372 | /** |
||
373 | * Initializes the TSFE for a given page ID and language. |
||
374 | 2 | * |
|
375 | 2 | * @param int $pageId The page id to initialize the TSFE for |
|
376 | 2 | * @param int $language System language uid, optional, defaults to 0 |
|
377 | 2 | * @param bool $useCache Use cache to reuse TSFE |
|
378 | * @return void |
||
379 | */ |
||
380 | public static function initializeTsfe( |
||
381 | $pageId, |
||
382 | $language = 0, |
||
383 | $useCache = true |
||
384 | ) { |
||
385 | static $tsfeCache = []; |
||
386 | |||
387 | 64 | // resetting, a TSFE instance with data from a different page Id could be set already |
|
388 | unset($GLOBALS['TSFE']); |
||
389 | 64 | ||
390 | 64 | $cacheId = $pageId . '|' . $language; |
|
391 | 64 | ||
392 | if (!is_object($GLOBALS['TT'])) { |
||
393 | $GLOBALS['TT'] = GeneralUtility::makeInstance(NullTimeTracker::class); |
||
394 | 64 | } |
|
395 | 64 | ||
396 | if (!isset($tsfeCache[$cacheId]) || !$useCache) { |
||
397 | 64 | GeneralUtility::_GETset($language, 'L'); |
|
398 | 64 | ||
399 | 64 | $GLOBALS['TSFE'] = GeneralUtility::makeInstance(TypoScriptFrontendController::class, |
|
400 | 54 | $GLOBALS['TYPO3_CONF_VARS'], $pageId, 0); |
|
401 | 54 | ||
402 | 54 | // for certain situations we need to trick TSFE into granting us |
|
403 | 54 | // access to the page in any case to make getPageAndRootline() work |
|
404 | 54 | // see http://forge.typo3.org/issues/42122 |
|
405 | 54 | $pageRecord = BackendUtility::getRecord('pages', $pageId, 'fe_group'); |
|
406 | 54 | $groupListBackup = $GLOBALS['TSFE']->gr_list; |
|
407 | 54 | $GLOBALS['TSFE']->gr_list = $pageRecord['fe_group']; |
|
408 | 54 | ||
409 | $GLOBALS['TSFE']->sys_page = GeneralUtility::makeInstance(PageRepository::class); |
||
410 | 54 | $GLOBALS['TSFE']->getPageAndRootline(); |
|
411 | 54 | ||
412 | 54 | // restore gr_list |
|
413 | $GLOBALS['TSFE']->gr_list = $groupListBackup; |
||
414 | 64 | ||
415 | 64 | $GLOBALS['TSFE']->initTemplate(); |
|
416 | 64 | $GLOBALS['TSFE']->forceTemplateParsing = true; |
|
417 | 64 | $GLOBALS['TSFE']->initFEuser(); |
|
418 | 64 | $GLOBALS['TSFE']->initUserGroups(); |
|
419 | // $GLOBALS['TSFE']->getCompressedTCarray(); // seems to cause conflicts sometimes |
||
420 | 64 | ||
421 | 64 | $GLOBALS['TSFE']->no_cache = true; |
|
422 | $GLOBALS['TSFE']->tmpl->start($GLOBALS['TSFE']->rootLine); |
||
423 | 64 | $GLOBALS['TSFE']->no_cache = false; |
|
424 | 54 | $GLOBALS['TSFE']->getConfigArray(); |
|
425 | 54 | ||
426 | 64 | $GLOBALS['TSFE']->settingLanguage(); |
|
427 | 54 | if (!$useCache) { |
|
428 | 54 | $GLOBALS['TSFE']->settingLocale(); |
|
429 | 64 | } |
|
430 | |||
431 | $GLOBALS['TSFE']->newCObj(); |
||
432 | $GLOBALS['TSFE']->absRefPrefix = self::getAbsRefPrefixFromTSFE($GLOBALS['TSFE']); |
||
433 | $GLOBALS['TSFE']->calculateLinkVars(); |
||
434 | |||
435 | if ($useCache) { |
||
436 | $tsfeCache[$cacheId] = $GLOBALS['TSFE']; |
||
437 | } |
||
438 | } |
||
439 | |||
440 | 15 | if ($useCache) { |
|
441 | $GLOBALS['TSFE'] = $tsfeCache[$cacheId]; |
||
442 | $GLOBALS['TSFE']->settingLocale(); |
||
443 | } |
||
444 | } |
||
445 | 15 | ||
446 | /** |
||
447 | * Check if record ($table, $uid) is a workspace record |
||
448 | 15 | * |
|
449 | * @param string $table The table the record belongs to |
||
450 | 15 | * @param int $uid The record's uid |
|
451 | * @return bool TRUE if the record is in a draft workspace, FALSE if it's a LIVE record |
||
452 | 15 | */ |
|
453 | 15 | public static function isDraftRecord($table, $uid) |
|
454 | 15 | { |
|
455 | $isWorkspaceRecord = false; |
||
456 | 15 | ||
457 | 15 | if ((ExtensionManagementUtility::isLoaded('workspaces')) && (BackendUtility::isTableWorkspaceEnabled($table))) { |
|
458 | $record = BackendUtility::getRecord($table, $uid, 'pid, t3ver_state'); |
||
459 | 15 | ||
460 | 15 | if ($record['pid'] == '-1' || $record['t3ver_state'] > 0) { |
|
461 | $isWorkspaceRecord = true; |
||
462 | } |
||
463 | } |
||
464 | |||
465 | 15 | return $isWorkspaceRecord; |
|
466 | 15 | } |
|
467 | 15 | ||
468 | /** |
||
469 | 15 | * Checks whether a record is a localization overlay. |
|
470 | 15 | * |
|
471 | * @param string $tableName The record's table name |
||
472 | * @param array $record The record to check |
||
473 | 15 | * @return bool TRUE if the record is a language overlay, FALSE otherwise |
|
474 | */ |
||
475 | 15 | public static function isLocalizedRecord($tableName, array $record) |
|
489 | |||
490 | /** |
||
491 | 15 | * Check if the page type of a page record is allowed |
|
492 | 15 | * |
|
493 | 15 | * @param array $pageRecord The pages database row |
|
494 | * @param string $configurationName The name of the configuration to use. |
||
495 | 15 | * |
|
496 | 15 | * @return bool TRUE if the page type is allowed, otherwise FALSE |
|
497 | 15 | */ |
|
498 | 15 | public static function isAllowedPageType(array $pageRecord, $configurationName = 'pages') |
|
499 | { |
||
500 | 15 | $isAllowedPageType = false; |
|
501 | 15 | $configurationName = is_null($configurationName) ? 'pages' : $configurationName; |
|
502 | 15 | $allowedPageTypes = self::getAllowedPageTypes($pageRecord['uid'], $configurationName); |
|
503 | 15 | ||
504 | 15 | if (in_array($pageRecord['doktype'], $allowedPageTypes)) { |
|
505 | $isAllowedPageType = true; |
||
506 | } |
||
507 | |||
508 | return $isAllowedPageType; |
||
509 | } |
||
510 | |||
511 | /** |
||
512 | * Get allowed page types |
||
513 | * |
||
514 | * @param int $pageId Page ID |
||
515 | * @param string $configurationName The name of the configuration to use. |
||
516 | * |
||
517 | * @return array Allowed page types to compare to a doktype of a page record |
||
518 | */ |
||
519 | public static function getAllowedPageTypes($pageId, $configurationName = 'pages') |
||
520 | { |
||
521 | $rootPath = ''; |
||
522 | $configuration = self::getConfigurationFromPageId($pageId, $rootPath); |
||
523 | return $configuration->getIndexQueueAllowedPageTypesArrayByConfigurationName($configurationName); |
||
524 | } |
||
525 | |||
526 | /** |
||
527 | * Method to check if a page exists. |
||
528 | * |
||
529 | * @param int $pageId |
||
530 | * @return bool |
||
531 | */ |
||
532 | public static function pageExists($pageId) |
||
533 | { |
||
534 | $page = BackendUtility::getRecord('pages', (int)$pageId, 'uid'); |
||
535 | |||
536 | if (!is_array($page) || $page['uid'] != $pageId) { |
||
537 | return false; |
||
538 | } |
||
539 | |||
540 | return true; |
||
541 | } |
||
542 | |||
543 | /** |
||
544 | * Resolves the configured absRefPrefix to a valid value and resolved if absRefPrefix |
||
545 | * is set to "auto". |
||
546 | * |
||
547 | * @param TypoScriptFrontendController $TSFE |
||
548 | * @return string |
||
549 | */ |
||
550 | public static function getAbsRefPrefixFromTSFE(TypoScriptFrontendController $TSFE) |
||
564 | |||
565 | /** |
||
566 | * This function can be used to check if one of the strings in needles is |
||
567 | * contained in the haystack. |
||
568 | * |
||
569 | * |
||
570 | * Example: |
||
571 | * |
||
572 | * haystack: the brown fox |
||
573 | * needles: ['hello', 'world'] |
||
574 | * result: false |
||
575 | * |
||
576 | * haystack: the brown fox |
||
577 | * needles: ['is', 'fox'] |
||
578 | * result: true |
||
579 | * |
||
580 | 38 | * @param string $haystack |
|
581 | * @param array $needles |
||
582 | 38 | * @return bool |
|
583 | */ |
||
584 | 38 | public static function containsOneOfTheStrings($haystack, array $needles) |
|
595 | } |
||
596 |